mirror of
https://github.com/diegosouzapw/OmniRoute.git
synced 2026-09-16 11:52:26 +03:00
Two shards on release/v3.8.51 went red in one day with the same signature —
"ENOTEMPTY, Directory not empty: /tmp/omniroute-<test>-XXXXXX" — from
combo-same-provider-cascade (Unit Tests fast-path 4/4, on a PR that touches only
.github/) and auth-policy-embeddings-webfetch-7785 (the 20k-test TIA step). Both pass
alone and on re-run: the cleanup races something still writing into the directory
(SQLite WAL/-shm checkpoint, a worker, the backup) and under a loaded hosted runner
the window opens. 1154 test files do their own cleanup with
fs.rmSync(dir, { recursive: true, force: true }); 57 already asked for retries.
One-shot codemod (scripts/ad-hoc/codemod-rm-maxretries.mjs, kept for the record):
every rm / rmSync / rmdirSync option object with `recursive: true` and no
`maxRetries` gains `maxRetries: 5, retryDelay: 100` — Node itself then retries
ENOTEMPTY/EBUSY/EPERM for up to ~0.5 s before giving up. 2243 call sites in 1292
files under tests/, the shared tests/_setup/isolateDataDir.ts exit hook included.
Only the option object changes: no call site, assertion or import is touched.
Validation: prettier and ESLint (with the frozen suppressions) clean on all 1292
files; a random 20-file sample runs green (quota-redis-store hangs identically on
the untouched tree — it needs a Redis on localhost, an environment matter). The
four unit shards on this PR are the full run.
369 lines
13 KiB
TypeScript
369 lines
13 KiB
TypeScript
import test from "node:test";
|
|
import assert from "node:assert/strict";
|
|
import fs from "node:fs";
|
|
import os from "node:os";
|
|
import path from "node:path";
|
|
|
|
const TEST_DATA_DIR = fs.mkdtempSync(path.join(os.tmpdir(), "omniroute-db-settings-"));
|
|
process.env.DATA_DIR = TEST_DATA_DIR;
|
|
process.env.DISABLE_SQLITE_AUTO_BACKUP = "true";
|
|
|
|
const core = await import("../../src/lib/db/core.ts");
|
|
const databaseSettings = await import("../../src/lib/db/databaseSettings.ts");
|
|
const databaseSettingsRoute = await import("../../src/app/api/settings/database/route.ts");
|
|
const purgeRequestHistoryRoute =
|
|
await import("../../src/app/api/settings/purge-request-history/route.ts");
|
|
const settingsDb = await import("../../src/lib/db/settings.ts");
|
|
const cleanup = await import("../../src/lib/db/cleanup.ts");
|
|
const aggregateHistory = await import("../../src/lib/usage/aggregateHistory.ts");
|
|
|
|
type CountRow = {
|
|
count: number;
|
|
};
|
|
|
|
type UsageSummaryRow = {
|
|
total_requests: number;
|
|
total_input_tokens: number;
|
|
total_output_tokens: number;
|
|
total_cost: number;
|
|
};
|
|
|
|
function resetStorage() {
|
|
core.resetDbInstance();
|
|
fs.rmSync(TEST_DATA_DIR, { recursive: true, force: true, maxRetries: 5, retryDelay: 100 });
|
|
fs.mkdirSync(TEST_DATA_DIR, { recursive: true });
|
|
}
|
|
|
|
function makeJsonRequest(method: string, body?: unknown): Request {
|
|
return new Request("http://localhost/api/settings/database", {
|
|
method,
|
|
headers: { "Content-Type": "application/json" },
|
|
body: body === undefined ? undefined : JSON.stringify(body),
|
|
});
|
|
}
|
|
|
|
function insertCallLog(id: string, artifactRelPath: string | null = null) {
|
|
const db = core.getDbInstance();
|
|
db.prepare(
|
|
`
|
|
INSERT INTO call_logs (id, timestamp, method, path, status, detail_state, artifact_relpath)
|
|
VALUES (?, ?, ?, ?, ?, ?, ?)
|
|
`
|
|
).run(
|
|
id,
|
|
"2026-06-01T12:00:00.000Z",
|
|
"POST",
|
|
"/v1/chat/completions",
|
|
200,
|
|
artifactRelPath ? "ready" : "none",
|
|
artifactRelPath
|
|
);
|
|
}
|
|
|
|
function writeCallLogArtifact(relativePath: string) {
|
|
const absolutePath = path.join(TEST_DATA_DIR, "call_logs", relativePath);
|
|
fs.mkdirSync(path.dirname(absolutePath), { recursive: true });
|
|
fs.writeFileSync(absolutePath, JSON.stringify({ relativePath }), "utf8");
|
|
return absolutePath;
|
|
}
|
|
|
|
test.beforeEach(() => {
|
|
resetStorage();
|
|
});
|
|
|
|
test.after(() => {
|
|
resetStorage();
|
|
});
|
|
|
|
test("database settings route returns mapped stats and persists editable sections", async () => {
|
|
const current = databaseSettings.getUserDatabaseSettings();
|
|
const response = await databaseSettingsRoute.PATCH(
|
|
makeJsonRequest("PATCH", {
|
|
retention: { ...current.retention, callLogs: 12, autoCleanupEnabled: false },
|
|
aggregation: { ...current.aggregation, enabled: false, rawDataRetentionDays: 8 },
|
|
}) as never
|
|
);
|
|
const body = await response.json();
|
|
|
|
assert.equal(response.status, 200);
|
|
assert.equal(body.retention.callLogs, 12);
|
|
assert.equal(body.aggregation.rawDataRetentionDays, 8);
|
|
assert.equal(typeof body.location.databasePath, "string");
|
|
assert.equal(typeof body.location.dataDir, "string");
|
|
assert.equal(typeof body.location.walSizeBytes, "number");
|
|
assert.equal(typeof body.stats.databaseSizeBytes, "number");
|
|
assert.equal(typeof body.stats.pageCount, "number");
|
|
assert.equal(typeof body.stats.freelistCount, "number");
|
|
|
|
const db = core.getDbInstance();
|
|
const stored = db
|
|
.prepare(
|
|
"SELECT value FROM key_value WHERE namespace = 'databaseSettings' AND key = 'retention.callLogs'"
|
|
)
|
|
.get() as { value: string } | undefined;
|
|
assert.equal(JSON.parse(stored?.value ?? "null"), 12);
|
|
|
|
const getResponse = await databaseSettingsRoute.GET(makeJsonRequest("GET") as never);
|
|
const getBody = await getResponse.json();
|
|
|
|
assert.equal(getResponse.status, 200);
|
|
assert.equal(getBody.retention.callLogs, 12);
|
|
assert.equal(getBody.aggregation.rawDataRetentionDays, 8);
|
|
});
|
|
|
|
test("database settings reader supports legacy flat keys and lets nested saves win", () => {
|
|
const db = core.getDbInstance();
|
|
db.prepare(
|
|
"INSERT OR REPLACE INTO key_value (namespace, key, value) VALUES ('databaseSettings', ?, ?)"
|
|
).run("callLogs", JSON.stringify(99));
|
|
|
|
assert.equal(databaseSettings.getUserDatabaseSettings().retention.callLogs, 99);
|
|
|
|
databaseSettings.updateDatabaseSettings({
|
|
retention: {
|
|
...databaseSettings.getUserDatabaseSettings().retention,
|
|
callLogs: 7,
|
|
},
|
|
});
|
|
|
|
assert.equal(databaseSettings.getUserDatabaseSettings().retention.callLogs, 7);
|
|
});
|
|
|
|
test("database log settings mirror the runtime pipeline toggle", async () => {
|
|
await settingsDb.updateSettings({ call_log_pipeline_enabled: false });
|
|
|
|
assert.equal(databaseSettings.getUserDatabaseSettings().logs.callLogPipelineEnabled, false);
|
|
|
|
databaseSettings.updateDatabaseSettings({
|
|
logs: {
|
|
...databaseSettings.getUserDatabaseSettings().logs,
|
|
callLogPipelineEnabled: true,
|
|
},
|
|
});
|
|
|
|
const settings = await settingsDb.getSettings();
|
|
assert.equal(settings.call_log_pipeline_enabled, true);
|
|
assert.equal(databaseSettings.getUserDatabaseSettings().logs.callLogPipelineEnabled, true);
|
|
});
|
|
|
|
test("database optimization settings apply SQLite cache size immediately", () => {
|
|
const current = databaseSettings.getUserDatabaseSettings();
|
|
|
|
databaseSettings.updateDatabaseSettings({
|
|
optimization: {
|
|
...current.optimization,
|
|
autoVacuumMode: core.getAutoVacuumMode(),
|
|
pageSize: 4096,
|
|
cacheSize: 16384,
|
|
},
|
|
});
|
|
|
|
const db = core.getDbInstance();
|
|
const stored = db
|
|
.prepare(
|
|
"SELECT value FROM key_value WHERE namespace = 'databaseSettings' AND key = 'optimization.cacheSize'"
|
|
)
|
|
.get() as { value: string } | undefined;
|
|
|
|
assert.equal(db.pragma("cache_size", { simple: true }), -16384);
|
|
assert.equal(JSON.parse(stored?.value ?? "null"), 16384);
|
|
assert.equal(databaseSettings.getUserDatabaseSettings().optimization.cacheSize, 16384);
|
|
});
|
|
|
|
test("database optimization settings apply SQLite page size immediately", () => {
|
|
const current = databaseSettings.getUserDatabaseSettings();
|
|
|
|
databaseSettings.updateDatabaseSettings({
|
|
optimization: {
|
|
...current.optimization,
|
|
autoVacuumMode: core.getAutoVacuumMode(),
|
|
pageSize: 8192,
|
|
cacheSize: 16384,
|
|
},
|
|
});
|
|
|
|
assert.equal(core.getDbInstance().pragma("page_size", { simple: true }), 8192);
|
|
assert.equal(databaseSettings.getUserDatabaseSettings().optimization.pageSize, 8192);
|
|
});
|
|
|
|
test("database optimization cache size is applied when the DB is reopened", () => {
|
|
const db = core.getDbInstance();
|
|
db.prepare(
|
|
"INSERT OR REPLACE INTO key_value (namespace, key, value) VALUES ('databaseSettings', ?, ?)"
|
|
).run("optimization.cacheSize", JSON.stringify(32768));
|
|
|
|
core.resetDbInstance();
|
|
const reopened = core.getDbInstance();
|
|
|
|
assert.equal(reopened.pragma("cache_size", { simple: true }), -32768);
|
|
});
|
|
|
|
test("database optimization rejects negative cache size through the API", async () => {
|
|
const current = databaseSettings.getUserDatabaseSettings();
|
|
const response = await databaseSettingsRoute.PATCH(
|
|
makeJsonRequest("PATCH", {
|
|
optimization: {
|
|
...current.optimization,
|
|
cacheSize: -2000,
|
|
},
|
|
}) as never
|
|
);
|
|
|
|
assert.equal(response.status, 400);
|
|
});
|
|
|
|
test("database settings reader normalizes legacy negative cache size to the positive default", () => {
|
|
const db = core.getDbInstance();
|
|
db.prepare(
|
|
"INSERT OR REPLACE INTO key_value (namespace, key, value) VALUES ('databaseSettings', ?, ?)"
|
|
).run("optimization.cacheSize", JSON.stringify(-2000));
|
|
|
|
assert.equal(databaseSettings.getUserDatabaseSettings().optimization.cacheSize, 65536);
|
|
});
|
|
|
|
test("purgeDetailedLogs deletes request_detail_logs", async () => {
|
|
const db = core.getDbInstance();
|
|
db.prepare("INSERT INTO request_detail_logs (id, timestamp, duration_ms) VALUES (?, ?, ?)").run(
|
|
"detail-1",
|
|
new Date().toISOString(),
|
|
10
|
|
);
|
|
db.prepare("INSERT INTO request_detail_logs (id, timestamp, duration_ms) VALUES (?, ?, ?)").run(
|
|
"detail-2",
|
|
new Date().toISOString(),
|
|
20
|
|
);
|
|
|
|
const result = await cleanup.purgeDetailedLogs();
|
|
|
|
assert.equal(result.errors, 0);
|
|
assert.equal(result.deleted, 2);
|
|
assert.equal(
|
|
(db.prepare("SELECT COUNT(*) AS count FROM request_detail_logs").get() as CountRow).count,
|
|
0
|
|
);
|
|
});
|
|
|
|
test("purgeCallLogs deletes summary rows and local request artifacts", async () => {
|
|
const db = core.getDbInstance();
|
|
const artifactPath = writeCallLogArtifact("2026-06-01/request-1.json");
|
|
const orphanPath = writeCallLogArtifact("2026-06-02/orphan.json");
|
|
insertCallLog("call-1", "2026-06-01/request-1.json");
|
|
|
|
const result = await cleanup.purgeCallLogs();
|
|
|
|
assert.equal(result.errors, 0);
|
|
assert.equal(result.deleted, 1);
|
|
assert.equal(result.deletedArtifacts, 2);
|
|
assert.equal((db.prepare("SELECT COUNT(*) AS count FROM call_logs").get() as CountRow).count, 0);
|
|
assert.equal(fs.existsSync(artifactPath), false);
|
|
assert.equal(fs.existsSync(orphanPath), false);
|
|
assert.equal(fs.existsSync(path.join(TEST_DATA_DIR, "call_logs")), false);
|
|
});
|
|
|
|
test("purge request history route clears call logs, artifacts, and legacy detail rows", async () => {
|
|
const db = core.getDbInstance();
|
|
const artifactPath = writeCallLogArtifact("2026-06-01/request-route.json");
|
|
insertCallLog("call-route", "2026-06-01/request-route.json");
|
|
db.prepare("INSERT INTO request_detail_logs (id, timestamp, duration_ms) VALUES (?, ?, ?)").run(
|
|
"detail-route",
|
|
"2026-06-01T12:00:01.000Z",
|
|
25
|
|
);
|
|
|
|
const response = await purgeRequestHistoryRoute.POST(
|
|
new Request("http://localhost/api/settings/purge-request-history", { method: "POST" })
|
|
);
|
|
const body = await response.json();
|
|
|
|
assert.equal(response.status, 200);
|
|
assert.equal(body.deleted, 1);
|
|
assert.equal(body.deletedArtifacts, 1);
|
|
assert.equal(body.deletedDetailedLogs, 1);
|
|
assert.equal(body.errors, 0);
|
|
assert.equal((db.prepare("SELECT COUNT(*) AS count FROM call_logs").get() as CountRow).count, 0);
|
|
assert.equal(
|
|
(db.prepare("SELECT COUNT(*) AS count FROM request_detail_logs").get() as CountRow).count,
|
|
0
|
|
);
|
|
assert.equal(fs.existsSync(artifactPath), false);
|
|
});
|
|
|
|
test("usage aggregation upserts replace recomputed totals instead of adding them twice", async () => {
|
|
const db = core.getDbInstance();
|
|
const insertSnapshot = db.prepare(
|
|
`INSERT INTO quota_snapshots
|
|
(provider, connection_id, window_key, remaining_percentage, is_exhausted, raw_data, created_at)
|
|
VALUES (?, ?, ?, ?, ?, ?, ?)`
|
|
);
|
|
|
|
insertSnapshot.run(
|
|
"openai",
|
|
"conn-1",
|
|
"daily",
|
|
90,
|
|
0,
|
|
JSON.stringify({ model: "gpt-test", input_tokens: 10, output_tokens: 4, cost: 0.25 }),
|
|
"2026-05-01 10:15:00"
|
|
);
|
|
insertSnapshot.run(
|
|
"openai",
|
|
"conn-1",
|
|
"daily",
|
|
80,
|
|
0,
|
|
JSON.stringify({ model: "gpt-test", input_tokens: 20, output_tokens: 6, cost: 0.5 }),
|
|
"2026-05-01 10:45:00"
|
|
);
|
|
|
|
await aggregateHistory.rollupDailyUsage("2026-05-01", "2026-05-01");
|
|
await aggregateHistory.rollupDailyUsage("2026-05-01", "2026-05-01");
|
|
await aggregateHistory.rollupHourlyQuota("2026-05-01 10:00:00", "2026-05-01 10:59:59");
|
|
await aggregateHistory.rollupHourlyQuota("2026-05-01 10:00:00", "2026-05-01 10:59:59");
|
|
|
|
const daily = db.prepare("SELECT * FROM daily_usage_summary").get() as UsageSummaryRow;
|
|
const hourly = db.prepare("SELECT * FROM hourly_usage_summary").get() as UsageSummaryRow;
|
|
|
|
assert.equal(daily.total_requests, 2);
|
|
assert.equal(daily.total_input_tokens, 30);
|
|
assert.equal(daily.total_output_tokens, 10);
|
|
assert.equal(daily.total_cost, 0.75);
|
|
assert.equal(hourly.total_requests, 2);
|
|
assert.equal(hourly.total_input_tokens, 30);
|
|
assert.equal(hourly.total_output_tokens, 10);
|
|
assert.equal(hourly.total_cost, 0.75);
|
|
});
|
|
|
|
test("cleanupUsageHistory rolls up and deletes old rows using the same day boundary", async () => {
|
|
const db = core.getDbInstance();
|
|
const oldTimestamp = "2024-01-01T12:00:00.000Z";
|
|
const recentTimestamp = new Date().toISOString();
|
|
|
|
databaseSettings.updateDatabaseSettings({
|
|
retention: {
|
|
...databaseSettings.getUserDatabaseSettings().retention,
|
|
usageHistory: 30,
|
|
},
|
|
});
|
|
|
|
const insertUsage = db.prepare(
|
|
`INSERT INTO usage_history (provider, model, timestamp, tokens_input, tokens_output, success, latency_ms)
|
|
VALUES (?, ?, ?, ?, ?, ?, ?)`
|
|
);
|
|
insertUsage.run("openai", "gpt-test", oldTimestamp, 100, 40, 1, 200);
|
|
insertUsage.run("openai", "gpt-test", recentTimestamp, 7, 3, 1, 100);
|
|
|
|
const result = await cleanup.cleanupUsageHistory();
|
|
|
|
assert.equal(result.errors, 0);
|
|
assert.equal(result.deleted, 1);
|
|
|
|
const remaining = db.prepare("SELECT COUNT(*) AS count FROM usage_history").get() as CountRow;
|
|
assert.equal(remaining.count, 1);
|
|
|
|
const daily = db.prepare("SELECT * FROM daily_usage_summary").get() as UsageSummaryRow;
|
|
assert.equal(daily.total_requests, 1);
|
|
assert.equal(daily.total_input_tokens, 100);
|
|
assert.equal(daily.total_output_tokens, 40);
|
|
});
|