mirror of
https://github.com/diegosouzapw/OmniRoute.git
synced 2026-09-19 05:12:16 +03:00
Two shards on release/v3.8.51 went red in one day with the same signature —
"ENOTEMPTY, Directory not empty: /tmp/omniroute-<test>-XXXXXX" — from
combo-same-provider-cascade (Unit Tests fast-path 4/4, on a PR that touches only
.github/) and auth-policy-embeddings-webfetch-7785 (the 20k-test TIA step). Both pass
alone and on re-run: the cleanup races something still writing into the directory
(SQLite WAL/-shm checkpoint, a worker, the backup) and under a loaded hosted runner
the window opens. 1154 test files do their own cleanup with
fs.rmSync(dir, { recursive: true, force: true }); 57 already asked for retries.
One-shot codemod (scripts/ad-hoc/codemod-rm-maxretries.mjs, kept for the record):
every rm / rmSync / rmdirSync option object with `recursive: true` and no
`maxRetries` gains `maxRetries: 5, retryDelay: 100` — Node itself then retries
ENOTEMPTY/EBUSY/EPERM for up to ~0.5 s before giving up. 2243 call sites in 1292
files under tests/, the shared tests/_setup/isolateDataDir.ts exit hook included.
Only the option object changes: no call site, assertion or import is touched.
Validation: prettier and ESLint (with the frozen suppressions) clean on all 1292
files; a random 20-file sample runs green (quota-redis-store hangs identically on
the untouched tree — it needs a Redis on localhost, an environment matter). The
four unit shards on this PR are the full run.
107 lines
3.9 KiB
TypeScript
107 lines
3.9 KiB
TypeScript
import assert from "node:assert/strict";
|
|
import { spawnSync } from "node:child_process";
|
|
import { mkdtempSync, readFileSync, rmSync, writeFileSync } from "node:fs";
|
|
import { tmpdir } from "node:os";
|
|
import path from "node:path";
|
|
import test from "node:test";
|
|
import { fileURLToPath } from "node:url";
|
|
|
|
const here = path.dirname(fileURLToPath(import.meta.url));
|
|
const validator = path.resolve(here, "../../scripts/docs/validate-svg.mjs");
|
|
|
|
test("SVG validator ignores Mermaid data-id attributes when checking duplicate IDs", () => {
|
|
const fixtureDir = mkdtempSync(path.join(tmpdir(), "omniroute-svg-validator-"));
|
|
const fixture = path.join(fixtureDir, "mermaid.svg");
|
|
writeFileSync(
|
|
fixture,
|
|
'<svg xmlns="http://www.w3.org/2000/svg" viewBox="0 0 10 10" role="img" aria-label="Fixture">' +
|
|
"<desc>Fixture diagram.</desc>" +
|
|
'<path id="edge-a" data-id="edge-a" d="M0 0L10 10"/>' +
|
|
'<g data-id="edge-a"><path d="M0 10L10 0"/></g>' +
|
|
"</svg>"
|
|
);
|
|
|
|
try {
|
|
const result = spawnSync(process.execPath, [validator, fixture], { encoding: "utf8" });
|
|
assert.equal(result.status, 0, `${result.stdout}${result.stderr}`);
|
|
assert.match(result.stdout, /PASS/);
|
|
assert.doesNotMatch(`${result.stdout}${result.stderr}`, /WARN/);
|
|
} finally {
|
|
rmSync(fixtureDir, { recursive: true, force: true, maxRetries: 5, retryDelay: 100 });
|
|
}
|
|
});
|
|
|
|
test("SVG validator rejects duplicate XML id attributes", () => {
|
|
const fixtureDir = mkdtempSync(path.join(tmpdir(), "omniroute-svg-validator-"));
|
|
const fixture = path.join(fixtureDir, "duplicate.svg");
|
|
writeFileSync(
|
|
fixture,
|
|
'<svg xmlns="http://www.w3.org/2000/svg" viewBox="0 0 10 10">' +
|
|
'<path id="edge-a" d="M0 0L10 10"/><path id="edge-a" d="M0 10L10 0"/>' +
|
|
"</svg>"
|
|
);
|
|
|
|
try {
|
|
const result = spawnSync(process.execPath, [validator, fixture], { encoding: "utf8" });
|
|
assert.equal(result.status, 1, `${result.stdout}${result.stderr}`);
|
|
assert.match(result.stderr, /duplicate IDs: edge-a/);
|
|
} finally {
|
|
rmSync(fixtureDir, { recursive: true, force: true, maxRetries: 5, retryDelay: 100 });
|
|
}
|
|
});
|
|
|
|
test("SVG validator adds explicit accessible naming when requested for a generated diagram", () => {
|
|
const fixtureDir = mkdtempSync(path.join(tmpdir(), "omniroute-svg-validator-"));
|
|
const fixture = path.join(fixtureDir, "auto-combo.svg");
|
|
writeFileSync(
|
|
fixture,
|
|
'<svg id="diagram" xmlns="http://www.w3.org/2000/svg" viewBox="0 0 10 10" ' +
|
|
'role="graphics-document document"><rect width="10" height="10"/></svg>'
|
|
);
|
|
|
|
try {
|
|
const result = spawnSync(
|
|
process.execPath,
|
|
[
|
|
validator,
|
|
"--fix-a11y",
|
|
"--title",
|
|
"Auto-Combo scoring",
|
|
"--description",
|
|
"How OmniRoute scores eligible routing targets with 15 factors.",
|
|
fixture,
|
|
],
|
|
{ encoding: "utf8" }
|
|
);
|
|
assert.equal(result.status, 0, `${result.stdout}${result.stderr}`);
|
|
|
|
const repeated = spawnSync(
|
|
process.execPath,
|
|
[
|
|
validator,
|
|
"--fix-a11y",
|
|
"--title",
|
|
"Auto-Combo scoring",
|
|
"--description",
|
|
"How OmniRoute scores eligible routing targets with 15 factors.",
|
|
fixture,
|
|
],
|
|
{ encoding: "utf8" }
|
|
);
|
|
assert.equal(repeated.status, 0, `${repeated.stdout}${repeated.stderr}`);
|
|
|
|
const updated = readFileSync(fixture, "utf8");
|
|
assert.match(updated, /role="img"/);
|
|
assert.match(updated, /aria-labelledby="auto-combo-title auto-combo-desc"/);
|
|
assert.match(updated, /<title id="auto-combo-title">Auto-Combo scoring<\/title>/);
|
|
assert.match(
|
|
updated,
|
|
/<desc id="auto-combo-desc">How OmniRoute scores eligible routing targets with 15 factors\.<\/desc>/
|
|
);
|
|
assert.equal([...updated.matchAll(/id="auto-combo-title"/g)].length, 1);
|
|
assert.equal([...updated.matchAll(/id="auto-combo-desc"/g)].length, 1);
|
|
} finally {
|
|
rmSync(fixtureDir, { recursive: true, force: true, maxRetries: 5, retryDelay: 100 });
|
|
}
|
|
});
|