mirror of
https://github.com/diegosouzapw/OmniRoute.git
synced 2026-09-14 02:42:24 +03:00
Two shards on release/v3.8.51 went red in one day with the same signature —
"ENOTEMPTY, Directory not empty: /tmp/omniroute-<test>-XXXXXX" — from
combo-same-provider-cascade (Unit Tests fast-path 4/4, on a PR that touches only
.github/) and auth-policy-embeddings-webfetch-7785 (the 20k-test TIA step). Both pass
alone and on re-run: the cleanup races something still writing into the directory
(SQLite WAL/-shm checkpoint, a worker, the backup) and under a loaded hosted runner
the window opens. 1154 test files do their own cleanup with
fs.rmSync(dir, { recursive: true, force: true }); 57 already asked for retries.
One-shot codemod (scripts/ad-hoc/codemod-rm-maxretries.mjs, kept for the record):
every rm / rmSync / rmdirSync option object with `recursive: true` and no
`maxRetries` gains `maxRetries: 5, retryDelay: 100` — Node itself then retries
ENOTEMPTY/EBUSY/EPERM for up to ~0.5 s before giving up. 2243 call sites in 1292
files under tests/, the shared tests/_setup/isolateDataDir.ts exit hook included.
Only the option object changes: no call site, assertion or import is touched.
Validation: prettier and ESLint (with the frozen suppressions) clean on all 1292
files; a random 20-file sample runs green (quota-redis-store hangs identically on
the untouched tree — it needs a Redis on localhost, an environment matter). The
four unit shards on this PR are the full run.
175 lines
5.1 KiB
TypeScript
175 lines
5.1 KiB
TypeScript
import test from "node:test";
|
|
import assert from "node:assert/strict";
|
|
import fs from "node:fs";
|
|
import os from "node:os";
|
|
import path from "node:path";
|
|
|
|
const TEST_DATA_DIR = fs.mkdtempSync(path.join(os.tmpdir(), "omniroute-memory-summarization-"));
|
|
process.env.DATA_DIR = TEST_DATA_DIR;
|
|
|
|
const core = await import("../../src/lib/db/core.ts");
|
|
const summarization = await import("../../src/lib/memory/summarization.ts");
|
|
|
|
async function resetStorage() {
|
|
core.resetDbInstance();
|
|
|
|
for (let attempt = 0; attempt < 10; attempt++) {
|
|
try {
|
|
if (fs.existsSync(TEST_DATA_DIR)) {
|
|
fs.rmSync(TEST_DATA_DIR, { recursive: true, force: true, maxRetries: 5, retryDelay: 100 });
|
|
}
|
|
break;
|
|
} catch (error: any) {
|
|
if ((error?.code === "EBUSY" || error?.code === "EPERM") && attempt < 9) {
|
|
await new Promise((resolve) => setTimeout(resolve, 50 * (attempt + 1)));
|
|
} else {
|
|
throw error;
|
|
}
|
|
}
|
|
}
|
|
|
|
fs.mkdirSync(TEST_DATA_DIR, { recursive: true });
|
|
}
|
|
|
|
function insertMemory({ id, apiKeyId = "key-a", sessionId = "session-a", content, createdAt }) {
|
|
const db = core.getDbInstance();
|
|
db.prepare(
|
|
`INSERT INTO memories (
|
|
id, api_key_id, session_id, type, key, content, metadata, created_at, updated_at, expires_at
|
|
) VALUES (?, ?, ?, ?, ?, ?, ?, ?, ?, ?)`
|
|
).run(
|
|
id,
|
|
apiKeyId,
|
|
sessionId,
|
|
"factual",
|
|
`memory:${id}`,
|
|
content,
|
|
"{}",
|
|
createdAt,
|
|
createdAt,
|
|
null
|
|
);
|
|
}
|
|
|
|
function getContent(id) {
|
|
const db = core.getDbInstance();
|
|
return (db.prepare("SELECT content FROM memories WHERE id = ?").get(id) as any).content ?? null;
|
|
}
|
|
|
|
test.beforeEach(async () => {
|
|
await resetStorage();
|
|
});
|
|
|
|
test.after(async () => {
|
|
core.resetDbInstance();
|
|
fs.rmSync(TEST_DATA_DIR, { recursive: true, force: true, maxRetries: 5, retryDelay: 100 });
|
|
});
|
|
|
|
test("summarizeMemories returns zeroed metrics for empty conversations", async () => {
|
|
const result = await summarization.summarizeMemories("missing-key", "missing-session");
|
|
assert.deepEqual(result, {
|
|
originalCount: 0,
|
|
summarizedCount: 0,
|
|
tokensSaved: 0,
|
|
});
|
|
});
|
|
|
|
test("summarizeMemories keeps the newest items inside the token budget and summarizes older ones", async () => {
|
|
insertMemory({
|
|
id: "old",
|
|
content: "Alpha. Beta. Gamma. Delta.",
|
|
createdAt: "2026-04-01T00:00:00.000Z",
|
|
});
|
|
insertMemory({
|
|
id: "new",
|
|
content: "One. Two. Three. Four.",
|
|
createdAt: "2026-04-02T00:00:00.000Z",
|
|
});
|
|
|
|
const result = await summarization.summarizeMemories("key-a", "session-a", 8);
|
|
|
|
assert.equal(result.originalCount, 2);
|
|
assert.equal(result.summarizedCount, 1);
|
|
assert.ok(result.tokensSaved > 0);
|
|
assert.equal(getContent("new"), "One. Two. Three. Four.");
|
|
assert.equal(getContent("old"), "Alpha. Beta. Gamma.");
|
|
});
|
|
|
|
test("summarizeMemories restricts the operation to the requested session", async () => {
|
|
insertMemory({
|
|
id: "target-1",
|
|
sessionId: "session-target",
|
|
content: "One. Two. Three. Four.",
|
|
createdAt: "2026-04-01T00:00:00.000Z",
|
|
});
|
|
insertMemory({
|
|
id: "target-2",
|
|
sessionId: "session-target",
|
|
content: "Five. Six. Seven. Eight.",
|
|
createdAt: "2026-04-02T00:00:00.000Z",
|
|
});
|
|
insertMemory({
|
|
id: "other-session",
|
|
sessionId: "session-other",
|
|
content: "Nine. Ten. Eleven. Twelve.",
|
|
createdAt: "2026-04-03T00:00:00.000Z",
|
|
});
|
|
|
|
const result = await summarization.summarizeMemories("key-a", "session-target", 8);
|
|
|
|
assert.equal(result.originalCount, 2);
|
|
assert.equal(result.summarizedCount, 1);
|
|
assert.equal(getContent("target-1"), "One. Two. Three.");
|
|
assert.equal(getContent("target-2"), "Five. Six. Seven. Eight.");
|
|
assert.equal(getContent("other-session"), "Nine. Ten. Eleven. Twelve.");
|
|
});
|
|
|
|
test("summarizeMemories can operate across every session of the same api key and ignores other keys", async () => {
|
|
insertMemory({
|
|
id: "a-older",
|
|
apiKeyId: "key-a",
|
|
sessionId: "session-a1",
|
|
content: "Red. Blue. Green. Yellow.",
|
|
createdAt: "2026-04-01T00:00:00.000Z",
|
|
});
|
|
insertMemory({
|
|
id: "a-newer",
|
|
apiKeyId: "key-a",
|
|
sessionId: "session-a2",
|
|
content: "Black. White. Gray. Silver.",
|
|
createdAt: "2026-04-02T00:00:00.000Z",
|
|
});
|
|
insertMemory({
|
|
id: "b-other",
|
|
apiKeyId: "key-b",
|
|
sessionId: "session-b1",
|
|
content: "North. South. East. West.",
|
|
createdAt: "2026-04-03T00:00:00.000Z",
|
|
});
|
|
|
|
const result = await summarization.summarizeMemories("key-a", undefined, 9);
|
|
|
|
assert.equal(result.originalCount, 2);
|
|
assert.equal(result.summarizedCount, 1);
|
|
assert.equal(getContent("a-older"), "Red. Blue. Green.");
|
|
assert.equal(getContent("a-newer"), "Black. White. Gray. Silver.");
|
|
assert.equal(getContent("b-other"), "North. South. East. West.");
|
|
});
|
|
|
|
test("summarizeMemories leaves short entries unchanged when the generated summary is identical", async () => {
|
|
insertMemory({
|
|
id: "short",
|
|
content: "One. Two. Three.",
|
|
createdAt: "2026-04-01T00:00:00.000Z",
|
|
});
|
|
|
|
const result = await summarization.summarizeMemories("key-a", "session-a", 0);
|
|
|
|
assert.deepEqual(result, {
|
|
originalCount: 1,
|
|
summarizedCount: 1,
|
|
tokensSaved: 0,
|
|
});
|
|
assert.equal(getContent("short"), "One. Two. Three.");
|
|
});
|