mirror of
https://github.com/diegosouzapw/OmniRoute.git
synced 2026-09-16 11:52:26 +03:00
Two shards on release/v3.8.51 went red in one day with the same signature —
"ENOTEMPTY, Directory not empty: /tmp/omniroute-<test>-XXXXXX" — from
combo-same-provider-cascade (Unit Tests fast-path 4/4, on a PR that touches only
.github/) and auth-policy-embeddings-webfetch-7785 (the 20k-test TIA step). Both pass
alone and on re-run: the cleanup races something still writing into the directory
(SQLite WAL/-shm checkpoint, a worker, the backup) and under a loaded hosted runner
the window opens. 1154 test files do their own cleanup with
fs.rmSync(dir, { recursive: true, force: true }); 57 already asked for retries.
One-shot codemod (scripts/ad-hoc/codemod-rm-maxretries.mjs, kept for the record):
every rm / rmSync / rmdirSync option object with `recursive: true` and no
`maxRetries` gains `maxRetries: 5, retryDelay: 100` — Node itself then retries
ENOTEMPTY/EBUSY/EPERM for up to ~0.5 s before giving up. 2243 call sites in 1292
files under tests/, the shared tests/_setup/isolateDataDir.ts exit hook included.
Only the option object changes: no call site, assertion or import is touched.
Validation: prettier and ESLint (with the frozen suppressions) clean on all 1292
files; a random 20-file sample runs green (quota-redis-store hangs identically on
the untouched tree — it needs a Redis on localhost, an environment matter). The
four unit shards on this PR are the full run.
162 lines
4.7 KiB
TypeScript
162 lines
4.7 KiB
TypeScript
import test from "node:test";
|
|
import assert from "node:assert/strict";
|
|
import fs from "node:fs";
|
|
import os from "node:os";
|
|
import path from "node:path";
|
|
import { SignJWT } from "jose";
|
|
|
|
const TEST_DATA_DIR = fs.mkdtempSync(path.join(os.tmpdir(), "omniroute-openapi-try-route-"));
|
|
const ORIGINAL_DATA_DIR = process.env.DATA_DIR;
|
|
const ORIGINAL_INITIAL_PASSWORD = process.env.INITIAL_PASSWORD;
|
|
const ORIGINAL_JWT_SECRET = process.env.JWT_SECRET;
|
|
|
|
process.env.DATA_DIR = TEST_DATA_DIR;
|
|
process.env.INITIAL_PASSWORD = "openapi-try-password";
|
|
process.env.JWT_SECRET = "openapi-try-jwt-secret";
|
|
|
|
const core = await import("../../src/lib/db/core.ts");
|
|
const route = await import("../../src/app/api/openapi/try/route.ts");
|
|
|
|
const originalFetch = globalThis.fetch;
|
|
|
|
async function resetStorage() {
|
|
core.resetDbInstance();
|
|
fs.rmSync(TEST_DATA_DIR, { recursive: true, force: true, maxRetries: 5, retryDelay: 100 });
|
|
fs.mkdirSync(TEST_DATA_DIR, { recursive: true });
|
|
}
|
|
|
|
async function createAuthCookie() {
|
|
const secret = new TextEncoder().encode(process.env.JWT_SECRET);
|
|
const token = await new SignJWT({ authenticated: true })
|
|
.setProtectedHeader({ alg: "HS256" })
|
|
.setExpirationTime("30d")
|
|
.sign(secret);
|
|
return `auth_token=${token}`;
|
|
}
|
|
|
|
function makeRequest(body: unknown, cookie?: string) {
|
|
return new Request("http://localhost/api/openapi/try", {
|
|
method: "POST",
|
|
headers: {
|
|
"content-type": "application/json",
|
|
...(cookie ? { cookie } : {}),
|
|
},
|
|
body: JSON.stringify(body),
|
|
});
|
|
}
|
|
|
|
test.beforeEach(async () => {
|
|
await resetStorage();
|
|
globalThis.fetch = originalFetch;
|
|
});
|
|
|
|
test.afterEach(() => {
|
|
globalThis.fetch = originalFetch;
|
|
});
|
|
|
|
test.after(() => {
|
|
globalThis.fetch = originalFetch;
|
|
core.resetDbInstance();
|
|
fs.rmSync(TEST_DATA_DIR, { recursive: true, force: true, maxRetries: 5, retryDelay: 100 });
|
|
|
|
if (ORIGINAL_DATA_DIR === undefined) {
|
|
delete process.env.DATA_DIR;
|
|
} else {
|
|
process.env.DATA_DIR = ORIGINAL_DATA_DIR;
|
|
}
|
|
if (ORIGINAL_INITIAL_PASSWORD === undefined) {
|
|
delete process.env.INITIAL_PASSWORD;
|
|
} else {
|
|
process.env.INITIAL_PASSWORD = ORIGINAL_INITIAL_PASSWORD;
|
|
}
|
|
if (ORIGINAL_JWT_SECRET === undefined) {
|
|
delete process.env.JWT_SECRET;
|
|
} else {
|
|
process.env.JWT_SECRET = ORIGINAL_JWT_SECRET;
|
|
}
|
|
});
|
|
|
|
test("openapi try route requires management authentication before proxying", async () => {
|
|
let fetchCalled = false;
|
|
globalThis.fetch = async () => {
|
|
fetchCalled = true;
|
|
return new Response("unexpected");
|
|
};
|
|
|
|
const response = await route.POST(
|
|
makeRequest({
|
|
method: "GET",
|
|
path: "/api/monitoring/health",
|
|
}) as any
|
|
);
|
|
const body = (await response.json()) as any;
|
|
|
|
assert.equal(response.status, 401);
|
|
assert.equal(body.error.message, "Authentication required");
|
|
assert.equal(fetchCalled, false);
|
|
});
|
|
|
|
test("openapi try route rejects protocol-relative targets after authentication", async () => {
|
|
let fetchCalled = false;
|
|
globalThis.fetch = async () => {
|
|
fetchCalled = true;
|
|
return new Response("unexpected");
|
|
};
|
|
|
|
const response = await route.POST(
|
|
makeRequest(
|
|
{
|
|
method: "GET",
|
|
path: "//evil.example/api",
|
|
},
|
|
await createAuthCookie()
|
|
) as any
|
|
);
|
|
const body = (await response.json()) as any;
|
|
|
|
assert.equal(response.status, 400);
|
|
assert.equal(body.error.message, "Invalid request");
|
|
assert.equal(fetchCalled, false);
|
|
});
|
|
|
|
test("openapi try route strips hop-by-hop headers and proxies same-origin API paths", async () => {
|
|
const cookie = await createAuthCookie();
|
|
let fetchUrl = "";
|
|
let fetchInit: RequestInit | undefined;
|
|
globalThis.fetch = async (url, init) => {
|
|
fetchUrl = String(url);
|
|
fetchInit = init;
|
|
return new Response(JSON.stringify({ ok: true }), {
|
|
status: 200,
|
|
headers: { "content-type": "application/json" },
|
|
});
|
|
};
|
|
|
|
const response = await route.POST(
|
|
makeRequest(
|
|
{
|
|
method: "POST",
|
|
path: "/api/combos/test",
|
|
headers: {
|
|
Authorization: "Bearer test-key",
|
|
Host: "evil.example",
|
|
"X-Forwarded-Proto": "https",
|
|
},
|
|
body: { comboName: "smoke" },
|
|
},
|
|
cookie
|
|
) as any
|
|
);
|
|
const body = (await response.json()) as any;
|
|
const forwardedHeaders = fetchInit?.headers as Record<string, string>;
|
|
|
|
assert.equal(response.status, 200);
|
|
assert.equal(body.status, 200);
|
|
assert.equal(fetchUrl, "http://localhost/api/combos/test");
|
|
assert.equal(fetchInit?.method, "POST");
|
|
assert.equal(forwardedHeaders.Authorization, "Bearer test-key");
|
|
assert.equal(forwardedHeaders.Host, undefined);
|
|
assert.equal(forwardedHeaders["X-Forwarded-Proto"], undefined);
|
|
assert.equal(forwardedHeaders.Cookie, cookie);
|
|
});
|