mirror of
https://github.com/diegosouzapw/OmniRoute.git
synced 2026-09-16 03:42:21 +03:00
Two shards on release/v3.8.51 went red in one day with the same signature —
"ENOTEMPTY, Directory not empty: /tmp/omniroute-<test>-XXXXXX" — from
combo-same-provider-cascade (Unit Tests fast-path 4/4, on a PR that touches only
.github/) and auth-policy-embeddings-webfetch-7785 (the 20k-test TIA step). Both pass
alone and on re-run: the cleanup races something still writing into the directory
(SQLite WAL/-shm checkpoint, a worker, the backup) and under a loaded hosted runner
the window opens. 1154 test files do their own cleanup with
fs.rmSync(dir, { recursive: true, force: true }); 57 already asked for retries.
One-shot codemod (scripts/ad-hoc/codemod-rm-maxretries.mjs, kept for the record):
every rm / rmSync / rmdirSync option object with `recursive: true` and no
`maxRetries` gains `maxRetries: 5, retryDelay: 100` — Node itself then retries
ENOTEMPTY/EBUSY/EPERM for up to ~0.5 s before giving up. 2243 call sites in 1292
files under tests/, the shared tests/_setup/isolateDataDir.ts exit hook included.
Only the option object changes: no call site, assertion or import is touched.
Validation: prettier and ESLint (with the frozen suppressions) clean on all 1292
files; a random 20-file sample runs green (quota-redis-store hangs identically on
the untouched tree — it needs a Redis on localhost, an environment matter). The
four unit shards on this PR are the full run.
94 lines
3.7 KiB
TypeScript
94 lines
3.7 KiB
TypeScript
import test from "node:test";
|
|
import assert from "node:assert/strict";
|
|
import fs from "node:fs";
|
|
import os from "node:os";
|
|
import path from "node:path";
|
|
|
|
// ─── Regression test for #6325 ───────────────────────────────────────────
|
|
//
|
|
// In production, `instrumentation-node.ts` (background periodic sync) and
|
|
// `src/app/api/pricing/sync/route.ts` (dashboard status endpoint) each
|
|
// `await import("@/lib/pricingSync")` from SEPARATE Next.js standalone
|
|
// webpack entries, producing SEPARATE module instances with independent
|
|
// top-level (`lastSyncTime`, `lastSyncModelCount`, `syncTimer`) state.
|
|
//
|
|
// This test simulates that scenario by importing the module twice under
|
|
// distinct specifiers (cache-busted via a query string), so each import
|
|
// gets its own top-level module state while both share the same on-disk
|
|
// SQLite DB (as they do in production). It asserts that a status read from
|
|
// a FRESH module instance still reflects a sync performed by a DIFFERENT
|
|
// module instance — i.e. sync status must be derived from persisted state,
|
|
// not from in-memory module-level variables.
|
|
|
|
const TEST_DATA_DIR = fs.mkdtempSync(path.join(os.tmpdir(), "omniroute-pricing-sync-xinst-"));
|
|
process.env.DATA_DIR = TEST_DATA_DIR;
|
|
|
|
const core = await import("../../src/lib/db/core.ts");
|
|
|
|
const originalFetch = globalThis.fetch;
|
|
|
|
function buildLiteLLMFixture() {
|
|
return {
|
|
"openai/gpt-4o": {
|
|
input_cost_per_token: 0.0000025,
|
|
output_cost_per_token: 0.00001,
|
|
litellm_provider: "openai",
|
|
mode: "chat",
|
|
},
|
|
};
|
|
}
|
|
|
|
test.after(async () => {
|
|
globalThis.fetch = originalFetch;
|
|
core.resetDbInstance();
|
|
fs.rmSync(TEST_DATA_DIR, { recursive: true, force: true, maxRetries: 5, retryDelay: 100 });
|
|
});
|
|
|
|
test("manual sync history remains visible without advertising a disabled future sync", async () => {
|
|
delete process.env.PRICING_SYNC_ENABLED;
|
|
globalThis.fetch = async () =>
|
|
new Response(JSON.stringify(buildLiteLLMFixture()), {
|
|
status: 200,
|
|
headers: { "content-type": "application/json" },
|
|
});
|
|
|
|
// Instance A: simulates the background periodic-sync module instance.
|
|
const pricingSyncA = await import("../../src/lib/pricingSync.ts?instance=A");
|
|
const result = await pricingSyncA.syncPricingFromSources({
|
|
sources: ["litellm"],
|
|
dryRun: false,
|
|
});
|
|
assert.equal(result.success, true);
|
|
|
|
// Instance B: simulates the dashboard API-route module instance — a
|
|
// genuinely fresh module scope that never called syncPricingFromSources
|
|
// itself, and whose own `syncTimer`/`lastSyncTime` module vars are unset.
|
|
const pricingSyncB = await import("../../src/lib/pricingSync.ts?instance=B");
|
|
const status = pricingSyncB.getSyncStatus();
|
|
|
|
assert.equal(
|
|
status.lastSyncModelCount,
|
|
result.modelCount,
|
|
"should read model count from persisted state"
|
|
);
|
|
assert.ok(status.lastSyncModelCount > 0, "persisted model count should be non-zero");
|
|
assert.notEqual(status.lastSync, null, "should read lastSync from persisted state");
|
|
assert.equal(status.enabled, false);
|
|
assert.equal(
|
|
status.nextSync,
|
|
null,
|
|
"manual sync history must not advertise a future run when automatic sync is disabled"
|
|
);
|
|
|
|
process.env.PRICING_SYNC_ENABLED = "false";
|
|
const explicitlyDisabledStatus = pricingSyncB.getSyncStatus();
|
|
assert.equal(explicitlyDisabledStatus.enabled, false);
|
|
assert.equal(explicitlyDisabledStatus.nextSync, null);
|
|
|
|
process.env.PRICING_SYNC_ENABLED = "true";
|
|
const enabledStatus = pricingSyncB.getSyncStatus();
|
|
assert.equal(enabledStatus.enabled, true);
|
|
assert.notEqual(enabledStatus.nextSync, null);
|
|
delete process.env.PRICING_SYNC_ENABLED;
|
|
});
|