mirror of
https://github.com/diegosouzapw/OmniRoute.git
synced 2026-09-21 22:32:22 +03:00
37ecab3659
Two shards on release/v3.8.51 went red in one day with the same signature —
"ENOTEMPTY, Directory not empty: /tmp/omniroute-<test>-XXXXXX" — from
combo-same-provider-cascade (Unit Tests fast-path 4/4, on a PR that touches only
.github/) and auth-policy-embeddings-webfetch-7785 (the 20k-test TIA step). Both pass
alone and on re-run: the cleanup races something still writing into the directory
(SQLite WAL/-shm checkpoint, a worker, the backup) and under a loaded hosted runner
the window opens. 1154 test files do their own cleanup with
fs.rmSync(dir, { recursive: true, force: true }); 57 already asked for retries.
One-shot codemod (scripts/ad-hoc/codemod-rm-maxretries.mjs, kept for the record):
every rm / rmSync / rmdirSync option object with `recursive: true` and no
`maxRetries` gains `maxRetries: 5, retryDelay: 100` — Node itself then retries
ENOTEMPTY/EBUSY/EPERM for up to ~0.5 s before giving up. 2243 call sites in 1292
files under tests/, the shared tests/_setup/isolateDataDir.ts exit hook included.
Only the option object changes: no call site, assertion or import is touched.
Validation: prettier and ESLint (with the frozen suppressions) clean on all 1292
files; a random 20-file sample runs green (quota-redis-store hangs identically on
the untouched tree — it needs a Redis on localhost, an environment matter). The
four unit shards on this PR are the full run.
45 lines
1.6 KiB
TypeScript
45 lines
1.6 KiB
TypeScript
/**
|
|
* #9507 — client max_tokens must NEVER be rewritten upward by the
|
|
* reasoning-token buffer. Core contract from #1761: OmniRoute must not
|
|
* silently enlarge a Claude Max user's per-turn cost.
|
|
*
|
|
* On claude-opus-5 (registry maxOutputTokens = 128000), a client sending
|
|
* max_tokens: 64000 got rewritten to 96000 (Math.ceil(64000 * 1.5)) because
|
|
* 96000 < 128000 so the "fits in cap" guard did NOT rescue it.
|
|
*/
|
|
import test from "node:test";
|
|
import assert from "node:assert/strict";
|
|
import fs from "node:fs";
|
|
import os from "node:os";
|
|
import path from "node:path";
|
|
|
|
const TEST_DATA_DIR = fs.mkdtempSync(path.join(os.tmpdir(), "omniroute-9507-"));
|
|
process.env.DATA_DIR = TEST_DATA_DIR;
|
|
|
|
const core = await import("../../src/lib/db/core.ts");
|
|
const { resolveReasoningBufferedMaxTokens } =
|
|
await import("../../open-sse/services/reasoningTokenBuffer.ts");
|
|
|
|
test.after(() => {
|
|
core.resetDbInstance();
|
|
fs.rmSync(TEST_DATA_DIR, { recursive: true, force: true, maxRetries: 5, retryDelay: 100 });
|
|
});
|
|
|
|
test("#9507 reasoning buffer does NOT enlarge a Claude opus-5 client budget upward", () => {
|
|
const result = resolveReasoningBufferedMaxTokens("anthropic/claude-opus-5", 64000);
|
|
assert.equal(
|
|
result,
|
|
64000,
|
|
`client max_tokens=64000 must be forwarded verbatim, got ${result} (x1.5 upward rewrite)`
|
|
);
|
|
});
|
|
|
|
test("#9507 reasoning buffer does NOT enlarge a Claude sonnet-5 client budget upward", () => {
|
|
const client = 32000;
|
|
const result = resolveReasoningBufferedMaxTokens("anthropic/claude-sonnet-5", client);
|
|
assert.ok(
|
|
result === null || result <= client,
|
|
`client max_tokens=${client} must not be enlarged, got ${result}`
|
|
);
|
|
});
|