mirror of
https://github.com/diegosouzapw/OmniRoute.git
synced 2026-09-13 18:32:12 +03:00
3d4f3e4960
* test(infra): retry recursive temp-dir removal instead of failing a shard on ENOTEMPTY (#11966) Two shards on release/v3.8.51 went red in one day with the same signature — "ENOTEMPTY, Directory not empty: /tmp/omniroute-<test>-XXXXXX" — from combo-same-provider-cascade (Unit Tests fast-path 4/4, on a PR that touches only .github/) and auth-policy-embeddings-webfetch-7785 (the 20k-test TIA step). Both pass alone and on re-run: the cleanup races something still writing into the directory (SQLite WAL/-shm checkpoint, a worker, the backup) and under a loaded hosted runner the window opens. 1154 test files do their own cleanup with fs.rmSync(dir, { recursive: true, force: true }); 57 already asked for retries. One-shot codemod (scripts/ad-hoc/codemod-rm-maxretries.mjs, kept for the record): every rm / rmSync / rmdirSync option object with `recursive: true` and no `maxRetries` gains `maxRetries: 5, retryDelay: 100` — Node itself then retries ENOTEMPTY/EBUSY/EPERM for up to ~0.5 s before giving up. 2243 call sites in 1292 files under tests/, the shared tests/_setup/isolateDataDir.ts exit hook included. Only the option object changes: no call site, assertion or import is touched. Validation: prettier and ESLint (with the frozen suppressions) clean on all 1292 files; a random 20-file sample runs green (quota-redis-store hangs identically on the untouched tree — it needs a Redis on localhost, an environment matter). The four unit shards on this PR are the full run. * fix(quality): let check-forgotten-sibling-tests read a 1,000-file diff The gate shells out to `git diff` through execFileSync with Node's default 1 MB maxBuffer; the 1,292-file codemod in this PR is the first diff large enough to overflow it, and the gate died with `spawnSync git ENOBUFS` before comparing anything. 64 MB is far above any real PR and costs nothing when unused.
82 lines
2.8 KiB
TypeScript
82 lines
2.8 KiB
TypeScript
/**
|
|
* Shared settings test fixture.
|
|
*
|
|
* Backs onto a real isolated SQLite DB + the production
|
|
* `updateSettings → applyRuntimeSettings` pipeline so callers exercise the
|
|
* actual hot-reload path. Tests that need to mock `getAuthzBypassSnapshot`
|
|
* directly defeat the integration value of AC-7 — use this helper instead.
|
|
*
|
|
* Usage:
|
|
* ```ts
|
|
* import { setupSettingsFixture, mockSettings, resetSettingsMock } from "../_mocks/settings";
|
|
* const fixture = setupSettingsFixture("authz-bypass");
|
|
* test.beforeEach(() => fixture.resetStorage());
|
|
* await mockSettings({ localOnlyManageScopeBypassEnabled: false });
|
|
* ```
|
|
*/
|
|
import fs from "node:fs";
|
|
import os from "node:os";
|
|
import path from "node:path";
|
|
|
|
type SettingsPatch = Record<string, unknown>;
|
|
|
|
let activeFixture: SettingsFixture | null = null;
|
|
|
|
export interface SettingsFixture {
|
|
testDataDir: string;
|
|
resetStorage(): Promise<void>;
|
|
cleanup(): void;
|
|
}
|
|
|
|
/**
|
|
* Allocate an isolated DATA_DIR + reset DB state per test. Must run BEFORE
|
|
* any DB modules are imported by the test file.
|
|
*/
|
|
export function setupSettingsFixture(slug: string): SettingsFixture {
|
|
const testDataDir = fs.mkdtempSync(path.join(os.tmpdir(), `omr-settings-mock-${slug}-`));
|
|
process.env.DATA_DIR = testDataDir;
|
|
if (!process.env.API_KEY_SECRET) {
|
|
process.env.API_KEY_SECRET = `test-settings-mock-secret-${Date.now()}`;
|
|
}
|
|
|
|
const fixture: SettingsFixture = {
|
|
testDataDir,
|
|
async resetStorage() {
|
|
const core = await import("../../../src/lib/db/core.ts");
|
|
const runtime = await import("../../../src/lib/config/runtimeSettings.ts");
|
|
core.resetDbInstance();
|
|
runtime.resetRuntimeSettingsStateForTests();
|
|
fs.rmSync(testDataDir, { recursive: true, force: true, maxRetries: 5, retryDelay: 100 });
|
|
fs.mkdirSync(testDataDir, { recursive: true });
|
|
},
|
|
cleanup() {
|
|
fs.rmSync(testDataDir, { recursive: true, force: true, maxRetries: 5, retryDelay: 100 });
|
|
},
|
|
};
|
|
activeFixture = fixture;
|
|
return fixture;
|
|
}
|
|
|
|
/**
|
|
* Write a partial Settings patch through the production
|
|
* `updateSettings → applyRuntimeSettings` pipeline. Hot-reload side effects
|
|
* (route guard snapshot, etc.) fire exactly as they do in `PATCH /api/settings`.
|
|
*/
|
|
export async function mockSettings(partial: SettingsPatch): Promise<Record<string, unknown>> {
|
|
const settingsDb = await import("../../../src/lib/db/settings.ts");
|
|
return settingsDb.updateSettings(partial);
|
|
}
|
|
|
|
/**
|
|
* Reset the in-process runtime snapshot to the cold-boot default. Called by
|
|
* test `beforeEach` hooks that need a clean slate without nuking the whole
|
|
* fixture directory.
|
|
*/
|
|
export async function resetSettingsMock(): Promise<void> {
|
|
const runtime = await import("../../../src/lib/config/runtimeSettings.ts");
|
|
runtime.resetRuntimeSettingsStateForTests();
|
|
if (activeFixture) {
|
|
await activeFixture.resetStorage();
|
|
}
|
|
}
|