mirror of
https://github.com/diegosouzapw/OmniRoute.git
synced 2026-09-13 18:32:12 +03:00
3d4f3e4960
* test(infra): retry recursive temp-dir removal instead of failing a shard on ENOTEMPTY (#11966) Two shards on release/v3.8.51 went red in one day with the same signature — "ENOTEMPTY, Directory not empty: /tmp/omniroute-<test>-XXXXXX" — from combo-same-provider-cascade (Unit Tests fast-path 4/4, on a PR that touches only .github/) and auth-policy-embeddings-webfetch-7785 (the 20k-test TIA step). Both pass alone and on re-run: the cleanup races something still writing into the directory (SQLite WAL/-shm checkpoint, a worker, the backup) and under a loaded hosted runner the window opens. 1154 test files do their own cleanup with fs.rmSync(dir, { recursive: true, force: true }); 57 already asked for retries. One-shot codemod (scripts/ad-hoc/codemod-rm-maxretries.mjs, kept for the record): every rm / rmSync / rmdirSync option object with `recursive: true` and no `maxRetries` gains `maxRetries: 5, retryDelay: 100` — Node itself then retries ENOTEMPTY/EBUSY/EPERM for up to ~0.5 s before giving up. 2243 call sites in 1292 files under tests/, the shared tests/_setup/isolateDataDir.ts exit hook included. Only the option object changes: no call site, assertion or import is touched. Validation: prettier and ESLint (with the frozen suppressions) clean on all 1292 files; a random 20-file sample runs green (quota-redis-store hangs identically on the untouched tree — it needs a Redis on localhost, an environment matter). The four unit shards on this PR are the full run. * fix(quality): let check-forgotten-sibling-tests read a 1,000-file diff The gate shells out to `git diff` through execFileSync with Node's default 1 MB maxBuffer; the 1,292-file codemod in this PR is the first diff large enough to overflow it, and the gate died with `spawnSync git ENOBUFS` before comparing anything. 64 MB is far above any real PR and costs nothing when unused.
70 lines
2.6 KiB
TypeScript
70 lines
2.6 KiB
TypeScript
/**
|
|
* GHSA-v54m-6rm3-p565 — /a2a sits outside the authz proxy matcher, so it never
|
|
* saw the REQUIRE_API_KEY posture and accepted every caller when OMNIROUTE_API_KEY
|
|
* was unset (the default). authenticate() now honors REQUIRE_API_KEY directly.
|
|
*/
|
|
|
|
import test from "node:test";
|
|
import assert from "node:assert/strict";
|
|
import fs from "node:fs";
|
|
import os from "node:os";
|
|
import path from "node:path";
|
|
|
|
const TEST_DATA_DIR = fs.mkdtempSync(path.join(os.tmpdir(), "omni-a2a-require-key-"));
|
|
process.env.DATA_DIR = TEST_DATA_DIR;
|
|
process.env.API_KEY_SECRET = process.env.API_KEY_SECRET || "a2a-require-key-secret";
|
|
process.env.OMNIROUTE_DISABLE_REDIS_AUTH_CACHE = "1";
|
|
|
|
const core = await import("../../src/lib/db/core.ts");
|
|
const apiKeysDb = await import("../../src/lib/db/apiKeys.ts");
|
|
const route = await import("../../src/app/a2a/route.ts");
|
|
|
|
const ORIGINAL_REQUIRE = process.env.REQUIRE_API_KEY;
|
|
const ORIGINAL_A2A_KEY = process.env.OMNIROUTE_API_KEY;
|
|
|
|
test.after(() => {
|
|
core.resetDbInstance();
|
|
fs.rmSync(TEST_DATA_DIR, { recursive: true, force: true, maxRetries: 5, retryDelay: 100 });
|
|
if (ORIGINAL_REQUIRE === undefined) delete process.env.REQUIRE_API_KEY;
|
|
else process.env.REQUIRE_API_KEY = ORIGINAL_REQUIRE;
|
|
if (ORIGINAL_A2A_KEY === undefined) delete process.env.OMNIROUTE_API_KEY;
|
|
else process.env.OMNIROUTE_API_KEY = ORIGINAL_A2A_KEY;
|
|
});
|
|
|
|
function post(key?: string) {
|
|
return route.POST(
|
|
new Request("http://localhost/a2a", {
|
|
method: "POST",
|
|
headers: {
|
|
"content-type": "application/json",
|
|
...(key ? { authorization: `Bearer ${key}` } : {}),
|
|
},
|
|
body: JSON.stringify({ jsonrpc: "2.0", id: 1, method: "message/send", params: {} }),
|
|
}) as never
|
|
);
|
|
}
|
|
|
|
async function isUnauthorized(res: Response) {
|
|
const body = (await res.clone().json()) as { error?: { code?: number } };
|
|
return body.error?.code === -32600;
|
|
}
|
|
|
|
test("REQUIRE_API_KEY=true rejects an unkeyed /a2a call (GHSA-v54m)", async () => {
|
|
delete process.env.OMNIROUTE_API_KEY;
|
|
process.env.REQUIRE_API_KEY = "true";
|
|
assert.equal(await isUnauthorized(await post()), true, "no key must be rejected");
|
|
|
|
const key = await apiKeysDb.createApiKey("a2a-client", "machine-a2a", []);
|
|
assert.equal(
|
|
await isUnauthorized(await post(key.key)),
|
|
false,
|
|
"a valid key must clear the /a2a auth gate"
|
|
);
|
|
});
|
|
|
|
test("keyless local-first default still allows /a2a (posture preserved)", async () => {
|
|
delete process.env.REQUIRE_API_KEY;
|
|
delete process.env.OMNIROUTE_API_KEY;
|
|
assert.equal(await isUnauthorized(await post()), false, "keyless default must not 401");
|
|
});
|