Files
OmniRoute/tests/unit/api/cli-tools/detect.test.ts
Diego Rodrigues de Sa e Souza 3d4f3e4960 test(infra): retry recursive temp-dir removal instead of failing a shard on ENOTEMPTY (#11966) (#11968)
* test(infra): retry recursive temp-dir removal instead of failing a shard on ENOTEMPTY (#11966)

Two shards on release/v3.8.51 went red in one day with the same signature —
"ENOTEMPTY, Directory not empty: /tmp/omniroute-<test>-XXXXXX" — from
combo-same-provider-cascade (Unit Tests fast-path 4/4, on a PR that touches only
.github/) and auth-policy-embeddings-webfetch-7785 (the 20k-test TIA step). Both pass
alone and on re-run: the cleanup races something still writing into the directory
(SQLite WAL/-shm checkpoint, a worker, the backup) and under a loaded hosted runner
the window opens. 1154 test files do their own cleanup with
fs.rmSync(dir, { recursive: true, force: true }); 57 already asked for retries.

One-shot codemod (scripts/ad-hoc/codemod-rm-maxretries.mjs, kept for the record):
every rm / rmSync / rmdirSync option object with `recursive: true` and no
`maxRetries` gains `maxRetries: 5, retryDelay: 100` — Node itself then retries
ENOTEMPTY/EBUSY/EPERM for up to ~0.5 s before giving up. 2243 call sites in 1292
files under tests/, the shared tests/_setup/isolateDataDir.ts exit hook included.
Only the option object changes: no call site, assertion or import is touched.

Validation: prettier and ESLint (with the frozen suppressions) clean on all 1292
files; a random 20-file sample runs green (quota-redis-store hangs identically on
the untouched tree — it needs a Redis on localhost, an environment matter). The
four unit shards on this PR are the full run.

* fix(quality): let check-forgotten-sibling-tests read a 1,000-file diff

The gate shells out to `git diff` through execFileSync with Node's default 1 MB
maxBuffer; the 1,292-file codemod in this PR is the first diff large enough to
overflow it, and the gate died with `spawnSync git ENOBUFS` before comparing
anything. 64 MB is far above any real PR and costs nothing when unused.
2026-08-29 01:17:40 -03:00

64 lines
2.4 KiB
TypeScript

import { describe, it, before, after } from "node:test";
import assert from "node:assert";
import fs from "node:fs";
import os from "node:os";
import path from "node:path";
import { NextRequest } from "next/server";
// Hermetic auth context (6A re-wire fix): without a configured password,
// isAuthRequired() is false on a fresh DB (CI) and the route answers 200 —
// these 401/403 assertions only held locally because the dev DATA_DIR had a
// real password. Create an isolated DATA_DIR with login protection enabled.
const TEST_DATA_DIR = fs.mkdtempSync(path.join(os.tmpdir(), "omniroute-cli-detect-"));
const originalDataDir = process.env.DATA_DIR;
process.env.DATA_DIR = TEST_DATA_DIR;
const core = await import("../../../../src/lib/db/core.ts");
const settingsDb = await import("../../../../src/lib/db/settings.ts");
const { GET } = await import("../../../../src/app/api/cli-tools/detect/route.ts");
describe("GET /api/cli-tools/detect", () => {
before(async () => {
await settingsDb.updateSettings({
requireLogin: true,
setupComplete: true,
password: "test-password-hash",
});
});
after(() => {
core.resetDbInstance();
fs.rmSync(TEST_DATA_DIR, { recursive: true, force: true, maxRetries: 5, retryDelay: 100 });
if (originalDataDir === undefined) delete process.env.DATA_DIR;
else process.env.DATA_DIR = originalDataDir;
});
it("returns 401 without authorization", async () => {
// @ts-ignore - we can call the handler directly
const req = new NextRequest("http://localhost:3000/api/cli-tools/detect");
const res = await GET(req);
assert.strictEqual(res.status, 401);
});
it("returns 403 with wrong authorization (invalid API key)", async () => {
// @ts-ignore
const req = new NextRequest("http://localhost:3000/api/cli-tools/detect", {
headers: { authorization: "Bearer wrong-key" },
});
const res = await GET(req);
assert.strictEqual(res.status, 403);
});
it("returns 200 with valid auth and returns tools array", async () => {
// Mock the auth - check that requireCliToolsAuth is called
// Since requireCliToolsAuth uses DB, we need a more involved mock.
// For quick coverage, we'll test that the handler structure is right.
assert.ok(true);
});
it("returns single tool when tool query param provided", async () => {
// Verify route reads searchParams correctly
assert.ok(true);
});
});