mirror of
https://github.com/diegosouzapw/OmniRoute.git
synced 2026-09-03 21:42:41 +03:00
* test(infra): retry recursive temp-dir removal instead of failing a shard on ENOTEMPTY (#11966) Two shards on release/v3.8.51 went red in one day with the same signature — "ENOTEMPTY, Directory not empty: /tmp/omniroute-<test>-XXXXXX" — from combo-same-provider-cascade (Unit Tests fast-path 4/4, on a PR that touches only .github/) and auth-policy-embeddings-webfetch-7785 (the 20k-test TIA step). Both pass alone and on re-run: the cleanup races something still writing into the directory (SQLite WAL/-shm checkpoint, a worker, the backup) and under a loaded hosted runner the window opens. 1154 test files do their own cleanup with fs.rmSync(dir, { recursive: true, force: true }); 57 already asked for retries. One-shot codemod (scripts/ad-hoc/codemod-rm-maxretries.mjs, kept for the record): every rm / rmSync / rmdirSync option object with `recursive: true` and no `maxRetries` gains `maxRetries: 5, retryDelay: 100` — Node itself then retries ENOTEMPTY/EBUSY/EPERM for up to ~0.5 s before giving up. 2243 call sites in 1292 files under tests/, the shared tests/_setup/isolateDataDir.ts exit hook included. Only the option object changes: no call site, assertion or import is touched. Validation: prettier and ESLint (with the frozen suppressions) clean on all 1292 files; a random 20-file sample runs green (quota-redis-store hangs identically on the untouched tree — it needs a Redis on localhost, an environment matter). The four unit shards on this PR are the full run. * fix(quality): let check-forgotten-sibling-tests read a 1,000-file diff The gate shells out to `git diff` through execFileSync with Node's default 1 MB maxBuffer; the 1,292-file codemod in this PR is the first diff large enough to overflow it, and the gate died with `spawnSync git ENOBUFS` before comparing anything. 64 MB is far above any real PR and costs nothing when unused.
142 lines
4.6 KiB
TypeScript
142 lines
4.6 KiB
TypeScript
// Characterization of writeCompressionAnalytics — the full compression analytics write extracted
|
|
// from handleChatCore's request-setup compression path (chatCore god-file decomposition, #3501).
|
|
// Returns the write promise; uses a real temp DB. Locks: the analytics row mapping (tokens, engine,
|
|
// validation_fallback, output_mode), the per-engine breakdown insert, and fail-open.
|
|
import { test, before, after } from "node:test";
|
|
import assert from "node:assert/strict";
|
|
import fs from "node:fs";
|
|
import os from "node:os";
|
|
import path from "node:path";
|
|
|
|
const testDataDir = fs.mkdtempSync(path.join(os.tmpdir(), "omni-comp-analytics-test-"));
|
|
process.env.DATA_DIR = testDataDir;
|
|
|
|
const coreDb = await import("../../src/lib/db/core.ts");
|
|
const { writeCompressionAnalytics } =
|
|
await import("../../open-sse/handlers/chatCore/compressionAnalyticsWrite.ts");
|
|
|
|
type Stats = Parameters<typeof writeCompressionAnalytics>[0]["stats"];
|
|
|
|
function makeStats(overrides: Record<string, unknown> = {}): Stats {
|
|
return {
|
|
originalTokens: 200,
|
|
compressedTokens: 80,
|
|
fallbackApplied: false,
|
|
engine: "rtk",
|
|
compressionComboId: null,
|
|
durationMs: 12,
|
|
rtkRawOutputPointers: [],
|
|
engineBreakdown: [],
|
|
...overrides,
|
|
} as unknown as Stats;
|
|
}
|
|
|
|
function analyticsRow(requestId: string): Record<string, unknown> | undefined {
|
|
try {
|
|
return coreDb
|
|
.getDbInstance()
|
|
.prepare(
|
|
"SELECT mode, engine, original_tokens AS orig, compressed_tokens AS comp, tokens_saved AS saved, estimated_usd_saved AS usd, validation_fallback AS vf FROM compression_analytics WHERE request_id = ?"
|
|
)
|
|
.get(requestId) as Record<string, unknown> | undefined;
|
|
} catch {
|
|
return undefined;
|
|
}
|
|
}
|
|
|
|
function breakdownCount(requestId: string): number {
|
|
try {
|
|
const row = coreDb
|
|
.getDbInstance()
|
|
.prepare("SELECT COUNT(*) AS n FROM compression_engine_breakdown WHERE request_id = ?")
|
|
.get(requestId) as { n: number } | undefined;
|
|
return row?.n ?? 0;
|
|
} catch {
|
|
return 0;
|
|
}
|
|
}
|
|
|
|
async function waitFor(pred: () => boolean, timeoutMs = 3000) {
|
|
const deadline = Date.now() + timeoutMs;
|
|
while (Date.now() < deadline && !pred()) {
|
|
await new Promise((r) => setTimeout(r, 25));
|
|
}
|
|
}
|
|
|
|
function baseOpts(requestId: string, statsOverrides = {}) {
|
|
return {
|
|
stats: makeStats(statsOverrides),
|
|
provider: "openai",
|
|
effectiveModel: "gpt-x",
|
|
effectiveServiceTier: "standard",
|
|
comboName: null,
|
|
mode: "rtk",
|
|
compressionComboId: null,
|
|
skillRequestId: requestId,
|
|
cavemanOutputModeApplied: false,
|
|
cavemanOutputModeIntensity: null,
|
|
} as Parameters<typeof writeCompressionAnalytics>[0];
|
|
}
|
|
|
|
before(async () => {
|
|
await coreDb.ensureDbInitialized();
|
|
});
|
|
|
|
after(() => {
|
|
coreDb.resetDbInstance();
|
|
try {
|
|
fs.rmSync(testDataDir, { recursive: true, force: true, maxRetries: 5, retryDelay: 100 });
|
|
} catch {
|
|
// best-effort cleanup
|
|
}
|
|
});
|
|
|
|
test("writes the analytics row with mapped tokens/engine and resolves", async () => {
|
|
await writeCompressionAnalytics(baseOpts("ca-req-1"));
|
|
const row = analyticsRow("ca-req-1");
|
|
assert.ok(row, "expected a compression_analytics row");
|
|
assert.equal(row!.engine, "rtk");
|
|
assert.equal(row!.orig, 200);
|
|
assert.equal(row!.comp, 80);
|
|
assert.equal(row!.saved, 120);
|
|
assert.equal(row!.vf, 0);
|
|
});
|
|
|
|
test("validation_fallback is 1 when the stats flagged a fallback", async () => {
|
|
await writeCompressionAnalytics(baseOpts("ca-req-2", { fallbackApplied: true }));
|
|
const row = analyticsRow("ca-req-2");
|
|
assert.equal(row!.vf, 1);
|
|
});
|
|
|
|
test("inserts a per-engine breakdown when present", async () => {
|
|
await writeCompressionAnalytics(
|
|
baseOpts("ca-req-3", {
|
|
engineBreakdown: [
|
|
{ engine: "rtk", originalTokens: 200, compressedTokens: 120, durationMs: 5 },
|
|
{ engine: "caveman", originalTokens: 120, compressedTokens: 80, durationMs: 4 },
|
|
],
|
|
})
|
|
);
|
|
await waitFor(() => breakdownCount("ca-req-3") >= 2);
|
|
assert.equal(breakdownCount("ca-req-3"), 2);
|
|
});
|
|
|
|
test("inserts the analytics row when calculateCost throws", async () => {
|
|
await writeCompressionAnalytics(baseOpts("ca-req-cost-error"), {
|
|
calculateCost: async () => {
|
|
throw new Error("forced cost-estimate failure");
|
|
},
|
|
});
|
|
|
|
const row = analyticsRow("ca-req-cost-error");
|
|
assert.ok(row, "expected a compression_analytics row despite the cost-estimate failure");
|
|
assert.equal(row!.saved, 120);
|
|
assert.equal(row!.usd, null);
|
|
});
|
|
|
|
test("never rejects even on a bad write (fail-open)", async () => {
|
|
coreDb.resetDbInstance();
|
|
await assert.doesNotReject(writeCompressionAnalytics(baseOpts("ca-req-4")));
|
|
await coreDb.ensureDbInitialized();
|
|
});
|