Files
OmniRoute/tests/unit/cli-providers-command.test.ts
Diego Rodrigues de Sa e Souza 3d4f3e4960 test(infra): retry recursive temp-dir removal instead of failing a shard on ENOTEMPTY (#11966) (#11968)
* test(infra): retry recursive temp-dir removal instead of failing a shard on ENOTEMPTY (#11966)

Two shards on release/v3.8.51 went red in one day with the same signature —
"ENOTEMPTY, Directory not empty: /tmp/omniroute-<test>-XXXXXX" — from
combo-same-provider-cascade (Unit Tests fast-path 4/4, on a PR that touches only
.github/) and auth-policy-embeddings-webfetch-7785 (the 20k-test TIA step). Both pass
alone and on re-run: the cleanup races something still writing into the directory
(SQLite WAL/-shm checkpoint, a worker, the backup) and under a loaded hosted runner
the window opens. 1154 test files do their own cleanup with
fs.rmSync(dir, { recursive: true, force: true }); 57 already asked for retries.

One-shot codemod (scripts/ad-hoc/codemod-rm-maxretries.mjs, kept for the record):
every rm / rmSync / rmdirSync option object with `recursive: true` and no
`maxRetries` gains `maxRetries: 5, retryDelay: 100` — Node itself then retries
ENOTEMPTY/EBUSY/EPERM for up to ~0.5 s before giving up. 2243 call sites in 1292
files under tests/, the shared tests/_setup/isolateDataDir.ts exit hook included.
Only the option object changes: no call site, assertion or import is touched.

Validation: prettier and ESLint (with the frozen suppressions) clean on all 1292
files; a random 20-file sample runs green (quota-redis-store hangs identically on
the untouched tree — it needs a Redis on localhost, an environment matter). The
four unit shards on this PR are the full run.

* fix(quality): let check-forgotten-sibling-tests read a 1,000-file diff

The gate shells out to `git diff` through execFileSync with Node's default 1 MB
maxBuffer; the 1,292-file codemod in this PR is the first diff large enough to
overflow it, and the gate died with `spawnSync git ENOBUFS` before comparing
anything. 64 MB is far above any real PR and costs nothing when unused.
2026-08-29 01:17:40 -03:00

158 lines
5.5 KiB
TypeScript

// ENVIRONMENT NOTE (sandbox better-sqlite3 / glibc limitation, not a code defect):
// This test constructs or exercises a real better-sqlite3-backed SQLite database.
// better-sqlite3 is a native addon; production and CI load it normally, but some
// sandboxes/dev boxes ship a system glibc older than the prebuilt binary requires
// ("GLIBC_2.29 not found"), so the native module fails to dlopen and any test that
// reaches better-sqlite3 directly (or asserts stdout that the load-failure warning
// would pollute) fails HERE while passing in CI. This is a known environment
// limitation, not a defect in the code under test: the OmniRoute runtime itself
// cascades to node:sqlite/sql.js when better-sqlite3 is unavailable. See
// tests/unit/_helpers/betterSqlite3Availability.ts for a guard helper.
import test from "node:test";
import assert from "node:assert/strict";
import fs from "node:fs";
import os from "node:os";
import path from "node:path";
import Database from "better-sqlite3";
const ORIGINAL_DATA_DIR = process.env.DATA_DIR;
const ORIGINAL_STORAGE_ENCRYPTION_KEY = process.env.STORAGE_ENCRYPTION_KEY;
const ORIGINAL_FETCH = globalThis.fetch;
function createTempDataDir() {
return fs.mkdtempSync(path.join(os.tmpdir(), "omniroute-cli-providers-"));
}
async function withProvidersEnv(fn: (dataDir: string) => Promise<void>) {
const dataDir = createTempDataDir();
process.env.DATA_DIR = dataDir;
delete process.env.STORAGE_ENCRYPTION_KEY;
globalThis.fetch = ORIGINAL_FETCH;
try {
await fn(dataDir);
} finally {
fs.rmSync(dataDir, { recursive: true, force: true, maxRetries: 5, retryDelay: 100 });
globalThis.fetch = ORIGINAL_FETCH;
if (ORIGINAL_DATA_DIR === undefined) delete process.env.DATA_DIR;
else process.env.DATA_DIR = ORIGINAL_DATA_DIR;
if (ORIGINAL_STORAGE_ENCRYPTION_KEY === undefined) delete process.env.STORAGE_ENCRYPTION_KEY;
else process.env.STORAGE_ENCRYPTION_KEY = ORIGINAL_STORAGE_ENCRYPTION_KEY;
}
}
async function createProvider(dataDir: string) {
const { ensureProviderSchema, upsertApiKeyProviderConnection } =
await import("../../bin/cli/provider-store.mjs");
const db = new Database(path.join(dataDir, "storage.sqlite"));
ensureProviderSchema(db);
const connection = upsertApiKeyProviderConnection(db, {
provider: "openai",
name: "OpenAI CLI",
apiKey: "sk-test",
});
db.close();
return connection;
}
test("providers list succeeds with configured providers", async () => {
await withProvidersEnv(async (dataDir) => {
await createProvider(dataDir);
const { runListCommand } = await import("../../bin/cli/commands/providers.mjs");
const exitCode = await runListCommand({ json: true });
assert.equal(exitCode, 0);
});
});
test("providers available lists supported provider catalog", async () => {
await withProvidersEnv(async () => {
const { runAvailableCommand } = await import("../../bin/cli/commands/providers.mjs");
const logs: string[] = [];
const originalLog = console.log;
console.log = (...args: unknown[]) => {
logs.push(args.join(" "));
};
try {
const exitCode = await runAvailableCommand({ json: true, search: "openai" });
assert.equal(exitCode, 0);
} finally {
console.log = originalLog;
}
const result = JSON.parse(logs.join("\n")) as {
providers: Array<{ id: string; category: string }>;
};
assert.ok(result.providers.some((provider) => provider.id === "openai"));
assert.ok(result.providers.some((provider) => provider.category === "api-key"));
});
});
test("providers test updates provider status from upstream result", async () => {
await withProvidersEnv(async (dataDir) => {
await createProvider(dataDir);
globalThis.fetch = (async () =>
new Response(JSON.stringify({ data: [] }), {
status: 200,
headers: { "Content-Type": "application/json" },
})) as typeof fetch;
const { runTestCommand } = await import("../../bin/cli/commands/providers.mjs");
const exitCode = await runTestCommand("OpenAI CLI", {});
assert.equal(exitCode, 0);
const db = new Database(path.join(dataDir, "storage.sqlite"));
const row = db.prepare("SELECT test_status, last_error FROM provider_connections").get() as {
test_status: string;
last_error: string | null;
};
db.close();
assert.equal(row.test_status, "active");
assert.equal(row.last_error, null);
});
});
test("providers validate fails encrypted API keys without storage key", async () => {
await withProvidersEnv(async (dataDir) => {
const db = new Database(path.join(dataDir, "storage.sqlite"));
db.prepare(
`CREATE TABLE provider_connections (
id TEXT PRIMARY KEY,
provider TEXT NOT NULL,
auth_type TEXT,
name TEXT,
api_key TEXT,
is_active INTEGER,
priority INTEGER,
created_at TEXT,
updated_at TEXT
)`
).run();
db.prepare(
`INSERT INTO provider_connections
(id, provider, auth_type, name, api_key, is_active, priority, created_at, updated_at)
VALUES (?, ?, ?, ?, ?, 1, 1, ?, ?)`
).run(
"conn-1",
"openai",
"apikey",
"Encrypted OpenAI",
"enc:v1:00112233445566778899aabbccddeeff:00:00112233445566778899aabbccddeeff",
new Date().toISOString(),
new Date().toISOString()
);
db.close();
const { runValidateCommand } = await import("../../bin/cli/commands/providers.mjs");
const exitCode = await runValidateCommand({ json: true });
assert.equal(exitCode, 1);
});
});