Files
OmniRoute/tests/unit/cliproxyapi-model-mapping-dispatch.test.ts
Diego Rodrigues de Sa e Souza 3d4f3e4960 test(infra): retry recursive temp-dir removal instead of failing a shard on ENOTEMPTY (#11966) (#11968)
* test(infra): retry recursive temp-dir removal instead of failing a shard on ENOTEMPTY (#11966)

Two shards on release/v3.8.51 went red in one day with the same signature —
"ENOTEMPTY, Directory not empty: /tmp/omniroute-<test>-XXXXXX" — from
combo-same-provider-cascade (Unit Tests fast-path 4/4, on a PR that touches only
.github/) and auth-policy-embeddings-webfetch-7785 (the 20k-test TIA step). Both pass
alone and on re-run: the cleanup races something still writing into the directory
(SQLite WAL/-shm checkpoint, a worker, the backup) and under a loaded hosted runner
the window opens. 1154 test files do their own cleanup with
fs.rmSync(dir, { recursive: true, force: true }); 57 already asked for retries.

One-shot codemod (scripts/ad-hoc/codemod-rm-maxretries.mjs, kept for the record):
every rm / rmSync / rmdirSync option object with `recursive: true` and no
`maxRetries` gains `maxRetries: 5, retryDelay: 100` — Node itself then retries
ENOTEMPTY/EBUSY/EPERM for up to ~0.5 s before giving up. 2243 call sites in 1292
files under tests/, the shared tests/_setup/isolateDataDir.ts exit hook included.
Only the option object changes: no call site, assertion or import is touched.

Validation: prettier and ESLint (with the frozen suppressions) clean on all 1292
files; a random 20-file sample runs green (quota-redis-store hangs identically on
the untouched tree — it needs a Redis on localhost, an environment matter). The
four unit shards on this PR are the full run.

* fix(quality): let check-forgotten-sibling-tests read a 1,000-file diff

The gate shells out to `git diff` through execFileSync with Node's default 1 MB
maxBuffer; the 1,292-file codemod in this PR is the first diff large enough to
overflow it, and the gate died with `spawnSync git ENOBUFS` before comparing
anything. 64 MB is far above any real PR and costs nothing when unused.
2026-08-29 01:17:40 -03:00

130 lines
4.3 KiB
TypeScript

/**
* Regression tests for #6876 — `cliproxyapiModelMapping` was persisted by the
* dashboard (`upstream_proxy_config.cliproxyapi_model_mapping`) but never
* consulted at request-dispatch time: the mapped model never made it onto the
* outbound CLIProxyAPI wire request.
*
* All tests exercise REAL production functions end-to-end:
* - upsertUpstreamProxyConfig (src/lib/db/upstreamProxy.ts)
* - resolveExecutorWithProxy (open-sse/handlers/chatCore/executorProxy.ts)
* - CliproxyapiExecutor.execute (open-sse/executors/cliproxyapi.ts)
* `globalThis.fetch` is stubbed only to capture the outbound wire body.
*/
import { describe, it, before, after, afterEach } from "node:test";
import assert from "node:assert/strict";
import fs from "node:fs";
import os from "node:os";
import path from "node:path";
const testDataDir = fs.mkdtempSync(path.join(os.tmpdir(), "omni-6876-model-mapping-"));
process.env.DATA_DIR = testDataDir;
const coreDb = await import("../../src/lib/db/core.ts");
const upstreamProxyDb = await import("../../src/lib/db/upstreamProxy.ts");
const { resolveExecutorWithProxy } =
await import("../../open-sse/handlers/chatCore/executorProxy.ts");
const { clearUpstreamProxyConfigCache } =
await import("../../open-sse/handlers/chatCore/comboContextCache.ts");
before(async () => {
await coreDb.ensureDbInitialized();
});
afterEach(() => {
clearUpstreamProxyConfigCache();
});
after(() => {
coreDb.resetDbInstance();
if (fs.existsSync(testDataDir))
fs.rmSync(testDataDir, { recursive: true, force: true, maxRetries: 5, retryDelay: 100 });
});
type ExecuteInput = {
model: string;
body: unknown;
stream: boolean;
credentials: unknown;
};
type ExecutorLike = { execute: (input: ExecuteInput) => Promise<unknown> };
async function captureFetchBody(fn: () => Promise<unknown>): Promise<Record<string, unknown>> {
let capturedBody: Record<string, unknown> | null = null;
const originalFetch = globalThis.fetch;
// @ts-expect-error test stub
globalThis.fetch = async (_url: string, init: RequestInit) => {
capturedBody = JSON.parse(init.body as string);
return new Response(JSON.stringify({ ok: true }), {
status: 200,
headers: { "Content-Type": "application/json" },
});
};
try {
await fn();
} finally {
globalThis.fetch = originalFetch;
}
assert.ok(capturedBody, "executor should have issued a fetch call");
return capturedBody as Record<string, unknown>;
}
describe("#6876 — cliproxyapiModelMapping applied at dispatch", () => {
it("forwards the MAPPED model to CLIProxyAPI in cliproxyapi (passthrough) mode", async () => {
await upstreamProxyDb.upsertUpstreamProxyConfig({
providerId: "anthropic-mapped-passthrough",
mode: "cliproxyapi",
enabled: true,
cliproxyapiModelMapping: { "claude-3-opus": "claude-3-opus-mapped" },
});
const executor = await resolveExecutorWithProxy(
"anthropic-mapped-passthrough",
undefined,
null
);
assert.equal(
(executor as { provider?: string }).provider,
"cliproxyapi",
"sanity: provider should route through the cliproxyapi executor"
);
const capturedBody = await captureFetchBody(() =>
(executor as ExecutorLike).execute({
model: "claude-3-opus",
body: { model: "claude-3-opus", messages: [{ role: "user", content: "hi" }] },
stream: false,
credentials: { apiKey: "test-key" },
})
);
assert.equal(
capturedBody.model,
"claude-3-opus-mapped",
`expected mapped model "claude-3-opus-mapped" to be forwarded upstream, got unmapped "${capturedBody.model}"`
);
});
it("does NOT remap the model when no mapping is configured (no regression)", async () => {
await upstreamProxyDb.upsertUpstreamProxyConfig({
providerId: "anthropic-no-mapping",
mode: "cliproxyapi",
enabled: true,
});
const executor = await resolveExecutorWithProxy("anthropic-no-mapping", undefined, null);
const capturedBody = await captureFetchBody(() =>
(executor as ExecutorLike).execute({
model: "claude-3-opus",
body: { model: "claude-3-opus", messages: [{ role: "user", content: "hi" }] },
stream: false,
credentials: { apiKey: "test-key" },
})
);
assert.equal(capturedBody.model, "claude-3-opus", "unmapped model must pass through unchanged");
});
});