Files
OmniRoute/tests/unit/codex-settings-wire-api-default.test.ts
Diego Rodrigues de Sa e Souza 3d4f3e4960 test(infra): retry recursive temp-dir removal instead of failing a shard on ENOTEMPTY (#11966) (#11968)
* test(infra): retry recursive temp-dir removal instead of failing a shard on ENOTEMPTY (#11966)

Two shards on release/v3.8.51 went red in one day with the same signature —
"ENOTEMPTY, Directory not empty: /tmp/omniroute-<test>-XXXXXX" — from
combo-same-provider-cascade (Unit Tests fast-path 4/4, on a PR that touches only
.github/) and auth-policy-embeddings-webfetch-7785 (the 20k-test TIA step). Both pass
alone and on re-run: the cleanup races something still writing into the directory
(SQLite WAL/-shm checkpoint, a worker, the backup) and under a loaded hosted runner
the window opens. 1154 test files do their own cleanup with
fs.rmSync(dir, { recursive: true, force: true }); 57 already asked for retries.

One-shot codemod (scripts/ad-hoc/codemod-rm-maxretries.mjs, kept for the record):
every rm / rmSync / rmdirSync option object with `recursive: true` and no
`maxRetries` gains `maxRetries: 5, retryDelay: 100` — Node itself then retries
ENOTEMPTY/EBUSY/EPERM for up to ~0.5 s before giving up. 2243 call sites in 1292
files under tests/, the shared tests/_setup/isolateDataDir.ts exit hook included.
Only the option object changes: no call site, assertion or import is touched.

Validation: prettier and ESLint (with the frozen suppressions) clean on all 1292
files; a random 20-file sample runs green (quota-redis-store hangs identically on
the untouched tree — it needs a Redis on localhost, an environment matter). The
four unit shards on this PR are the full run.

* fix(quality): let check-forgotten-sibling-tests read a 1,000-file diff

The gate shells out to `git diff` through execFileSync with Node's default 1 MB
maxBuffer; the 1,292-file codemod in this PR is the first diff large enough to
overflow it, and the gate died with `spawnSync git ENOBUFS` before comparing
anything. 64 MB is far above any real PR and costs nothing when unused.
2026-08-29 01:17:40 -03:00

91 lines
3.1 KiB
TypeScript

import test from "node:test";
import assert from "node:assert/strict";
import fs from "node:fs/promises";
import os from "node:os";
import path from "node:path";
import { SignJWT } from "jose";
const TEST_HOME = path.join(os.tmpdir(), `omniroute-codex-wire-api-${process.pid}-${Date.now()}`);
const CONFIG_PATH = path.join(TEST_HOME, ".codex", "config.toml");
const originalHome = os.homedir;
const originalJwtSecret = process.env.JWT_SECRET;
const originalWriteFlag = process.env.CLI_ALLOW_CONFIG_WRITES;
os.homedir = () => TEST_HOME;
process.env.CLI_ALLOW_CONFIG_WRITES = "true";
const route = await import("../../src/app/api/cli-tools/codex-settings/route.ts");
const authCookie = async (): Promise<string> => {
process.env.JWT_SECRET = "codex-wire-api-default-test-secret";
const token = await new SignJWT({ sub: "codex-wire-api-default-test" })
.setProtectedHeader({ alg: "HS256" })
.setIssuedAt()
.setExpirationTime("1h")
.sign(new TextEncoder().encode(process.env.JWT_SECRET));
return `auth_token=${token}`;
};
const post = async (body: Record<string, unknown>) =>
route.POST(
new Request("http://localhost/api/cli-tools/codex-settings", {
method: "POST",
headers: {
cookie: await authCookie(),
"Content-Type": "application/json",
},
body: JSON.stringify({
apiKey: "sk-test-only",
model: "gpt-5.6-sol",
...body,
}),
})
);
test.after(async () => {
os.homedir = originalHome;
await fs.rm(TEST_HOME, { recursive: true, force: true, maxRetries: 5, retryDelay: 100 });
if (originalJwtSecret === undefined) delete process.env.JWT_SECRET;
else process.env.JWT_SECRET = originalJwtSecret;
if (originalWriteFlag === undefined) delete process.env.CLI_ALLOW_CONFIG_WRITES;
else process.env.CLI_ALLOW_CONFIG_WRITES = originalWriteFlag;
});
test("POST resolves the Codex wire API before URL normalization and TOML generation", async (t) => {
const cases = [
{
name: "omitted wireApi defaults to responses",
body: { baseUrl: "http://localhost:20128/api/v1/responses" },
expectedBaseUrl: "http://localhost:20128/v1",
expectedWireApi: "responses",
},
{
name: "explicit responses remains responses",
body: {
baseUrl: "http://localhost:20128/api/v1/responses",
wireApi: "responses",
},
expectedBaseUrl: "http://localhost:20128/v1",
expectedWireApi: "responses",
},
{
name: "explicit chat remains chat",
body: { baseUrl: "http://localhost:20128/api/v1", wireApi: "chat" },
expectedBaseUrl: "http://localhost:20128/v1",
expectedWireApi: "chat",
},
] as const;
for (const testCase of cases) {
await t.test(testCase.name, async () => {
await fs.rm(TEST_HOME, { recursive: true, force: true, maxRetries: 5, retryDelay: 100 });
const response = await post(testCase.body);
assert.equal(response.status, 200);
const config = await fs.readFile(CONFIG_PATH, "utf8");
assert.match(config, new RegExp(`^base_url = "${testCase.expectedBaseUrl}"$`, "m"));
assert.match(config, new RegExp(`^wire_api = "${testCase.expectedWireApi}"$`, "m"));
});
}
});