mirror of
https://github.com/diegosouzapw/OmniRoute.git
synced 2026-09-03 13:22:12 +03:00
* test(infra): retry recursive temp-dir removal instead of failing a shard on ENOTEMPTY (#11966) Two shards on release/v3.8.51 went red in one day with the same signature — "ENOTEMPTY, Directory not empty: /tmp/omniroute-<test>-XXXXXX" — from combo-same-provider-cascade (Unit Tests fast-path 4/4, on a PR that touches only .github/) and auth-policy-embeddings-webfetch-7785 (the 20k-test TIA step). Both pass alone and on re-run: the cleanup races something still writing into the directory (SQLite WAL/-shm checkpoint, a worker, the backup) and under a loaded hosted runner the window opens. 1154 test files do their own cleanup with fs.rmSync(dir, { recursive: true, force: true }); 57 already asked for retries. One-shot codemod (scripts/ad-hoc/codemod-rm-maxretries.mjs, kept for the record): every rm / rmSync / rmdirSync option object with `recursive: true` and no `maxRetries` gains `maxRetries: 5, retryDelay: 100` — Node itself then retries ENOTEMPTY/EBUSY/EPERM for up to ~0.5 s before giving up. 2243 call sites in 1292 files under tests/, the shared tests/_setup/isolateDataDir.ts exit hook included. Only the option object changes: no call site, assertion or import is touched. Validation: prettier and ESLint (with the frozen suppressions) clean on all 1292 files; a random 20-file sample runs green (quota-redis-store hangs identically on the untouched tree — it needs a Redis on localhost, an environment matter). The four unit shards on this PR are the full run. * fix(quality): let check-forgotten-sibling-tests read a 1,000-file diff The gate shells out to `git diff` through execFileSync with Node's default 1 MB maxBuffer; the 1,292-file codemod in this PR is the first diff large enough to overflow it, and the gate died with `spawnSync git ENOBUFS` before comparing anything. 64 MB is far above any real PR and costs nothing when unused.
271 lines
9.8 KiB
TypeScript
271 lines
9.8 KiB
TypeScript
import test from "node:test";
|
|
import assert from "node:assert/strict";
|
|
import fs from "node:fs";
|
|
import os from "node:os";
|
|
import path from "node:path";
|
|
|
|
const {
|
|
CURSOR_AGENT_CLI_VERSION,
|
|
configureCursorAgentCliVersionForTests,
|
|
detectCursorAgentCliVersionFromFs,
|
|
extractVersionIdFromInstallerScript,
|
|
extractVersionIdFromResolvedPath,
|
|
formatCursorAgentClientVersion,
|
|
getCursorAgentCliVersion,
|
|
newestVersionInDir,
|
|
refreshCursorAgentCliVersionFromInstaller,
|
|
resetCursorAgentCliVersionCache,
|
|
resetCursorAgentCliVersionTestHooks,
|
|
} = await import("../../open-sse/utils/cursorAgentCliVersion.ts");
|
|
|
|
function withEnv(vars: Record<string, string | undefined>, fn: () => void) {
|
|
const saved: Record<string, string | undefined> = {};
|
|
for (const key of Object.keys(vars)) {
|
|
saved[key] = process.env[key];
|
|
const next = vars[key];
|
|
if (next === undefined) delete process.env[key];
|
|
else process.env[key] = next;
|
|
}
|
|
try {
|
|
fn();
|
|
} finally {
|
|
for (const key of Object.keys(saved)) {
|
|
if (saved[key] === undefined) delete process.env[key];
|
|
else process.env[key] = saved[key];
|
|
}
|
|
}
|
|
}
|
|
|
|
test("formatCursorAgentClientVersion prefixes cli-", () => {
|
|
assert.equal(formatCursorAgentClientVersion("2026.07.08-0c04a8a"), "cli-2026.07.08-0c04a8a");
|
|
});
|
|
|
|
test("extractVersionIdFromResolvedPath reads versions/<id>", () => {
|
|
assert.equal(
|
|
extractVersionIdFromResolvedPath(
|
|
"/home/u/.local/share/cursor-agent/versions/2026.07.08-0c04a8a/cursor-agent"
|
|
),
|
|
"2026.07.08-0c04a8a"
|
|
);
|
|
assert.equal(extractVersionIdFromResolvedPath("/tmp/not-an-agent"), null);
|
|
});
|
|
|
|
test("newestVersionInDir picks lexicographically newest matching child", () => {
|
|
const tmp = fs.mkdtempSync(path.join(os.tmpdir(), "cursor-cli-ver-dir-"));
|
|
try {
|
|
fs.mkdirSync(path.join(tmp, "2026.05.24-dda726e"));
|
|
fs.mkdirSync(path.join(tmp, "2026.07.08-0c04a8a"));
|
|
fs.writeFileSync(path.join(tmp, "not-a-version"), "x");
|
|
fs.mkdirSync(path.join(tmp, "3.9.0"));
|
|
assert.equal(newestVersionInDir(tmp), "2026.07.08-0c04a8a");
|
|
} finally {
|
|
fs.rmSync(tmp, { recursive: true, force: true, maxRetries: 5, retryDelay: 100 });
|
|
}
|
|
});
|
|
|
|
test("detectCursorAgentCliVersionFromFs uses shim realpath under versions/<id>", () => {
|
|
const home = fs.mkdtempSync(path.join(os.tmpdir(), "cursor-cli-home-shim-"));
|
|
try {
|
|
const id = "2026.06.01-abcdef0";
|
|
const versionDir = path.join(home, ".local", "share", "cursor-agent", "versions", id);
|
|
fs.mkdirSync(versionDir, { recursive: true });
|
|
const binary = path.join(versionDir, "cursor-agent");
|
|
fs.writeFileSync(binary, "#!/bin/sh\n");
|
|
const binDir = path.join(home, ".local", "bin");
|
|
fs.mkdirSync(binDir, { recursive: true });
|
|
fs.symlinkSync(binary, path.join(binDir, "agent"));
|
|
|
|
withEnv({ CURSOR_DATA_DIR: undefined, CURSOR_AGENT_CLI_VERSION: undefined }, () => {
|
|
assert.equal(detectCursorAgentCliVersionFromFs(home), id);
|
|
});
|
|
} finally {
|
|
fs.rmSync(home, { recursive: true, force: true, maxRetries: 5, retryDelay: 100 });
|
|
}
|
|
});
|
|
|
|
test("detectCursorAgentCliVersionFromFs uses CURSOR_DATA_DIR versions when no shim", () => {
|
|
const home = fs.mkdtempSync(path.join(os.tmpdir(), "cursor-cli-home-empty-"));
|
|
const data = fs.mkdtempSync(path.join(os.tmpdir(), "cursor-cli-data-"));
|
|
try {
|
|
const id = "2026.04.01-deadbeef";
|
|
fs.mkdirSync(path.join(data, "versions", id), { recursive: true });
|
|
withEnv({ CURSOR_DATA_DIR: data }, () => {
|
|
assert.equal(detectCursorAgentCliVersionFromFs(home), id);
|
|
});
|
|
} finally {
|
|
fs.rmSync(home, { recursive: true, force: true, maxRetries: 5, retryDelay: 100 });
|
|
fs.rmSync(data, { recursive: true, force: true, maxRetries: 5, retryDelay: 100 });
|
|
}
|
|
});
|
|
|
|
test("getCursorAgentCliVersion env override wins", () => {
|
|
withEnv({ CURSOR_AGENT_CLI_VERSION: "2026.01.02-abc1234" }, () => {
|
|
resetCursorAgentCliVersionCache();
|
|
assert.equal(getCursorAgentCliVersion(), "2026.01.02-abc1234");
|
|
});
|
|
resetCursorAgentCliVersionCache();
|
|
});
|
|
|
|
test("getCursorAgentCliVersion ignores invalid env and uses pin when FS empty", () => {
|
|
const home = fs.mkdtempSync(path.join(os.tmpdir(), "cursor-cli-home-pin-"));
|
|
try {
|
|
withEnv(
|
|
{
|
|
HOME: home,
|
|
USERPROFILE: home,
|
|
CURSOR_AGENT_CLI_VERSION: "3.9",
|
|
CURSOR_DATA_DIR: undefined,
|
|
},
|
|
() => {
|
|
resetCursorAgentCliVersionCache();
|
|
assert.equal(getCursorAgentCliVersion(), CURSOR_AGENT_CLI_VERSION);
|
|
}
|
|
);
|
|
} finally {
|
|
resetCursorAgentCliVersionCache();
|
|
fs.rmSync(home, { recursive: true, force: true, maxRetries: 5, retryDelay: 100 });
|
|
}
|
|
});
|
|
|
|
test("getCursorAgentCliVersion caches until reset", () => {
|
|
withEnv({ CURSOR_AGENT_CLI_VERSION: "2026.02.03-111aaaa" }, () => {
|
|
resetCursorAgentCliVersionCache();
|
|
assert.equal(getCursorAgentCliVersion(), "2026.02.03-111aaaa");
|
|
process.env.CURSOR_AGENT_CLI_VERSION = "2026.02.03-222bbbb";
|
|
assert.equal(getCursorAgentCliVersion(), "2026.02.03-111aaaa", "cached");
|
|
resetCursorAgentCliVersionCache();
|
|
assert.equal(getCursorAgentCliVersion(), "2026.02.03-222bbbb");
|
|
});
|
|
resetCursorAgentCliVersionCache();
|
|
});
|
|
|
|
test("getCursorAgentCliVersion reads CURSOR_DATA_DIR via isolated HOME", () => {
|
|
const home = fs.mkdtempSync(path.join(os.tmpdir(), "cursor-cli-home-get-"));
|
|
const data = fs.mkdtempSync(path.join(os.tmpdir(), "cursor-cli-data-get-"));
|
|
try {
|
|
const id = "2026.03.15-cafebabe";
|
|
fs.mkdirSync(path.join(data, "versions", id), { recursive: true });
|
|
withEnv(
|
|
{
|
|
HOME: home,
|
|
USERPROFILE: home,
|
|
CURSOR_DATA_DIR: data,
|
|
CURSOR_AGENT_CLI_VERSION: undefined,
|
|
},
|
|
() => {
|
|
resetCursorAgentCliVersionCache();
|
|
assert.equal(getCursorAgentCliVersion(), id);
|
|
assert.equal(formatCursorAgentClientVersion(getCursorAgentCliVersion()), `cli-${id}`);
|
|
}
|
|
);
|
|
} finally {
|
|
resetCursorAgentCliVersionCache();
|
|
fs.rmSync(home, { recursive: true, force: true, maxRetries: 5, retryDelay: 100 });
|
|
fs.rmSync(data, { recursive: true, force: true, maxRetries: 5, retryDelay: 100 });
|
|
}
|
|
});
|
|
|
|
test("extractVersionIdFromInstallerScript reads downloads.cursor.com/lab/<id>/", () => {
|
|
const script = `
|
|
BASE="https://downloads.cursor.com/lab/2026.08.01-deadbeef/linux/x64"
|
|
echo "$BASE"
|
|
`;
|
|
assert.equal(extractVersionIdFromInstallerScript(script), "2026.08.01-deadbeef");
|
|
assert.equal(extractVersionIdFromInstallerScript("no version here"), null);
|
|
});
|
|
|
|
test("disk cache hit serves immediately without blocking on network", async () => {
|
|
const cacheDir = fs.mkdtempSync(path.join(os.tmpdir(), "cursor-cli-cache-hit-"));
|
|
const home = fs.mkdtempSync(path.join(os.tmpdir(), "cursor-cli-home-cache-"));
|
|
let fetchCalls = 0;
|
|
const cachedId = "2026.08.02-aabbcc1";
|
|
try {
|
|
configureCursorAgentCliVersionForTests({
|
|
cacheDir,
|
|
fetchImpl: (async () => {
|
|
fetchCalls += 1;
|
|
return new Response(`https://downloads.cursor.com/lab/2026.08.09-zzzzzzz/linux/x64/`, {
|
|
status: 200,
|
|
});
|
|
}) as typeof fetch,
|
|
});
|
|
fs.writeFileSync(
|
|
path.join(cacheDir, "cursor-agent-cli-version.json"),
|
|
JSON.stringify({ version: cachedId, fetchedAt: Date.now() })
|
|
);
|
|
withEnv(
|
|
{
|
|
HOME: home,
|
|
USERPROFILE: home,
|
|
CURSOR_AGENT_CLI_VERSION: undefined,
|
|
CURSOR_DATA_DIR: undefined,
|
|
},
|
|
() => {
|
|
resetCursorAgentCliVersionCache();
|
|
// Sync path returns disk cache immediately (oakimov SWR may refresh in background).
|
|
assert.equal(getCursorAgentCliVersion(), cachedId);
|
|
assert.equal(fetchCalls, 0, "must not block on network");
|
|
}
|
|
);
|
|
} finally {
|
|
resetCursorAgentCliVersionTestHooks();
|
|
fs.rmSync(cacheDir, { recursive: true, force: true, maxRetries: 5, retryDelay: 100 });
|
|
fs.rmSync(home, { recursive: true, force: true, maxRetries: 5, retryDelay: 100 });
|
|
}
|
|
});
|
|
|
|
test("refreshCursorAgentCliVersionFromInstaller writes disk cache from HTML", async () => {
|
|
const cacheDir = fs.mkdtempSync(path.join(os.tmpdir(), "cursor-cli-cache-refresh-"));
|
|
const scrapedId = "2026.08.03-1122334";
|
|
try {
|
|
configureCursorAgentCliVersionForTests({
|
|
cacheDir,
|
|
fetchImpl: (async () =>
|
|
new Response(
|
|
`curl -fsSL https://downloads.cursor.com/lab/${scrapedId}/darwin/arm64/agent-cli-package.tar.gz`,
|
|
{ status: 200 }
|
|
)) as typeof fetch,
|
|
});
|
|
resetCursorAgentCliVersionCache();
|
|
const id = await refreshCursorAgentCliVersionFromInstaller();
|
|
assert.equal(id, scrapedId);
|
|
const onDisk = JSON.parse(
|
|
fs.readFileSync(path.join(cacheDir, "cursor-agent-cli-version.json"), "utf8")
|
|
) as { version: string };
|
|
assert.equal(onDisk.version, scrapedId);
|
|
} finally {
|
|
resetCursorAgentCliVersionTestHooks();
|
|
fs.rmSync(cacheDir, { recursive: true, force: true, maxRetries: 5, retryDelay: 100 });
|
|
}
|
|
});
|
|
|
|
test("invalid installer HTML falls through to pin", async () => {
|
|
const cacheDir = fs.mkdtempSync(path.join(os.tmpdir(), "cursor-cli-cache-invalid-"));
|
|
const home = fs.mkdtempSync(path.join(os.tmpdir(), "cursor-cli-home-invalid-"));
|
|
try {
|
|
configureCursorAgentCliVersionForTests({
|
|
cacheDir,
|
|
fetchImpl: (async () =>
|
|
new Response("<html>no lab url</html>", { status: 200 })) as typeof fetch,
|
|
});
|
|
withEnv(
|
|
{
|
|
HOME: home,
|
|
USERPROFILE: home,
|
|
CURSOR_AGENT_CLI_VERSION: undefined,
|
|
CURSOR_DATA_DIR: undefined,
|
|
},
|
|
() => {
|
|
resetCursorAgentCliVersionCache();
|
|
assert.equal(getCursorAgentCliVersion(), CURSOR_AGENT_CLI_VERSION);
|
|
}
|
|
);
|
|
const id = await refreshCursorAgentCliVersionFromInstaller();
|
|
assert.equal(id, null);
|
|
} finally {
|
|
resetCursorAgentCliVersionTestHooks();
|
|
fs.rmSync(cacheDir, { recursive: true, force: true, maxRetries: 5, retryDelay: 100 });
|
|
fs.rmSync(home, { recursive: true, force: true, maxRetries: 5, retryDelay: 100 });
|
|
}
|
|
});
|