Files
OmniRoute/tests/unit/runtime/magicBytes.test.ts
Diego Rodrigues de Sa e Souza 3d4f3e4960 test(infra): retry recursive temp-dir removal instead of failing a shard on ENOTEMPTY (#11966) (#11968)
* test(infra): retry recursive temp-dir removal instead of failing a shard on ENOTEMPTY (#11966)

Two shards on release/v3.8.51 went red in one day with the same signature —
"ENOTEMPTY, Directory not empty: /tmp/omniroute-<test>-XXXXXX" — from
combo-same-provider-cascade (Unit Tests fast-path 4/4, on a PR that touches only
.github/) and auth-policy-embeddings-webfetch-7785 (the 20k-test TIA step). Both pass
alone and on re-run: the cleanup races something still writing into the directory
(SQLite WAL/-shm checkpoint, a worker, the backup) and under a loaded hosted runner
the window opens. 1154 test files do their own cleanup with
fs.rmSync(dir, { recursive: true, force: true }); 57 already asked for retries.

One-shot codemod (scripts/ad-hoc/codemod-rm-maxretries.mjs, kept for the record):
every rm / rmSync / rmdirSync option object with `recursive: true` and no
`maxRetries` gains `maxRetries: 5, retryDelay: 100` — Node itself then retries
ENOTEMPTY/EBUSY/EPERM for up to ~0.5 s before giving up. 2243 call sites in 1292
files under tests/, the shared tests/_setup/isolateDataDir.ts exit hook included.
Only the option object changes: no call site, assertion or import is touched.

Validation: prettier and ESLint (with the frozen suppressions) clean on all 1292
files; a random 20-file sample runs green (quota-redis-store hangs identically on
the untouched tree — it needs a Redis on localhost, an environment matter). The
four unit shards on this PR are the full run.

* fix(quality): let check-forgotten-sibling-tests read a 1,000-file diff

The gate shells out to `git diff` through execFileSync with Node's default 1 MB
maxBuffer; the 1,292-file codemod in this PR is the first diff large enough to
overflow it, and the gate died with `spawnSync git ENOBUFS` before comparing
anything. 64 MB is far above any real PR and costs nothing when unused.
2026-08-29 01:17:40 -03:00

63 lines
2.1 KiB
TypeScript

import { test } from "node:test";
import assert from "node:assert/strict";
import { writeFileSync, mkdtempSync, rmSync } from "node:fs";
import { join } from "node:path";
import { tmpdir } from "node:os";
import { validateBinaryMagic, platformBinaryLabel } from "../../../bin/cli/runtime/magicBytes.mjs";
const dir = mkdtempSync(join(tmpdir(), "magic-test-"));
test("detects ELF", () => {
const p = join(dir, "fake.so");
writeFileSync(p, Buffer.from([0x7f, 0x45, 0x4c, 0x46, 0, 0, 0, 0]));
assert.equal(validateBinaryMagic(p), "elf");
});
test("detects Mach-O 64-bit BE", () => {
const p = join(dir, "fake.dylib");
writeFileSync(p, Buffer.from([0xfe, 0xed, 0xfa, 0xcf, 0, 0, 0, 0]));
assert.equal(validateBinaryMagic(p), "macho");
});
test("detects Mach-O LE", () => {
const p = join(dir, "fake-le.dylib");
writeFileSync(p, Buffer.from([0xcf, 0xfa, 0xed, 0xfe, 0, 0, 0, 0]));
assert.equal(validateBinaryMagic(p), "macho-le");
});
test("detects Mach-O fat binary", () => {
const p = join(dir, "fake.fat");
writeFileSync(p, Buffer.from([0xca, 0xfe, 0xba, 0xbe, 0, 0, 0, 0]));
assert.equal(validateBinaryMagic(p), "macho-fat");
});
test("detects PE (MZ)", () => {
const p = join(dir, "fake.node");
writeFileSync(p, Buffer.from([0x4d, 0x5a, 0, 0, 0, 0, 0, 0]));
assert.equal(validateBinaryMagic(p), "pe");
});
test("returns null for non-binary", () => {
const p = join(dir, "fake.txt");
writeFileSync(p, "hello world", "utf-8");
assert.equal(validateBinaryMagic(p), null);
});
test("returns null for missing file", () => {
assert.equal(validateBinaryMagic(join(dir, "nope.bin")), null);
});
test("returns null for too-short file", () => {
const p = join(dir, "short.bin");
writeFileSync(p, Buffer.from([0x7f, 0x45]));
assert.equal(validateBinaryMagic(p), null);
});
test("platformBinaryLabel matches process.platform", () => {
const expected =
process.platform === "win32" ? "pe" : process.platform === "darwin" ? "macho" : "elf";
assert.equal(platformBinaryLabel(), expected);
});
test.after(() => rmSync(dir, { recursive: true, force: true, maxRetries: 5, retryDelay: 100 }));