Files
OmniRoute/tests/unit/sync-bundle.test.ts
Diego Rodrigues de Sa e Souza 3d4f3e4960 test(infra): retry recursive temp-dir removal instead of failing a shard on ENOTEMPTY (#11966) (#11968)
* test(infra): retry recursive temp-dir removal instead of failing a shard on ENOTEMPTY (#11966)

Two shards on release/v3.8.51 went red in one day with the same signature —
"ENOTEMPTY, Directory not empty: /tmp/omniroute-<test>-XXXXXX" — from
combo-same-provider-cascade (Unit Tests fast-path 4/4, on a PR that touches only
.github/) and auth-policy-embeddings-webfetch-7785 (the 20k-test TIA step). Both pass
alone and on re-run: the cleanup races something still writing into the directory
(SQLite WAL/-shm checkpoint, a worker, the backup) and under a loaded hosted runner
the window opens. 1154 test files do their own cleanup with
fs.rmSync(dir, { recursive: true, force: true }); 57 already asked for retries.

One-shot codemod (scripts/ad-hoc/codemod-rm-maxretries.mjs, kept for the record):
every rm / rmSync / rmdirSync option object with `recursive: true` and no
`maxRetries` gains `maxRetries: 5, retryDelay: 100` — Node itself then retries
ENOTEMPTY/EBUSY/EPERM for up to ~0.5 s before giving up. 2243 call sites in 1292
files under tests/, the shared tests/_setup/isolateDataDir.ts exit hook included.
Only the option object changes: no call site, assertion or import is touched.

Validation: prettier and ESLint (with the frozen suppressions) clean on all 1292
files; a random 20-file sample runs green (quota-redis-store hangs identically on
the untouched tree — it needs a Redis on localhost, an environment matter). The
four unit shards on this PR are the full run.

* fix(quality): let check-forgotten-sibling-tests read a 1,000-file diff

The gate shells out to `git diff` through execFileSync with Node's default 1 MB
maxBuffer; the 1,292-file codemod in this PR is the first diff large enough to
overflow it, and the gate died with `spawnSync git ENOBUFS` before comparing
anything. 64 MB is far above any real PR and costs nothing when unused.
2026-08-29 01:17:40 -03:00

132 lines
4.6 KiB
TypeScript

import test from "node:test";
import assert from "node:assert/strict";
import fs from "node:fs";
import os from "node:os";
import path from "node:path";
const TEST_DATA_DIR = fs.mkdtempSync(path.join(os.tmpdir(), "omniroute-sync-bundle-"));
const ORIGINAL_DATA_DIR = process.env.DATA_DIR;
const ORIGINAL_API_KEY_SECRET = process.env.API_KEY_SECRET;
process.env.DATA_DIR = TEST_DATA_DIR;
process.env.API_KEY_SECRET = process.env.API_KEY_SECRET || "test-sync-bundle-secret";
const core = await import("../../src/lib/db/core.ts");
const settingsDb = await import("../../src/lib/db/settings.ts");
const providersDb = await import("../../src/lib/db/providers.ts");
const combosDb = await import("../../src/lib/db/combos.ts");
const modelsDb = await import("../../src/lib/db/models.ts");
const apiKeysDb = await import("../../src/lib/db/apiKeys.ts");
const syncBundle = await import("../../src/lib/sync/bundle.ts");
function resetStorage() {
apiKeysDb.resetApiKeyState();
core.resetDbInstance();
fs.rmSync(TEST_DATA_DIR, { recursive: true, force: true, maxRetries: 5, retryDelay: 100 });
fs.mkdirSync(TEST_DATA_DIR, { recursive: true });
}
test.beforeEach(() => {
resetStorage();
});
test.after(() => {
apiKeysDb.resetApiKeyState();
core.resetDbInstance();
fs.rmSync(TEST_DATA_DIR, { recursive: true, force: true, maxRetries: 5, retryDelay: 100 });
if (ORIGINAL_DATA_DIR === undefined) {
delete process.env.DATA_DIR;
} else {
process.env.DATA_DIR = ORIGINAL_DATA_DIR;
}
if (ORIGINAL_API_KEY_SECRET === undefined) {
delete process.env.API_KEY_SECRET;
} else {
process.env.API_KEY_SECRET = ORIGINAL_API_KEY_SECRET;
}
});
test("config sync bundle is deterministic, strips auth settings, and ignores volatile fields", async () => {
await settingsDb.updateSettings({
theme: "midnight",
requireLogin: true,
password: "hashed-password",
cloudEnabled: true,
});
const connection = await providersDb.createProviderConnection({
provider: "openai",
authType: "apikey",
name: "Primary OpenAI",
apiKey: "sk-live-secret",
defaultModel: "gpt-4o-mini",
providerSpecificData: { region: "us" },
});
await modelsDb.setModelAlias("smart-default", "openai/gpt-4o-mini");
await combosDb.createCombo({
name: "primary",
models: ["openai/gpt-4o-mini"],
strategy: "priority",
});
const apiKey = await apiKeysDb.createApiKey("Desktop", "machine-sync-1");
await apiKeysDb.updateApiKeyPermissions(apiKey.id, {
modelAccessMode: "restricted",
allowedModels: [],
});
const first = await syncBundle.buildConfigSyncEnvelope();
const second = await syncBundle.buildConfigSyncEnvelope();
assert.equal(first.version, second.version);
assert.deepEqual(first.bundle, second.bundle);
assert.equal(first.bundle.settings.password, undefined);
assert.equal(first.bundle.settings.requireLogin, undefined);
assert.equal(first.bundle.settings.cloudEnabled, undefined);
assert.equal(first.bundle.providerConnections[0].apiKey, "sk-live-secret");
assert.equal(first.bundle.modelAliases["smart-default"], "openai/gpt-4o-mini");
assert.equal(first.bundle.apiKeys[0].modelAccessMode, "restricted");
assert.deepEqual(first.bundle.apiKeys[0].allowedModels, []);
assert.deepEqual(first.bundle.reasoningRoutingRules, []);
await providersDb.updateProviderConnection((connection as any).id, {
lastError: "temporary upstream failure",
lastErrorAt: "2026-04-14T12:00:00.000Z",
rateLimitedUntil: "2026-04-14T12:30:00.000Z",
});
const afterVolatileChange = await syncBundle.buildConfigSyncEnvelope();
assert.equal(afterVolatileChange.version, first.version);
await providersDb.updateProviderConnection((connection as any).id, {
defaultModel: "gpt-4.1-mini",
});
const afterConfigChange = await syncBundle.buildConfigSyncEnvelope();
assert.notEqual(afterConfigChange.version, first.version);
assert.equal(afterConfigChange.bundle.providerConnections[0].defaultModel, "gpt-4.1-mini");
});
test("reasoning sync reconciliation disables dangling references and reports conflicts", () => {
const result = syncBundle.reconcileReasoningRulesForSync(
[
{ id: "valid", scope: "global", targetKind: "keep", enabled: true },
{
id: "dangling",
scope: "apiKey",
apiKeyId: "missing-key",
targetKind: "combo",
targetComboId: "missing-combo",
enabled: true,
},
],
{ apiKeyIds: [], comboIds: [], connectionIds: [] }
);
assert.equal(result.rules[0].enabled, true);
assert.equal(result.rules[1].enabled, false);
assert.deepEqual(result.conflicts, [
{ ruleId: "dangling", missing: ["apiKeyId", "targetComboId"] },
]);
});