Files
OmniRoute/tests/unit/zcode-executor.test.ts
Diego Rodrigues de Sa e Souza 3d4f3e4960 test(infra): retry recursive temp-dir removal instead of failing a shard on ENOTEMPTY (#11966) (#11968)
* test(infra): retry recursive temp-dir removal instead of failing a shard on ENOTEMPTY (#11966)

Two shards on release/v3.8.51 went red in one day with the same signature —
"ENOTEMPTY, Directory not empty: /tmp/omniroute-<test>-XXXXXX" — from
combo-same-provider-cascade (Unit Tests fast-path 4/4, on a PR that touches only
.github/) and auth-policy-embeddings-webfetch-7785 (the 20k-test TIA step). Both pass
alone and on re-run: the cleanup races something still writing into the directory
(SQLite WAL/-shm checkpoint, a worker, the backup) and under a loaded hosted runner
the window opens. 1154 test files do their own cleanup with
fs.rmSync(dir, { recursive: true, force: true }); 57 already asked for retries.

One-shot codemod (scripts/ad-hoc/codemod-rm-maxretries.mjs, kept for the record):
every rm / rmSync / rmdirSync option object with `recursive: true` and no
`maxRetries` gains `maxRetries: 5, retryDelay: 100` — Node itself then retries
ENOTEMPTY/EBUSY/EPERM for up to ~0.5 s before giving up. 2243 call sites in 1292
files under tests/, the shared tests/_setup/isolateDataDir.ts exit hook included.
Only the option object changes: no call site, assertion or import is touched.

Validation: prettier and ESLint (with the frozen suppressions) clean on all 1292
files; a random 20-file sample runs green (quota-redis-store hangs identically on
the untouched tree — it needs a Redis on localhost, an environment matter). The
four unit shards on this PR are the full run.

* fix(quality): let check-forgotten-sibling-tests read a 1,000-file diff

The gate shells out to `git diff` through execFileSync with Node's default 1 MB
maxBuffer; the 1,292-file codemod in this PR is the first diff large enough to
overflow it, and the gate died with `spawnSync git ENOBUFS` before comparing
anything. 64 MB is far above any real PR and costs nothing when unused.
2026-08-29 01:17:40 -03:00

89 lines
3.0 KiB
TypeScript

import test from "node:test";
import assert from "node:assert/strict";
import { mkdtempSync, rmSync } from "node:fs";
import { tmpdir } from "node:os";
import { join } from "node:path";
const fixture = join(process.cwd(), "tests/fixtures/fake-zcode-app-server.mjs");
const TEST_DATA_DIR = mkdtempSync(join(tmpdir(), "omniroute-zcode-"));
process.env.DATA_DIR = TEST_DATA_DIR;
test.after(() =>
rmSync(TEST_DATA_DIR, { recursive: true, force: true, maxRetries: 5, retryDelay: 100 })
);
async function loadZcodeExecutor() {
return import("../../open-sse/executors/zcode.ts");
}
function requestBody() {
return {
messages: [
{ role: "system", content: "You are a coding assistant." },
{ role: "user", content: "Reply with a short status." },
],
};
}
test("ZCode accepts GLM Coding Plan models and rejects unsafe/unknown ids", async () => {
const { resolveZcodeModel } = await loadZcodeExecutor();
assert.deepEqual(resolveZcodeModel("glm-5.2"), { ok: true, model: "glm-5.2" });
assert.equal(resolveZcodeModel("glm-5.2-high").ok, false);
assert.equal(resolveZcodeModel("glm-5.3-low").ok, false);
assert.equal(resolveZcodeModel("-unexpected").ok, false);
assert.equal(resolveZcodeModel("unknown-model").ok, false);
});
test("ZCode runs a local app-server turn and returns an OpenAI chat completion", async () => {
const { ZcodeExecutor } = await loadZcodeExecutor();
const executor = new ZcodeExecutor({
command: process.execPath,
args: [fixture],
cwd: process.cwd(),
requestTimeoutMs: 3000,
turnTimeoutMs: 3000,
pollIntervalMs: 1,
});
const result = await executor.execute({
model: "glm-5.2",
body: requestBody(),
stream: false,
credentials: {},
});
const response = "response" in result ? result.response : result;
assert.equal(response.status, 200);
assert.match(response.headers.get("content-type") || "", /application\/json/);
const body = await response.json();
assert.equal(body.object, "chat.completion");
assert.equal(body.model, "glm-5.2");
assert.equal(body.choices?.[0]?.message?.role, "assistant");
assert.equal(body.choices?.[0]?.message?.content, "fake zcode response");
assert.equal(body.choices?.[0]?.finish_reason, "stop");
});
test("ZCode buffers the completed turn into OpenAI SSE when stream=true", async () => {
const { ZcodeExecutor } = await loadZcodeExecutor();
const executor = new ZcodeExecutor({
command: process.execPath,
args: [fixture],
cwd: process.cwd(),
requestTimeoutMs: 3000,
turnTimeoutMs: 3000,
pollIntervalMs: 1,
});
const result = await executor.execute({
model: "glm-5.2",
body: requestBody(),
stream: true,
credentials: {},
});
const response = "response" in result ? result.response : result;
const text = await response.text();
assert.equal(response.status, 200);
assert.match(response.headers.get("content-type") || "", /text\/event-stream/);
assert.match(text, /fake zcode response/);
assert.match(text, /data: \[DONE\]/);
});