mirror of
https://github.com/diegosouzapw/OmniRoute.git
synced 2026-08-02 05:12:11 +03:00
* feat(plugins): WordPress-style plugin system backend * fix(plugins): address code review feedback - Path traversal guard: validate entryPoint stays within plugin dir - install() now handles direct plugin directories (not just parent dirs) - Non-null assertion replaced with explicit null check - require efficiency: allowedModules map moved outside function - Source wrapper: add newlines to prevent trailing comment issues - Config validation: validate values against configSchema on save - Dynamic import comment: clarify Node.js caching behavior Co-Authored-By: OpenClaude (mimo-v2.5-pro) <openclaude@gitlawb.com> * fix(plugins): replace vm with child_process, add auth to all routes Addresses all remaining code review feedback: 1. **Loader rewrite**: Replaced Node.js vm module with child_process.fork() for proper process-level isolation. Complies with Rule 3 (no eval). Each plugin runs in a separate Node.js process with IPC communication. 2. **Auth on all routes**: Added requireManagementAuth to all 6 plugin API route files (list, install, scan, details, activate, deactivate, config). 3. **Env filtering**: Only safe env vars passed to plugin processes unless "env" permission is granted. Co-Authored-By: OpenClaude (mimo-v2.5-pro) <openclaude@gitlawb.com> * fix(plugins): security + ESM fixes for loader and manager loader.ts: - Fix IPC: use process.send()/process.on("message") instead of worker_threads.parentPort - Fix ESM: write host script as .mjs (not .js) to force ESM execution - Add timeout: 10s default on callHook() with Promise.race - Add SIGKILL escalation: SIGTERM first, then SIGKILL after 3s grace - Fix env filtering: use allowlist (safeKeys) instead of passing all env vars - Clear timeout on successful IPC response (no timer leak) manager.ts: - Fix path traversal: use fs.realpath() instead of startsWith() - Fix imports: use registerHook/unregisterHooks from hooks.ts - Register hooks individually via registerHook(event, name, handler) hooks.ts: - Copied from feat/plugin-custom-hooks (canonical registry) * feat(discovery): add discovery tool stub service Phase 1 scaffold for automated provider discovery: - DiscoveryConfig, DiscoveryResult types - probeEndpoint() for URL availability checking - scanProvider() stub (Phase 2 will implement real scanning) - getDiscoveryResults() stub - Default config: disabled (opt-in) * chore(plugins): slop cleanup — pino logger, remove redundant sorts - index.ts: replace console.log/error with pino structured logging - hooks.ts: remove redundant .sort() in emitHookBlocking/runOnResponse (already sorted on registration) - manager.ts: add readFile import * test(plugins): add scanner, loader, manager unit tests - scanner: 9 tests (discovery, hidden dirs, validation, entry point, multiple) - loader: 5 tests (type contracts, Plugin/PluginContext/PluginResult interfaces) - manager: 6 tests (singleton, lifecycle methods, error on unknown) - Total: 20 tests, all passing * fix(settings): add missing home page pin keys to updateSettingsSchema * feat(plugins): add i18n keys to all 42 locales * fix(settings): add missing security keys to updateSettingsSchema and add tests * fix(usage): analytics route reads combo_name/requested_model from call_logs only The 3.8.6 variant of #2904 added SELECTs of combo_name/requested_model against usage_history, but those columns only exist in call_logs (no migration adds them to usage_history). This returned HTTP 500 on /api/usage/analytics. Restore the working query shape from the 3.8.7 variant. Fixes 18 failing usage-analytics-route tests. * fix(types,test): resolve noImplicitAny in progressiveAging + align semaphore test to #2903 gate pruning - progressiveAging: type compression results so messages[0].content is indexable (was TS7053 against {}); restores typecheck:noimplicit:core gate. - services-branch-hardening: #2903 (perf-ram) prunes idle rate-limit gates on zero; assert no-running/empty-queue without assuming the entry persists. * fix(analytics): address merged review regressions * fix(executor): normalize max effort for openai shape providers * Make zero-latency combo optimizations opt-in * Address zero-latency combo review feedback * chore(release): sync v3.8.7 touchpoints + credit contributors - llm.txt → 3.8.7 (Current version + Key Features header) - CHANGELOG: add Dmitry Kuznetsov & Nikolay Alafuzov to 3.8.6 Hall of Contributors - version already 3.8.7 across package.json/open-sse/electron/openapi (from #2909) * fix(cleanup): restore usage history cutoff boundary * docs(changelog): rank 3.8.6 contributors in a commits table with their PRs * fix(dashboard): theme ReactFlow Controls +/- buttons for dark mode * fix(settings): add missing home page pin keys to updateSettingsSchema * fix(settings): add missing security keys to updateSettingsSchema and add tests * fix(executor): normalize max effort for openai shape providers * Make zero-latency combo optimizations opt-in * Address zero-latency combo review feedback * fix(analytics): address merged review regressions * fix(cleanup): restore usage history cutoff boundary * feat(plugins): WordPress-style plugin system backend * fix(plugins): address code review feedback - Path traversal guard: validate entryPoint stays within plugin dir - install() now handles direct plugin directories (not just parent dirs) - Non-null assertion replaced with explicit null check - require efficiency: allowedModules map moved outside function - Source wrapper: add newlines to prevent trailing comment issues - Config validation: validate values against configSchema on save - Dynamic import comment: clarify Node.js caching behavior Co-Authored-By: OpenClaude (mimo-v2.5-pro) <openclaude@gitlawb.com> * fix(plugins): replace vm with child_process, add auth to all routes Addresses all remaining code review feedback: 1. **Loader rewrite**: Replaced Node.js vm module with child_process.fork() for proper process-level isolation. Complies with Rule 3 (no eval). Each plugin runs in a separate Node.js process with IPC communication. 2. **Auth on all routes**: Added requireManagementAuth to all 6 plugin API route files (list, install, scan, details, activate, deactivate, config). 3. **Env filtering**: Only safe env vars passed to plugin processes unless "env" permission is granted. Co-Authored-By: OpenClaude (mimo-v2.5-pro) <openclaude@gitlawb.com> * fix(plugins): security + ESM fixes for loader and manager loader.ts: - Fix IPC: use process.send()/process.on("message") instead of worker_threads.parentPort - Fix ESM: write host script as .mjs (not .js) to force ESM execution - Add timeout: 10s default on callHook() with Promise.race - Add SIGKILL escalation: SIGTERM first, then SIGKILL after 3s grace - Fix env filtering: use allowlist (safeKeys) instead of passing all env vars - Clear timeout on successful IPC response (no timer leak) manager.ts: - Fix path traversal: use fs.realpath() instead of startsWith() - Fix imports: use registerHook/unregisterHooks from hooks.ts - Register hooks individually via registerHook(event, name, handler) hooks.ts: - Copied from feat/plugin-custom-hooks (canonical registry) * feat(discovery): add discovery tool stub service Phase 1 scaffold for automated provider discovery: - DiscoveryConfig, DiscoveryResult types - probeEndpoint() for URL availability checking - scanProvider() stub (Phase 2 will implement real scanning) - getDiscoveryResults() stub - Default config: disabled (opt-in) * chore(plugins): slop cleanup — pino logger, remove redundant sorts - index.ts: replace console.log/error with pino structured logging - hooks.ts: remove redundant .sort() in emitHookBlocking/runOnResponse (already sorted on registration) - manager.ts: add readFile import * test(plugins): add scanner, loader, manager unit tests - scanner: 9 tests (discovery, hidden dirs, validation, entry point, multiple) - loader: 5 tests (type contracts, Plugin/PluginContext/PluginResult interfaces) - manager: 6 tests (singleton, lifecycle methods, error on unknown) - Total: 20 tests, all passing * feat(plugins): add i18n keys to all 42 locales * chore(plugins): remove duplicate migration 059_create_plugins.sql * chore(plugins): remove duplicate migration 059_create_plugins.sql (post-merge) * fix(sse): guard non-string error.code in proxyFetch + harden model parsing (#2463) (#2923) Integrated into release/v3.8.7 * fix(docker): add runner-web stage with Playwright Chromium (#2832) (#2846) Integrated into release/v3.8.7 * docs(changelog): document NVIDIA NIM and error code type-crash fix (#2463) * test: ignore NVIDIA_BASE_URL and NVIDIA_MODEL in env contract check --------- Co-authored-by: oyi77 <oyi77@users.noreply.github.com> Co-authored-by: OpenClaude (mimo-v2.5-pro) <openclaude@gitlawb.com> Co-authored-by: Apostol Apostolov <theapoapostolov@gmail.com> Co-authored-by: Halil Tezcan KARABULUT <info@hlltzcnkb.com> Co-authored-by: R.D. <rogerproself@gmail.com>
111 lines
3.1 KiB
TypeScript
111 lines
3.1 KiB
TypeScript
/**
|
|
* Plugin scanner — discovers plugins from the filesystem.
|
|
*
|
|
* Scans ~/.omniroute/plugins/ for subdirectories containing plugin.json manifests.
|
|
* Returns validated manifests with directory paths.
|
|
*
|
|
* @module plugins/scanner
|
|
*/
|
|
|
|
import { readdir, stat, readFile } from "fs/promises";
|
|
import { join } from "path";
|
|
import { logger } from "../../../open-sse/utils/logger.ts";
|
|
import { safeValidateManifest, type PluginManifestWithDefaults } from "./manifest";
|
|
|
|
const log = logger("PLUGIN_SCANNER");
|
|
|
|
export interface DiscoveredPlugin {
|
|
name: string;
|
|
manifest: PluginManifestWithDefaults;
|
|
pluginDir: string;
|
|
entryPoint: string;
|
|
}
|
|
|
|
/**
|
|
* Get the default plugin directory: ~/.omniroute/plugins/
|
|
*/
|
|
export function getDefaultPluginDir(): string {
|
|
const home = process.env.HOME || process.env.USERPROFILE || "/tmp";
|
|
return join(home, ".omniroute", "plugins");
|
|
}
|
|
|
|
/**
|
|
* Scan a directory for plugin subdirectories containing plugin.json.
|
|
* Skips hidden directories (.xxx) and non-directories.
|
|
*/
|
|
export async function scanPluginDir(
|
|
dir: string
|
|
): Promise<{ plugins: DiscoveredPlugin[]; errors: Array<{ name: string; error: string }> }> {
|
|
const plugins: DiscoveredPlugin[] = [];
|
|
const errors: Array<{ name: string; error: string }> = [];
|
|
|
|
let entries: string[];
|
|
try {
|
|
const dirEntries = await readdir(dir, { withFileTypes: true });
|
|
entries = dirEntries
|
|
.filter((e) => e.isDirectory() && !e.name.startsWith("."))
|
|
.map((e) => e.name);
|
|
} catch (err: any) {
|
|
if (err.code === "ENOENT") {
|
|
log.info("scanner.dir_not_found", { dir });
|
|
return { plugins: [], errors: [] };
|
|
}
|
|
throw err;
|
|
}
|
|
|
|
for (const entry of entries) {
|
|
const pluginDir = join(dir, entry);
|
|
const manifestPath = join(pluginDir, "plugin.json");
|
|
|
|
try {
|
|
const manifestStat = await stat(manifestPath);
|
|
if (!manifestStat.isFile()) {
|
|
errors.push({ name: entry, error: "plugin.json is not a file" });
|
|
continue;
|
|
}
|
|
} catch {
|
|
errors.push({ name: entry, error: "no plugin.json found" });
|
|
continue;
|
|
}
|
|
|
|
try {
|
|
const raw = await readFile(manifestPath, "utf-8");
|
|
const parsed = JSON.parse(raw);
|
|
const result = safeValidateManifest(parsed);
|
|
|
|
if (!result.success) {
|
|
const failResult = result as { success: false; errors: string[] };
|
|
errors.push({ name: entry, error: `invalid manifest: ${failResult.errors.join("; ")}` });
|
|
continue;
|
|
}
|
|
|
|
const manifest = result.data;
|
|
const entryPoint = join(pluginDir, manifest.main);
|
|
|
|
// Verify entry point exists
|
|
try {
|
|
await stat(entryPoint);
|
|
} catch {
|
|
errors.push({
|
|
name: entry,
|
|
error: `entry point not found: ${manifest.main}`,
|
|
});
|
|
continue;
|
|
}
|
|
|
|
plugins.push({
|
|
name: manifest.name,
|
|
manifest,
|
|
pluginDir,
|
|
entryPoint,
|
|
});
|
|
|
|
log.info("scanner.discovered", { name: manifest.name, version: manifest.version });
|
|
} catch (err: any) {
|
|
errors.push({ name: entry, error: `failed to read manifest: ${err.message}` });
|
|
}
|
|
}
|
|
|
|
return { plugins, errors };
|
|
}
|