mirror of
https://github.com/diegosouzapw/OmniRoute.git
synced 2026-09-19 21:32:20 +03:00
bdc79ef883
Built-in providers that speak the OpenAI Chat wire format skipped normalizeOpenAICompatibleTools(), which only ran for custom openai-compatible-* connections. A client tool whose type is not "function" (a named Claude server tool, a nameless hosted tool) was forwarded verbatim, and agentrouter's GLM backend rejected the whole request with 400 tools[0].type:type is illegal. Extract the gate into shouldNormalizeFunctionToolsOnly(): custom openai-compatible-* providers keep normalizing on every target, and a conservative allowlist of built-in providers (agentrouter first) normalizes on the OpenAI Chat target only. OpenAI itself stays off the list, so its custom tools pass through untouched. Closes #13789
74 lines
2.4 KiB
TypeScript
74 lines
2.4 KiB
TypeScript
import test from "node:test";
|
|
import assert from "node:assert/strict";
|
|
|
|
import { normalizeOpenAICompatibleTools } from "../../open-sse/handlers/chatCore/openAICompatibleTools.ts";
|
|
import { FORMATS } from "../../open-sse/translator/formats.ts";
|
|
|
|
test("preserves all Responses tool types for the Responses translator", () => {
|
|
const customTool = {
|
|
type: "custom",
|
|
name: "exec",
|
|
description: "Run a shell command",
|
|
};
|
|
const namespaceTool = {
|
|
type: "namespace",
|
|
name: "functions",
|
|
tools: [customTool],
|
|
};
|
|
const localShellTool = { type: "local_shell" };
|
|
|
|
const result = normalizeOpenAICompatibleTools(
|
|
[customTool, namespaceTool, localShellTool],
|
|
FORMATS.OPENAI_RESPONSES
|
|
);
|
|
|
|
assert.deepEqual(result, {
|
|
tools: [customTool, namespaceTool, localShellTool],
|
|
dropped: 0,
|
|
});
|
|
});
|
|
|
|
test("normalizes named non-function tools for other source formats", () => {
|
|
const result = normalizeOpenAICompatibleTools(
|
|
[{ type: "custom", name: "exec", input_schema: { type: "object" } }],
|
|
FORMATS.OPENAI
|
|
);
|
|
|
|
assert.deepEqual(result, {
|
|
tools: [
|
|
{
|
|
type: "function",
|
|
function: {
|
|
name: "exec",
|
|
parameters: { type: "object" },
|
|
},
|
|
},
|
|
],
|
|
dropped: 0,
|
|
});
|
|
});
|
|
|
|
// #13789 — the normalization gate itself: which providers get non-function
|
|
// tools converted/dropped before translation.
|
|
const { shouldNormalizeFunctionToolsOnly } =
|
|
await import("../../open-sse/handlers/chatCore/openAICompatibleTools.ts");
|
|
|
|
test("#13789 custom openai-compatible-* providers always normalize", () => {
|
|
for (const format of [FORMATS.OPENAI, FORMATS.OPENAI_RESPONSES, FORMATS.CLAUDE]) {
|
|
assert.equal(shouldNormalizeFunctionToolsOnly("openai-compatible-acme", format), true);
|
|
}
|
|
});
|
|
|
|
test("#13789 allowlisted built-ins normalize on the OpenAI Chat target only", () => {
|
|
assert.equal(shouldNormalizeFunctionToolsOnly("agentrouter", FORMATS.OPENAI), true);
|
|
// Responses keeps native hosted tools; Claude has its own dispatch normalization.
|
|
assert.equal(shouldNormalizeFunctionToolsOnly("agentrouter", FORMATS.OPENAI_RESPONSES), false);
|
|
assert.equal(shouldNormalizeFunctionToolsOnly("agentrouter", FORMATS.CLAUDE), false);
|
|
});
|
|
|
|
test("#13789 every other provider (including openai) is untouched", () => {
|
|
for (const provider of ["openai", "anthropic", "gemini", "minimax", undefined]) {
|
|
assert.equal(shouldNormalizeFunctionToolsOnly(provider, FORMATS.OPENAI), false);
|
|
}
|
|
});
|