mirror of
https://github.com/diegosouzapw/OmniRoute.git
synced 2026-08-02 21:32:10 +03:00
763ed82d3c
* fix(guardrails): Vision Bridge describe-fallback ignores unreachable candidates getVisionCapableModels() scanned the entire static PROVIDER_MODELS catalog for a describe-fallback model without checking whether the provider has a usable active connection on this instance. On an instance with no `openai` provider connected, this let the hardcoded default `openai/gpt-4o-mini` win selection every time, the describe call would fail, and replaceImageParts()'s describe-failure fallback (#4012) intentionally preserves the raw image part — which then reaches a non-vision backend and gets rejected with an opaque upstream error (e.g. "unknown variant `image_url`, expected `text`"). Extract the credential-usability check already used by the whole-request reroute path (visionBridge.ts's hasUsableCredentialsForModel / isProviderConnectionUsable) into a shared visionBridgeCredentials.ts module, and apply the same check to the describe-fallback candidate list in visionBridgeRouter.ts. A confirmed-unusable connection (`false`) excludes a candidate; an indeterminate result (`null`, e.g. no DB) fails open to preserve existing behavior. getVisionCapableModels/getBestVisionModel/getFallbackModels become async to support the credential lookup; call sites and the existing unit test suite are updated accordingly, plus new coverage for the exclusion behavior. * fix(guardrails): fix flaky credential-mock race and move Vision Bridge router tests to a CI-blocking runner The two new assertions added in this PR (excludes a candidate with no usable active connection / selects a credentialed candidate over an uncredentialed one) were correct — the failure was a genuine Vitest race: getVisionCapableModels() fans out to hasUsableCredentialsForModel() once per catalog entry via Promise.all, and dozens of concurrent first-load `await import("@/lib/db/providers")` calls for the same specifier under vi.mock() nondeterministically resolved against the real module instead of the mock for some callers. Memoize the dynamic import in visionBridgeCredentials.ts so it resolves exactly once and is reused, which removes the race entirely (and is cheaper at runtime too). Also: tests/unit/guardrails/visionBridgeRouter.test.tsx was never collected by any CI-blocking gate — `test:unit`'s guardrails glob is `*.test.ts` only, and `test:vitest` (vitest.mcp.config.ts) doesn't include this directory; only the advisory `test:vitest:ui` picked it up. Moved the suite to visionBridgeRouter.test.ts under node:test, threading an optional `deps.hasUsableCredentials` injection point through getBestVisionModel()/getFallbackModels() (consistent with the existing deps pattern in visionBridge.ts) since this project's native test runner has no supported ESM module-mocking mechanism. Running the full guardrails suite together also surfaced that this PR's own credential-exclusion feature silently broke the pre-existing vision-bridge-callmodel.test.ts fallback-retry test: with zero seeded provider connections in that test's isolated DATA_DIR, every fallback candidate is now confirmed-unusable and excluded, leaving no fallback to retry. Seeded one credentialed connection there so the fallback-retry mechanics stay independent of the (unrelated) credential filter. Refs #8433 Co-authored-by: diegosouzapw <8016841+diegosouzapw@users.noreply.github.com> --------- Co-authored-by: diegosouzapw <8016841+diegosouzapw@users.noreply.github.com> Co-authored-by: Diego Rodrigues de Sa e Souza <diegosouza.pw@gmail.com>