Files
OmniRoute/.github/workflows/docker-publish.yml
diegosouzapw 92c51104d4 fix(ci): semver-aware release publish guards (npm + docker)
Prevents the v3.8.3 incident from recurring, where re-publishing old
releases (v2.5.8/v2.6.4/v3.2.8/v3.3.3) clobbered both Docker Hub
:latest and the npm latest dist-tag with the 3.2.8 build.

docker-publish.yml:
- release.types: published -> released (does not fire on edits)
- new step computes promote_latest only when VERSION equals the highest
  semver tag in the repo; pre-release identifiers (-rc/alpha/beta/pre/
  next) never claim :latest
- push to main now tags :main only (never :latest)
- skip-if-exists via docker manifest inspect avoids accidental rebuilds
- workflow_dispatch input promote_latest is opt-in for back-fill builds
- all github/inputs context moved into env: to remove script-injection
  risk flagged by semgrep

npm-publish.yml:
- release.types: published -> released
- dist-tag resolved by semver compare: only the highest stable tag
  becomes latest; older releases fall back to a historic dist-tag
- skip-if-already-published actually works now: dropped the --silent
  flag from npm view that suppressed stdout and broke the grep, which
  is why 3.2.8 re-published and stole @latest
- npm publish always runs with explicit --tag (no implicit @latest
  promotion)
- secrets/inputs moved into env: for the same injection hardening

(cherry picked from commit dedeac4517)
2026-05-25 23:29:49 -03:00

195 lines
6.9 KiB
YAML

name: Publish to Docker Hub
on:
push:
branches:
- main
tags:
- "v*"
paths-ignore:
- ".github/workflows/**"
# Use 'released' instead of 'published' so editing/re-publishing old releases
# does NOT re-trigger this workflow. 'released' fires only on the initial
# release publication (and pre-release → release transition).
release:
types: [released]
workflow_dispatch:
inputs:
version:
description: "Version tag to build (e.g. 3.8.4)"
required: true
type: string
promote_latest:
description: "Also tag :latest (only if this is the highest semver)"
required: false
type: boolean
default: false
permissions:
contents: read
packages: write
jobs:
docker:
name: Build and Push Docker (multi-arch)
runs-on: ubuntu-latest
env:
IMAGE_NAME: diegosouzapw/omniroute
steps:
- name: Checkout
uses: actions/checkout@v6
with:
ref: ${{ github.event_name == 'workflow_dispatch' && format('refs/tags/v{0}', inputs.version) || '' }}
# Need full tag history for semver comparison when deciding :latest.
fetch-depth: 0
- name: Resolve version, latest-promotion, and skip flag
id: version
env:
EVENT_NAME: ${{ github.event_name }}
REF_NAME: ${{ github.ref_name }}
REF_TYPE: ${{ github.ref_type }}
INPUT_VERSION: ${{ inputs.version }}
PROMOTE_INPUT: ${{ inputs.promote_latest }}
run: |
set -euo pipefail
# 1) Resolve version string from the trigger (all inputs come via env).
case "$EVENT_NAME" in
workflow_dispatch)
VERSION="${INPUT_VERSION#v}"
;;
push)
if [ "$REF_TYPE" = "tag" ]; then
VERSION="${REF_NAME#v}"
else
# Push to main → build & tag as `main` only. Never touch :latest.
VERSION="main"
fi
;;
release)
VERSION="${REF_NAME#v}"
;;
*)
VERSION="${REF_NAME#v}"
;;
esac
# Sanity-check: only allow [A-Za-z0-9._-] in VERSION (defense in depth).
if ! printf '%s' "$VERSION" | grep -qE '^[A-Za-z0-9._-]+$'; then
echo "Refusing to use unsafe VERSION value: $VERSION" >&2
exit 1
fi
echo "version=$VERSION" >> "$GITHUB_OUTPUT"
# 2) Decide whether to promote :latest.
PROMOTE="false"
if [ "$VERSION" = "main" ]; then
PROMOTE="false"
elif printf '%s' "$VERSION" | grep -qE -- '-(rc|alpha|beta|pre|next)'; then
echo "Pre-release identifier detected — skipping :latest."
PROMOTE="false"
elif [ "$EVENT_NAME" = "workflow_dispatch" ]; then
PROMOTE="${PROMOTE_INPUT:-false}"
else
git fetch --tags --quiet || true
HIGHEST=$(git tag -l 'v[0-9]*' | sed 's/^v//' | grep -vE -- '-(rc|alpha|beta|pre|next)' | sort -V | tail -1 || echo "")
if [ -n "$HIGHEST" ] && [ "$VERSION" = "$HIGHEST" ]; then
PROMOTE="true"
else
echo "Version $VERSION is not the highest semver tag (highest=${HIGHEST:-<none>}). Not promoting :latest."
fi
fi
echo "promote_latest=$PROMOTE" >> "$GITHUB_OUTPUT"
# 3) Skip if this exact version is already published in Docker Hub.
# `main` is always rebuilt (mutable floating tag).
SKIP="false"
if [ "$VERSION" != "main" ]; then
if docker manifest inspect "diegosouzapw/omniroute:${VERSION}" >/dev/null 2>&1; then
echo "Image diegosouzapw/omniroute:${VERSION} already exists on Docker Hub — skipping rebuild."
SKIP="true"
fi
fi
echo "skip=$SKIP" >> "$GITHUB_OUTPUT"
echo "Publishing diegosouzapw/omniroute:$VERSION (promote_latest=$PROMOTE, skip=$SKIP)"
- name: Set up QEMU (for multi-arch builds)
if: steps.version.outputs.skip != 'true'
uses: docker/setup-qemu-action@v4
- name: Set up Docker Buildx
if: steps.version.outputs.skip != 'true'
uses: docker/setup-buildx-action@v4
- name: Login to Docker Hub
if: steps.version.outputs.skip != 'true'
uses: docker/login-action@v4
with:
username: ${{ secrets.DOCKERHUB_USERNAME }}
password: ${{ secrets.DOCKERHUB_TOKEN }}
- name: Login to GitHub Container Registry
if: steps.version.outputs.skip != 'true'
uses: docker/login-action@v4
with:
registry: ghcr.io
username: ${{ github.actor }}
password: ${{ secrets.GITHUB_TOKEN }}
- name: Compute image tags
id: tags
if: steps.version.outputs.skip != 'true'
env:
VERSION: ${{ steps.version.outputs.version }}
PROMOTE_LATEST: ${{ steps.version.outputs.promote_latest }}
run: |
set -euo pipefail
TAGS="${IMAGE_NAME}:${VERSION}"
TAGS="${TAGS}"$'\n'"ghcr.io/diegosouzapw/omniroute:${VERSION}"
if [ "$PROMOTE_LATEST" = "true" ]; then
TAGS="${TAGS}"$'\n'"${IMAGE_NAME}:latest"
TAGS="${TAGS}"$'\n'"ghcr.io/diegosouzapw/omniroute:latest"
fi
{
echo "tags<<EOF"
echo "$TAGS"
echo "EOF"
} >> "$GITHUB_OUTPUT"
echo "Tags to push:"
echo "$TAGS"
- name: Build and push multi-arch image
if: steps.version.outputs.skip != 'true'
uses: docker/build-push-action@v7
with:
context: .
target: runner-base
platforms: linux/amd64,linux/arm64
push: true
tags: ${{ steps.tags.outputs.tags }}
cache-from: type=gha
cache-to: type=gha,mode=max
no-cache: false
env:
DOCKER_BUILDKIT_INLINE_CACHE: 1
- name: Inspect image
if: steps.version.outputs.skip != 'true' && steps.version.outputs.version != 'main'
env:
VERSION: ${{ steps.version.outputs.version }}
run: |
docker buildx imagetools inspect "${IMAGE_NAME}:${VERSION}"
- name: Update Docker Hub description
# Only refresh README/description when we actually promote :latest
# (avoids overwriting from main pushes or back-fill builds).
if: steps.version.outputs.skip != 'true' && steps.version.outputs.promote_latest == 'true'
uses: peter-evans/dockerhub-description@v5
with:
username: ${{ secrets.DOCKERHUB_USERNAME }}
password: ${{ secrets.DOCKERHUB_TOKEN }}
repository: diegosouzapw/omniroute
short-description: "OmniRoute — Unified AI proxy. Route any LLM through one endpoint."
readme-filepath: ./README.md