mirror of
https://github.com/diegosouzapw/OmniRoute.git
synced 2026-09-13 18:32:12 +03:00
3d4f3e4960
* test(infra): retry recursive temp-dir removal instead of failing a shard on ENOTEMPTY (#11966) Two shards on release/v3.8.51 went red in one day with the same signature — "ENOTEMPTY, Directory not empty: /tmp/omniroute-<test>-XXXXXX" — from combo-same-provider-cascade (Unit Tests fast-path 4/4, on a PR that touches only .github/) and auth-policy-embeddings-webfetch-7785 (the 20k-test TIA step). Both pass alone and on re-run: the cleanup races something still writing into the directory (SQLite WAL/-shm checkpoint, a worker, the backup) and under a loaded hosted runner the window opens. 1154 test files do their own cleanup with fs.rmSync(dir, { recursive: true, force: true }); 57 already asked for retries. One-shot codemod (scripts/ad-hoc/codemod-rm-maxretries.mjs, kept for the record): every rm / rmSync / rmdirSync option object with `recursive: true` and no `maxRetries` gains `maxRetries: 5, retryDelay: 100` — Node itself then retries ENOTEMPTY/EBUSY/EPERM for up to ~0.5 s before giving up. 2243 call sites in 1292 files under tests/, the shared tests/_setup/isolateDataDir.ts exit hook included. Only the option object changes: no call site, assertion or import is touched. Validation: prettier and ESLint (with the frozen suppressions) clean on all 1292 files; a random 20-file sample runs green (quota-redis-store hangs identically on the untouched tree — it needs a Redis on localhost, an environment matter). The four unit shards on this PR are the full run. * fix(quality): let check-forgotten-sibling-tests read a 1,000-file diff The gate shells out to `git diff` through execFileSync with Node's default 1 MB maxBuffer; the 1,292-file codemod in this PR is the first diff large enough to overflow it, and the gate died with `spawnSync git ENOBUFS` before comparing anything. 64 MB is far above any real PR and costs nothing when unused.
90 lines
3.0 KiB
TypeScript
90 lines
3.0 KiB
TypeScript
// Characterization of recordCompressionCacheStats — the compression cache-stats hook extracted
|
|
// from handleChatCore's request-setup compression path (chatCore god-file decomposition, #3501).
|
|
// Fire-and-forget; uses a real temp DB and polls compression_cache_stats. Locks: a compressed
|
|
// prompt records a cache-stats row with the resolved provider/mode/tokens-saved, and the helper
|
|
// returns synchronously without throwing (fail-open).
|
|
import { test, before, after } from "node:test";
|
|
import assert from "node:assert/strict";
|
|
import fs from "node:fs";
|
|
import os from "node:os";
|
|
import path from "node:path";
|
|
|
|
const testDataDir = fs.mkdtempSync(path.join(os.tmpdir(), "omni-comp-cache-test-"));
|
|
process.env.DATA_DIR = testDataDir;
|
|
|
|
const coreDb = await import("../../src/lib/db/core.ts");
|
|
const { recordCompressionCacheStats } =
|
|
await import("../../open-sse/handlers/chatCore/compressionCacheStats.ts");
|
|
|
|
function rowsFor(provider: string): Array<Record<string, unknown>> {
|
|
return coreDb
|
|
.getDbInstance()
|
|
.prepare(
|
|
"SELECT provider, compression_mode AS mode, tokens_saved_compression AS saved FROM compression_cache_stats WHERE provider = ?"
|
|
)
|
|
.all(provider) as Array<Record<string, unknown>>;
|
|
}
|
|
|
|
async function waitForRows(provider: string, min: number, timeoutMs = 3000) {
|
|
const deadline = Date.now() + timeoutMs;
|
|
while (Date.now() < deadline) {
|
|
if (rowsFor(provider).length >= min) break;
|
|
await new Promise((r) => setTimeout(r, 25));
|
|
}
|
|
return rowsFor(provider);
|
|
}
|
|
|
|
before(async () => {
|
|
await coreDb.ensureDbInitialized();
|
|
});
|
|
|
|
after(() => {
|
|
coreDb.resetDbInstance();
|
|
try {
|
|
fs.rmSync(testDataDir, { recursive: true, force: true, maxRetries: 5, retryDelay: 100 });
|
|
} catch {
|
|
// best-effort cleanup
|
|
}
|
|
});
|
|
|
|
test("returns synchronously without throwing (fire-and-forget)", () => {
|
|
assert.doesNotThrow(() =>
|
|
recordCompressionCacheStats({
|
|
compressionInputBody: { messages: [{ role: "user", content: "hi" }] },
|
|
provider: "openai",
|
|
targetFormat: "openai",
|
|
effectiveModel: "gpt-x",
|
|
mode: "balanced",
|
|
stats: { originalTokens: 100, compressedTokens: 60 },
|
|
})
|
|
);
|
|
});
|
|
|
|
test("records a cache-stats row with the resolved provider/mode/tokens-saved", async () => {
|
|
recordCompressionCacheStats({
|
|
compressionInputBody: { messages: [{ role: "user", content: "hello world" }] },
|
|
provider: "ccs-prov",
|
|
targetFormat: "openai",
|
|
effectiveModel: "gpt-ccs",
|
|
mode: "aggressive",
|
|
stats: { originalTokens: 200, compressedTokens: 75 },
|
|
});
|
|
const rows = await waitForRows("ccs-prov", 1);
|
|
assert.equal(rows.length, 1);
|
|
assert.equal(rows[0].mode, "aggressive");
|
|
assert.equal(rows[0].saved, 125);
|
|
});
|
|
|
|
test("clamps negative tokens-saved to 0", async () => {
|
|
recordCompressionCacheStats({
|
|
compressionInputBody: { messages: [] },
|
|
provider: "ccs-neg",
|
|
targetFormat: "openai",
|
|
effectiveModel: "gpt-x",
|
|
mode: "balanced",
|
|
stats: { originalTokens: 50, compressedTokens: 80 },
|
|
});
|
|
const rows = await waitForRows("ccs-neg", 1);
|
|
assert.equal(rows[0].saved, 0);
|
|
});
|