pjandro/3x-ui
1
0
Fork 0
mirror of https://github.com/MHSanaei/3x-ui.git synced 2026-11-10 15:15:00 +03:00
Code Issues Packages Projects Releases Wiki Activity

fix(maskcompat): size xdns domain list from domains alone

Browse Source 
CodeQL (go/allocation-size-overflow, alerts #115/#116) flagged the
len(rawDomains)+len(rawResolvers) capacity hint. The sum cannot overflow
in practice, but the hint bought nothing: resolver-derived domains are
deduplicated and append grows the slice as needed.
This commit is contained in:
MHSanaei
2026-10-02 14:36:47 +02:00
parent 99bc68fa14
commit eef1c1eb6a
1 changed files with 1 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files
internal/util/maskcompat/xdns.go
+1 -1
View File
@@ -34,7 +34,7 @@ func upgradeLegacyXdnsSettings(settings map[string]any) bool {
if !hasLegacyXdnsEntry(rawDomains) && !hasLegacyXdnsEntry(rawResolvers) { if !hasLegacyXdnsEntry(rawDomains) && !hasLegacyXdnsEntry(rawResolvers) {
return false return false
} }
domains := make([]any, 0, len(rawDomains)+len(rawResolvers)) domains := make([]any, 0, len(rawDomains))
listed := map[string]bool{} listed := map[string]bool{}
addDomain := func(domain map[string]any) { addDomain := func(domain map[string]any) {
key, _ := domain["name"].(string) key, _ := domain["name"].(string)