Files
3x-ui/internal/web/service/client_effective_flow_test.go
MHSanaei 12d51d7195 perf(tests): copy a migrated template DB instead of migrating per test
Most tests opened a throwaway panel DB with database.InitDB, which runs the
full AutoMigrate + seed on an empty file every time: ~230ms, and ~850ms under
-race because GORM's reflection-heavy migration is what the detector slows
most. internal/web/service does this in ~550 of its 830 tests, so the CI race
job spent ~10 of its ~14.6 minutes re-migrating empty databases.

internal/database/dbtest.InitDB migrates once per test process, then hands
each test its own copy of that file (~130ms under -race) and registers the
CloseDB cleanup. The copy then goes through InitDB like a panel restart, so
every test still starts from the state a fresh install has. Tests that reopen
an existing file, migrate a hand-built legacy DB or target Postgres keep
calling database.InitDB.

Locally under -race: internal/web/service 626s (last CI run) -> 114s,
internal/sub 246s -> 35s.
2026-09-27 03:04:50 +02:00

63 lines
2.2 KiB
Go

package service
import (
"path/filepath"
"testing"
"github.com/mhsanaei/3x-ui/v3/internal/database"
"github.com/mhsanaei/3x-ui/v3/internal/database/dbtest"
"github.com/mhsanaei/3x-ui/v3/internal/database/model"
)
// EffectiveFlowsByEmails resolves intended flow for many clients in one batched
// query, taking the flow_override of the lowest inbound_id and skipping emails
// with no non-empty flow anywhere.
func TestEffectiveFlowsByEmails(t *testing.T) {
dbDir := t.TempDir()
t.Setenv("XUI_DB_FOLDER", dbDir)
dbtest.InitDB(t, filepath.Join(dbDir, "x-ui.db"))
db := database.GetDB()
const vision = "xtls-rprx-vision"
// vis@x: attached to inbound 20 (empty flow) and 10 (Vision) — lowest
// inbound_id (10) wins, so the empty override on 20 must not mask it.
// plain@x: only an empty flow_override anywhere — absent from the result.
mkClient := func(id int, email string) {
if err := db.Create(&model.ClientRecord{Id: id, Email: email, Enable: true}).Error; err != nil {
t.Fatalf("create client %s: %v", email, err)
}
}
mkLink := func(clientID, inboundID int, flow string) {
if err := db.Create(&model.ClientInbound{ClientId: clientID, InboundId: inboundID, FlowOverride: flow}).Error; err != nil {
t.Fatalf("link %d/%d: %v", clientID, inboundID, err)
}
}
mkClient(1, "vis@x")
mkClient(2, "plain@x")
mkLink(1, 20, "") // higher inbound_id, empty
mkLink(1, 10, vision) // lower inbound_id, Vision
mkLink(2, 30, "") // only empty override
cs := &ClientService{}
got, err := cs.EffectiveFlowsByEmails(nil, []string{"vis@x", "plain@x", "missing@x"})
if err != nil {
t.Fatalf("EffectiveFlowsByEmails: %v", err)
}
if got["vis@x"] != vision {
t.Errorf("vis@x = %q, want %q (lowest inbound_id flow_override)", got["vis@x"], vision)
}
if v, ok := got["plain@x"]; ok {
t.Errorf("plain@x present (%q); want absent (no non-empty flow anywhere)", v)
}
if v, ok := got["missing@x"]; ok {
t.Errorf("missing@x present (%q); want absent (unknown client)", v)
}
// Empty input is a no-op (no query).
if m, err := cs.EffectiveFlowsByEmails(nil, nil); err != nil || len(m) != 0 {
t.Errorf("empty input: got %v err %v, want empty map", m, err)
}
}