pjandro/OmniRoute
1
0
Fork 0
mirror of https://github.com/diegosouzapw/OmniRoute.git synced 2026-07-31 04:12:10 +03:00
Code Issues Packages Projects Releases Wiki Activity

fix(oauth): prevent connection test from corrupting valid tokens

Browse Source 
Only attempt token refresh on 401/403 during connection tests when
the token is actually expired (isTokenExpired). Previously, any 401/403
triggered an aggressive refresh that could overwrite valid tokens when
the upstream returned transient errors (rate-limiting, etc.).

Fixes Cline, Qwen, and iFlow losing authentication after tests.
This commit is contained in:
diegosouzapw
2026-02-13 18:09:28 -03:00
parent 3206583299
commit 0af22a558f
1 changed files with 6 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
src/app/api/providers/[id]/test/route.js
View File

@@ -376,11 +376,13 @@ async function testOAuthConnection(connection) {
};
}
// If 401/403 and we haven't tried refresh yet, try refresh now
// (attempt refresh for ANY provider with a refreshToken, not just those marked refreshable)
// If 401/403 and we haven't tried refresh yet, only attempt refresh
// if the token is actually expired. This prevents corrupting valid tokens
// when the upstream returns transient 401/403 errors (rate-limiting, etc.).
if (
(res.status === 401 || res.status === 403) &&
!refreshed &&
isTokenExpired(connection) &&
connection.refreshToken &&
typeof connection.refreshToken === "string"
) {
@@ -405,7 +407,7 @@ async function testOAuthConnection(connection) {
};
}
const error = `API returned ${retryRes.status}`;
const error = `API returned ${retryRes.status} after token refresh`;
return {
valid: false,
error,
@@ -414,7 +416,7 @@ async function testOAuthConnection(connection) {
diagnosis: classifyFailure({ error, statusCode: retryRes.status }),
};
}
const error = "Token invalid or revoked";
const error = "Token expired and refresh failed";
return {
valid: false,
error,