pjandro/OmniRoute
1
0
Fork 0
mirror of https://github.com/diegosouzapw/OmniRoute.git synced 2026-08-14 19:22:32 +03:00
Code Issues Packages Projects Releases Wiki Activity

test(api): align duplicate-builtin catalog expectation with the #10248 overlay contract (#10383)

Browse Source 
#10248 changed the contract: a custom row for an id that already exists is the
operator-owned overlay for that model (catalog.ts:1330) — its explicitly stored fields
win over discovered metadata and the merged entry is flagged `custom`. Before #10248 the
duplicate was skipped, so the test asserted `custom === false` and started failing.

The stale expectation is corrected (not weakened) and an identity assertion is added:
the overlay must keep the catalog id rather than becoming a detached entry.

models-catalog-route.test.ts: 44 pass, 0 fail (was 43 pass / 1 fail).
This commit is contained in:
Diego Rodrigues de Sa e Souza
2026-08-14 10:56:56 -03:00
committed by GitHub
parent f06d5f20ed
commit 0bd2be05e7
1 changed files with 8 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
tests/unit/models-catalog-route.test.ts
View File

@@ -1398,8 +1398,15 @@ test("v1 models catalog skips duplicate built-ins and custom models from inactiv
const duplicateBuiltins = body.data.filter((item) => item.id === "openai/gpt-4o-2024-11-20");
assert.equal(response.status, 200);
// Still exactly one entry: the custom row overlays the built-in, it does not duplicate it.
assert.equal(duplicateBuiltins.length, 1);
assert.equal(duplicateBuiltins[0].custom === true, false);
// #10248 changed the contract: a custom row for an id that already exists is the
// operator-owned overlay for that model (catalog.ts:1330) — its explicitly stored
// fields win over the discovered metadata, and the merged entry is flagged `custom`.
// Before #10248 the duplicate was skipped outright, so this asserted `false`.
assert.equal(duplicateBuiltins[0].custom, true);
// The overlay must keep the catalog identity rather than becoming a detached entry.
assert.equal(duplicateBuiltins[0].id, "openai/gpt-4o-2024-11-20");
assert.equal(
body.data.some((item) => item.id === "cl/inactive-only" || item.id === "cline/inactive-only"),
false