pjandro/OmniRoute
1
0
Fork 0
mirror of https://github.com/diegosouzapw/OmniRoute.git synced 2026-08-01 21:02:12 +03:00
Code Issues Packages Projects Releases Wiki Activity

fix: preserve database data on upgrade when old schema_migrations exists (#146)

Browse Source 
Previously, the upgrade detection logic renamed the entire DB file when it
found a schema_migrations table (from older versions), causing data loss.
Now checks if the DB actually contains data (provider_connections) before
deciding to rename. If data exists, drops only the old migration tracking
table and lets the new CREATE TABLE IF NOT EXISTS schema take over.
This commit is contained in:
diegosouzapw
2026-02-28 00:54:07 -03:00
parent 2c40ef0964
commit 12f7d2b484
1 changed files with 41 additions and 11 deletions
Download Patch File Download Diff File Expand all files Collapse all files

52
src/lib/db/core.ts
View File

@@ -322,28 +322,58 @@ export function getDbInstance() {
return _db;
}
// Detect and replace old incompatible schema
// Detect and handle old schema format — preserve data when possible (#146)
if (fs.existsSync(SQLITE_FILE)) {
try {
const probe = new Database(SQLITE_FILE, { readonly: true });
const hasOldSchema = probe
.prepare("SELECT name FROM sqlite_master WHERE type='table' AND name='schema_migrations'")
.get();
probe.close();
if (hasOldSchema) {
const oldPath = SQLITE_FILE + ".old-schema";
console.log(
`[DB] Old incompatible schema detected — renaming to ${path.basename(oldPath)}`
);
fs.renameSync(SQLITE_FILE, oldPath);
for (const ext of ["-wal", "-shm"]) {
// Check if the DB has actual data we should preserve
let hasData = false;
try {
const count = probe.prepare("SELECT COUNT(*) as c FROM provider_connections").get();
hasData = count && count.c > 0;
} catch {
// Table might not exist at all — truly incompatible
}
probe.close();
if (hasData) {
// Data exists — preserve it! Just drop the old migration tracking table
// and let our new migration system (CREATE TABLE IF NOT EXISTS) take over
console.log(
`[DB] Old schema_migrations table found but data exists — preserving data (#146)`
);
const fixDb = new Database(SQLITE_FILE);
try {
if (fs.existsSync(SQLITE_FILE + ext)) fs.unlinkSync(SQLITE_FILE + ext);
} catch {
/* ok */
fixDb.exec("DROP TABLE IF EXISTS schema_migrations");
// Clean up WAL/SHM files that might be stale
fixDb.pragma("wal_checkpoint(TRUNCATE)");
} catch (e) {
console.warn("[DB] Could not clean up old schema table:", e.message);
} finally {
fixDb.close();
}
} else {
// No data — safe to rename and start fresh
const oldPath = SQLITE_FILE + ".old-schema";
console.log(
`[DB] Old incompatible schema detected (empty) — renaming to ${path.basename(oldPath)}`
);
fs.renameSync(SQLITE_FILE, oldPath);
for (const ext of ["-wal", "-shm"]) {
try {
if (fs.existsSync(SQLITE_FILE + ext)) fs.unlinkSync(SQLITE_FILE + ext);
} catch {
/* ok */
}
}
}
} else {
probe.close();
}
} catch (e) {
console.warn("[DB] Could not probe existing DB, will create fresh:", e.message);