chore(tests): drop explanatory comments on ALL_TARGETS_SKIPPED assertions

Kept the assertion value fix (ALL_ACCOUNTS_INACTIVE -> ALL_TARGETS_SKIPPED); the comments were unnecessary. Reverts the file-size baseline bump these comments caused (combo-routing-engine.test.ts back to its original 3457).
This commit is contained in:
Will Gordon
2026-08-08 09:59:34 -04:00
parent 439854ce65
commit 2c8093f73f
3 changed files with 1 additions and 13 deletions

View File

@@ -1,5 +1,4 @@
{
"_rebaseline_2026_08_08_9619_own_comment_growth": "PR #9619's own follow-up commit (58ab721fe/15b9cb194): tests/unit/combo-routing-engine.test.ts 3457->3464 (+7) is this PR's own growth — explanatory comment blocks added alongside the ALL_ACCOUNTS_INACTIVE->ALL_TARGETS_SKIPPED stale-assertion fix (matching the identical fix applied to #9173/#9006/#8909 the same day; upstream's own test was never updated when the recordedAttempts===0 pre-dispatch-skip branch shipped). Caught by CI's PR-mode check:file-size (--base-ref) after the fix commit; missed locally because check-file-size.mjs was not re-run after that specific edit.",
"_rebaseline_2026_08_07_9619_reconcile_onto_tip": "PR #9619 (fix/basered-changelog-integrity-fabricated-docs) rebase-onto-tip reconciliation. 10 files + 1 test file grew via already-merged release/v3.8.50 PRs since this branch's creation, none touched by this PR's own diff: open-sse/mcp-server/server.ts 1411->1444, open-sse/services/accountFallback.ts 1972->1978, src/app/(dashboard)/dashboard/combos/page.tsx 4647->4703, src/app/(dashboard)/dashboard/providers/[id]/components/modals/EditConnectionModal.tsx 1316->1324, src/app/api/providers/[id]/models/route.ts 2250->2304, src/app/api/v1/models/catalog.ts 1549->1556, src/lib/tokenHealthCheck.ts 1021->1053, src/lib/db/core.ts 1637->1639, src/sse/handlers/chat.ts 1877->1878, tests/unit/translator-openai-to-gemini.test.ts 1619->1622. open-sse/mcp-server/schemas/tools.ts 1505->1553 is new growth not previously tracked. Same root cause as every other entry in this chain: fast-gates PR->release does not run check:file-size. No offending branch left to fix.",
"_rebaseline_2026_08_08_v3850_base_drift_batch_9757": "Base drift on release/v3.8.50, not own growth: the 08-06..08-08 merge batches grew 12 already-frozen (or newly-landed) files without carrying their rebaselines — the dedicated rebaseline PR #9616 was closed as 'superseded' but its file-size entries never actually reached the base, and later merges (#8894 combos page, #9539 EditConnectionModal, #8895 models route, #9294/#9293 catalog, #9541 db/core, #8970 tokenHealthCheck, #8925 mcp schemas+server, #8890 accountFallback, #9467 chat.ts, #8931 openai-to-kiro, ProxyRegistryManager) kept growing them. All 12 values re-measured on THIS branch's tree (= pure tip + this PR's 1-line chat.ts fix, which adds zero lines). This PR's own source changes (chat.ts identifier restore, stream.ts format carve-out) do not grow any frozen file past these values.",
"_rebaseline_2026_08_08_migration_135_collision": "fix(db): resolve migration version 135 numbering collision — #9449's 135_connection_runtime_state.sql and #8908's 135_migrate_model_capability_max_token.sql both claimed version 135 (#9449 branched before #8908 merged and never got renumbered before landing on release/v3.8.50), which threw 'Migration version collision detected' the moment ANY code touched the database — a fresh install/deploy from this tip cannot even boot. Renumbered the later-landing file to 140 (next free slot) and added the matching isSchemaAlreadyApplied('140') retroactive guard, matching the established pattern already used for the prior 135/136 -> 137/138 renumber in the same file. Own growth: src/lib/db/migrationRunner.ts 1084->1094 (+10, the new case block) — irreducible, matches the existing per-case guard pattern exactly. Covered by tests/unit/migration-135-numbering-collision.test.ts (2/2), confirmed failing (reproducing the exact live crash) against the pre-fix colliding filenames, passing after.",
@@ -311,7 +310,7 @@
"tests/unit/cc-compatible-provider.test.ts": 1217,
"tests/unit/chatcore-translation-paths.test.ts": 2876,
"tests/unit/chatgpt-web.test.ts": 3148,
"tests/unit/combo-routing-engine.test.ts": 3464,
"tests/unit/combo-routing-engine.test.ts": 3457,
"tests/unit/db-migration-runner.test.ts": 1499,
"tests/unit/deepseek-web.test.ts": 1092,
"tests/unit/executor-codex.test.ts": 1339,

View File

@@ -2318,10 +2318,6 @@ test("handleComboChat returns a 503 when every model is unavailable before execu
const payload = (await result.json()) as any;
assert.equal(result.status, 503);
// isModelAvailable always false means every target is skipped by the
// pre-dispatch filter with zero dispatch attempts — the more precise
// ALL_TARGETS_SKIPPED classification, not ALL_ACCOUNTS_INACTIVE (which
// implies targets were attempted and their accounts found inactive).
assert.equal(payload.error.code, "ALL_TARGETS_SKIPPED");
});
@@ -2851,9 +2847,6 @@ test("handleComboChat round-robin resolves nested combos and returns inactive wh
const payload = (await result.json()) as any;
assert.equal(result.status, 503);
// isModelAvailable always false means every nested target is skipped by the
// pre-dispatch filter with zero dispatch attempts — ALL_TARGETS_SKIPPED,
// not ALL_ACCOUNTS_INACTIVE (see the analogous priority-strategy test above).
assert.equal(payload.error.code, "ALL_TARGETS_SKIPPED");
});

View File

@@ -148,10 +148,6 @@ test("T24: all inactive accounts return 503 service_unavailable (not 406)", asyn
assert.equal(result.status, 503);
const body = (await result.json()) as any;
// isModelAvailable always false means every target is skipped by the
// pre-dispatch filter with zero dispatch attempts — the more precise
// ALL_TARGETS_SKIPPED classification, not ALL_ACCOUNTS_INACTIVE (which
// implies targets were attempted and their accounts found inactive).
assert.equal(body.error?.code, "ALL_TARGETS_SKIPPED");
});