fix(sse): route claude/<provider>/<model> aliases for catalog-only providers (#9856)

The /v1/models catalog mirrors `claude/<provider>/<model>` ids purely from the
alias gate -- ccAliasPredicate.ts consults no provider registry. The request
path additionally required the prefix to be an open-sse REGISTRY entry or an
operator-defined custom node.

Enterprise-cloud providers such as azure-ai / azure-openai live only in the
provider catalog (src/shared/constants/providers/apikey/enterprise-cloud.ts).
They route fine directly -- `azure-ai/Phi-4` returns 200 -- but have no
open-sse registry entry, so the two sides disagreed: the catalog advertised
`claude/azure-ai/<model>` while stripCcDiscoveryAlias refused to strip it.

The unstripped id then fell through to normal resolution, which splits on the
first / and parsed `claude` as the provider. Every Claude Code request for an
Azure model was routed to the Claude provider instead:

  ROUTING: Provider: claude, Model: azure-ai/DeepSeek-V4-Flash

Extract the predicate as `isRoutableProviderPrefix()` and widen it to the
provider catalog (id + alias) alongside the open-sse registry, so the request
path recognises exactly what the catalog can advertise.

Regression guard: tests/unit/cc-discovery-alias-routable-prefix.test.ts pins
azure-ai/azure-openai/azure as routable, keeps openai/anthropic routable, and
keeps an unknown prefix non-routable. Verified failing before the widening.

Co-authored-by: Mihaly Bodo <michael@proton-quantum.com>
This commit is contained in:
Diego Rodrigues de Sa e Souza
2026-08-09 09:52:28 -03:00
committed by GitHub
parent a102a2d773
commit 332c738844
2 changed files with 61 additions and 1 deletions

View File

@@ -20,6 +20,7 @@ import {
} from "@omniroute/open-sse/handlers/chatCore/ccDiscoveryAliasStrip.ts";
import { getModelsByProviderId } from "@omniroute/open-sse/config/providerModels.ts";
import { getRegistryEntry } from "@omniroute/open-sse/config/providerRegistry.ts";
import { getProviderById, getProviderByAlias } from "@/shared/constants/providers";
import { getCachedProviderNodes } from "@/lib/db/readCache";
import { getComboByName } from "@/lib/db/combos";
import {
@@ -136,6 +137,22 @@ export async function resolveCcDiscoveryAliasStripWith(
});
}
/**
* True when `prefix` names a provider the router can actually reach.
*
* Deliberately broader than the `open-sse` REGISTRY alone: enterprise-cloud
* providers such as `azure-ai` / `azure-openai` live only in the provider
* CATALOG (src/shared/constants/providers/…) yet route fine, so a registry-only
* check made the request path reject `claude/azure-ai/<model>` ids that the
* catalog had already advertised — see cc-discovery-alias-routable-prefix.test.ts.
*/
export function isRoutableProviderPrefix(prefix: string): boolean {
if (!prefix) return false;
if (getRegistryEntry(prefix) !== null) return true;
if (getProviderById(prefix) !== undefined) return true;
return getProviderByAlias(prefix) !== null;
}
/**
* Production entry point: build the real lookups and resolve. Cheap-exit for any
* id that does not start with `claude/` (the overwhelmingly common case) so a
@@ -169,7 +186,7 @@ export async function resolveCcDiscoveryAliasStrip(
const result = await resolveCcDiscoveryAliasStripWith(modelStr, {
claudeModelIds,
isRegistryProvider: (prefix) => getRegistryEntry(prefix) !== null,
isRegistryProvider: (prefix) => isRoutableProviderPrefix(prefix),
customProviderPrefixes,
getCombo: (name) => getComboByName(name),
gateGlobal: () => globalEnabled,

View File

@@ -0,0 +1,43 @@
import { test } from "node:test";
import assert from "node:assert/strict";
import { isRoutableProviderPrefix } from "../../src/lib/ccDiscoveryAliasResolve.ts";
/**
* Regression guard for the "listed but rejected" cc-discovery alias mismatch.
*
* The /v1/models catalog mirrors `claude/<provider>/<model>` ids based purely on
* the alias gate (src/app/api/v1/models/ccAliasPredicate.ts — it does NOT consult
* any provider registry). The request path additionally required the prefix to be
* an `open-sse` REGISTRY entry or an operator-defined custom node.
*
* Enterprise-cloud providers such as `azure-ai` / `azure-openai` live in the
* provider CATALOG (src/shared/constants/providers/apikey/enterprise-cloud.ts)
* and route fine directly (`azure-ai/Phi-4` → 200), but have no `open-sse`
* registry entry. So the catalog advertised `claude/azure-ai/<model>` while the
* request path refused to strip it — the id fell through with `claude` parsed as
* the provider, and every request was routed to the Claude provider instead.
*
* These assertions pin the predicate to "can the router actually reach it",
* which is the property the catalog side already assumes.
*/
test("catalog-only enterprise-cloud providers are routable (azure-ai regression)", () => {
assert.equal(isRoutableProviderPrefix("azure-ai"), true);
assert.equal(isRoutableProviderPrefix("azure-openai"), true);
});
test("open-sse registry providers stay routable", () => {
assert.equal(isRoutableProviderPrefix("openai"), true);
assert.equal(isRoutableProviderPrefix("anthropic"), true);
});
test("provider aliases resolve too", () => {
// `azure` is the declared alias of the `azure-openai` catalog entry.
assert.equal(isRoutableProviderPrefix("azure"), true);
});
test("an unknown prefix is not routable", () => {
assert.equal(isRoutableProviderPrefix("definitely-not-a-provider-xyz"), false);
assert.equal(isRoutableProviderPrefix(""), false);
});