pjandro/OmniRoute
1
0
Fork 0
mirror of https://github.com/diegosouzapw/OmniRoute.git synced 2026-08-18 21:22:28 +03:00
Code Issues Packages Projects Releases Wiki Activity

fix(combo): resolve nativeCodexTurnPin type error and connection-pin gap

Browse Source 
PR #10573 landed with two real defects surfaced by typecheck/tests on
the combined release tip:

- TS2322: allowedConnectionIds (string[]) was built from
  compatible.map(t => t.connectionId), whose type includes null.
  Filter nulls before assigning.
- applyNativeCodexTurnPin never assigned the pinned connectionId onto
  a compatible candidate that didn't already carry it (e.g. an
  unresolved placeholder target with connectionId: null) — the pin
  was silently dropped instead of applied. Now resolves the pinned
  slot's connectionId explicitly (in original order, so
  allowedConnectionIds stays consistent regardless of pinned-first
  reordering) before building the returned target list.

Confirmed via the existing focused suites:
tests/unit/chatgpt-web-codex-turn-pin.test.ts and
tests/unit/native-codex-turn-pin-10379.test.ts (14/14 pass),
typecheck:core clean.
This commit is contained in:
adevwithpurpose
2026-08-18 11:14:01 -03:00
parent fd76271515
commit 3cab6dc9f0
1 changed files with 19 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

23
open-sse/services/combo/nativeCodexTurnPin.ts
View File

@@ -112,16 +112,31 @@ export function applyNativeCodexTurnPin(
);
if (compatible.length === 0) return [];
const pinned = compatible.find((t) => t.connectionId === pin.connectionId);
const siblings = compatible.filter((t) => t.connectionId !== pin.connectionId);
let pinnedIndex = compatible.findIndex((t) => t.connectionId === pin.connectionId);
// No candidate already carries the pinned connectionId (e.g. the caller
// resolved the target before a connection was assigned) — assign the pin
// onto the first compatible candidate so dispatch targets it directly.
if (pinnedIndex < 0) pinnedIndex = 0;
// Resolve the pinned slot's connectionId in ORIGINAL order first, so
// allowedConnectionIds reflects the same set/order regardless of which
// candidate ends up first in the returned (pinned-first) array.
const resolved = compatible.map((t, i) =>
i === pinnedIndex ? { ...t, connectionId: pin.connectionId } : t
);
const allowedConnectionIds = resolved
.map((t) => t.connectionId)
.filter((id): id is string => id !== null);
// Pinned connection first, then same-provider/model siblings as fallback
const ordered = pinned ? [pinned, ...siblings] : compatible;
const pinned = resolved[pinnedIndex];
const siblings = resolved.filter((_, i) => i !== pinnedIndex);
const ordered = [pinned, ...siblings];
return ordered.map((target) => ({
...target,
// Allow only connections for the pinned provider+model
allowedConnectionIds: compatible.map((t) => t.connectionId),
allowedConnectionIds,
}));
}