mirror of
https://github.com/diegosouzapw/OmniRoute.git
synced 2026-09-08 07:52:12 +03:00
fix(release): never let the tag-push Create Release append auto notes to the curated body (#12096)
Phase 3 creates the GitHub Release with the curated notes right after the tag push, so softprops always finds an existing body; generate_release_notes must be false on every event, not only on workflow_dispatch (v3.8.48 shipped with the auto block appended; the body sits ~3 KB under the 125,000-char cap). Same hunk as main (#12086); the #12085 squash did not carry it. Refs #12084
This commit is contained in:
committed by
GitHub
parent
79b2e92c4e
commit
41f4f83772
12
.github/workflows/electron-release.yml
vendored
12
.github/workflows/electron-release.yml
vendored
@@ -413,10 +413,14 @@ jobs:
|
||||
tag_name: ${{ needs.validate.outputs.version }}
|
||||
draft: false
|
||||
prerelease: false
|
||||
# Only on the tag push. A re-attach dispatch runs against a release whose curated
|
||||
# notes already exist, and `true` APPENDS GitHub's auto-generated "What's Changed"
|
||||
# block to them (v3.8.50, run 33238093090: +1,416 chars on a 121 KB body).
|
||||
generate_release_notes: ${{ github.event_name != 'workflow_dispatch' }}
|
||||
# NEVER. Phase 3 of the release flow creates the GitHub Release with the curated
|
||||
# notes seconds after pushing the tag, so by the time this step runs (1-2 h of
|
||||
# builds later) the body already exists — and `true` APPENDS GitHub's
|
||||
# auto-generated "What's Changed" block to it (v3.8.48 shipped that way; the
|
||||
# v3.8.50 re-attach dispatch added +1,416 chars to a 121 KB body, run
|
||||
# 33238093090). A curated body sits ~3 KB under the 125,000-char cap, so the
|
||||
# append can also turn this step RED and leave the release with no assets.
|
||||
generate_release_notes: false
|
||||
fail_on_unmatched_files: false
|
||||
files: |
|
||||
release-assets/*.dmg
|
||||
|
||||
Reference in New Issue
Block a user