pjandro/OmniRoute
1
0
Fork 0
mirror of https://github.com/diegosouzapw/OmniRoute.git synced 2026-08-05 06:42:12 +03:00
Code Issues Packages Projects Releases Wiki Activity

fix(sse): export PROVIDER_BREAKER_FAILURE_STATUSES — fix ReferenceError in chat.ts (base-red slice 4) (#8258)

Browse Source 
* fix(sse): export PROVIDER_BREAKER_FAILURE_STATUSES so chat.ts stops throwing ReferenceError

Base-red slice 4 (single root cause across the whole handleChat cluster).

src/sse/handlers/chat.ts:1273 references PROVIDER_BREAKER_FAILURE_STATUSES to decide
whether an all-rate-limited provider result should trip the provider breaker, but the
constant was only a FILE-LOCAL const in chatPredicates.ts (a refactor extracted it out
of chat.ts and never re-exported it). Every request that reached that branch threw
`ReferenceError: PROVIDER_BREAKER_FAILURE_STATUSES is not defined`, so the global
fallback and breaker-gate paths blew up — surfacing as "All models failed |
PROVIDER_BREAKER_FAILURE_STATUSES is not defined" and breaking the handleChat coverage
tests (combo-error passthrough, 503 for cooled-down/open-breaker, budget-error, model
cooldown, body-derived retry-after, non-JSON rate-limit bodies).

Fix: export the const from chatPredicates.ts and import it in chat.ts (one canonical
definition, restoring the pre-refactor behavior).

Validated: chat-route-coverage 15/0 (was 12/3), chat-cooldown-aware-retry 6/0,
chat-rate-limit-body-lock 2/0; breaker guards (7907, combo-breaker-429, openrouter-6842)
unchanged; typecheck:core clean.

* test(nvidia): read PROVIDER_BREAKER_FAILURE_STATUSES from chatPredicates.ts

Same root cause as the chat.ts import fix in this PR: the const was extracted out
of chat.ts into chatPredicates.ts, so the nvidia-quota Phase-1 guard (which greps
the source for the `= new Set([...])` declaration to prove 429 was not added to the
breaker classification) must read chatPredicates.ts, not chat.ts. Now 13/0.

---------

Co-authored-by: Probe Test <probe@example.com>
This commit is contained in:
Diego Rodrigues de Sa e Souza
2026-07-26 12:11:42 -03:00
committed by GitHub
parent e4cd478f97
commit 4cd1bbc9f5
2 changed files with 9 additions and 11 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
src/sse/handlers/chat.ts
View File

@@ -77,6 +77,7 @@ import {
isAntigravityMissingProjectError,
PROVIDER_BREAKER_FAILURE_STATUSES,
shouldTripProviderBreakerForResult,
PROVIDER_BREAKER_FAILURE_STATUSES,
} from "./chatPredicates";
import { connectionHasExtraKeys } from "@omniroute/open-sse/services/apiKeyRotator.ts";
import {

19
tests/unit/nvidia-quota-phase1.test.ts
View File

@@ -189,7 +189,11 @@ test("getProviderConcurrencyCap resolves override -> static default -> fallback"
);
setProviderQuotaOverrides({ nvidia: { concurrency: 3 } });
try {
assert.equal(getProviderConcurrencyCap("nvidia", 99), 3, "override wins over the static default");
assert.equal(
getProviderConcurrencyCap("nvidia", 99),
3,
"override wins over the static default"
);
} finally {
setProviderQuotaOverrides(null);
}
@@ -218,16 +222,9 @@ test("nvidia 429 does not trip the provider circuit breaker (unchanged 408/500/5
// documentation-alignment guard proving Phase 1 didn't accidentally widen
// PROVIDER_BREAKER_FAILURE_STATUSES to include 429 (which would collapse the
// per-model lockout this PR adds into a whole-connection/provider outage).
// #8013 extracted the const from src/sse/handlers/chat.ts into chatPredicates.ts
// (still consumed by chat.ts's breaker paths) — read the declaration from its
// current home.
const chatHandlerPath = path.join(
process.cwd(),
"src",
"sse",
"handlers",
"chatPredicates.ts"
);
// The PROVIDER_BREAKER_FAILURE_STATUSES declaration was extracted from chat.ts into
// the sibling chatPredicates.ts (chat.ts now imports it); read it from its home.
const chatHandlerPath = path.join(process.cwd(), "src", "sse", "handlers", "chatPredicates.ts");
const source = fs.readFileSync(chatHandlerPath, "utf8");
const match = source.match(/PROVIDER_BREAKER_FAILURE_STATUSES\s*=\s*new Set\(\[([^\]]+)\]\)/);
assert.ok(match, "PROVIDER_BREAKER_FAILURE_STATUSES declaration found");