chore(quality): clear the ESLint errors the 2026-09-11 batch introduced

Two regressions landed with the HouMinXi batch and were not caught by the
consolidated validation, which ran typecheck, complexity, file-size, docs
and the focused tests but not ESLint over the changed files:

- tests/unit/combo-test-route.test.ts carried 11 `as any` casts on
  `response.json()` (#13001), 10 of them behind a suppressions entry. The
  bodies now have real types matching this suite's existing convention, and
  the suppression entry is gone rather than re-counted.
- open-sse/handlers/chatCore.ts imported `hasPerModelQuota` that nothing
  uses any more after #13069 moved the classification into its own helper.

ESLint exits 0 on both files, combo-test-route is 10/10, and the five
chatCore-adjacent suites are 29/29.

changelog.d/maintenance/13001-13069-eslint-regressions.md

@@ -0,0 +1 @@
+- **chore(quality):** type the combo-test route's JSON response bodies instead of casting them to `any`, drop the now-empty suppression entry, and remove the `hasPerModelQuota` import `chatCore.ts` stopped using when the failure-classification helper was extracted

config/quality/eslint-suppressions.json

@@ -3378,11 +3378,6 @@
       "count": 2
     }
   },
-  "tests/unit/combo-test-route.test.ts": {
-    "@typescript-eslint/no-explicit-any": {
-      "count": 10
-    }
-  },
   "tests/unit/combos-duplicate-resolution-audit.test.ts": {
     "@typescript-eslint/no-unused-vars": {
       "count": 1

open-sse/handlers/chatCore.ts

@@ -365,7 +365,6 @@ import {
 import {
   lockModel,
   lockModelIfPerModelQuota,
-  hasPerModelQuota,
   recordCoreOwnedAntigravityQuotaState,
   shouldDeferAntigravityQuotaStateToCaller,
 } from "../services/accountFallback.ts";

tests/unit/combo-test-route.test.ts

@@ -4,6 +4,25 @@ import fs from "node:fs";
 import os from "node:os";
 import path from "node:path";
 
+type ComboTestResult = {
+  label?: string;
+  status?: string;
+  statusCode?: number;
+  responseText?: string;
+  error?: string;
+  connectionId?: string | null;
+  executionKey?: string | null;
+};
+type ComboTestBody = {
+  model?: string;
+  resolvedBy?: string | null;
+  resolvedByExecutionKey?: string | null;
+  resolvedByTarget?: { connectionId?: string | null } | null;
+  results: ComboTestResult[];
+};
+type ErrorMessageBody = { error: { message: string } };
+type ErrorStringBody = { error: string };
+
 const TEST_DATA_DIR = fs.mkdtempSync(path.join(os.tmpdir(), "omniroute-combo-test-route-"));
 process.env.DATA_DIR = TEST_DATA_DIR;
 process.env.API_KEY_SECRET = process.env.API_KEY_SECRET || "combo-test-route-secret";
@@ -82,12 +101,12 @@ test("combo test route validates request payloads and combo existence", async ()
       body: JSON.stringify({ comboName: "" }),
     })
   );
-  const invalidBody = (await invalidBodyResponse.json()) as any;
+  const invalidBody = (await invalidBodyResponse.json()) as ErrorMessageBody;
   assert.equal(invalidBodyResponse.status, 400);
   assert.equal(invalidBody.error.message, "Invalid request");
 
   const missingResponse = await route.POST(makeRequest("missing-combo"));
-  const missingBody = (await missingResponse.json()) as any;
+  const missingBody = (await missingResponse.json()) as ErrorStringBody;
   assert.equal(missingResponse.status, 404);
   assert.equal(missingBody.error, "Combo not found");
 });
@@ -117,7 +136,7 @@ test("combo test route marks a model healthy only when it returns assistant text
   };
 
   const response = await route.POST(makeRequest());
-  const body = (await response.json()) as any;
+  const body = (await response.json()) as ComboTestBody;
   const forwardedBody = JSON.parse(fetchCalls[0].init.body);
 
   assert.equal(response.status, 200);
@@ -157,7 +176,7 @@ test("combo test route treats empty successful responses as failures", async ()
     );
 
   const response = await route.POST(makeRequest());
-  const body = (await response.json()) as any;
+  const body = (await response.json()) as ComboTestBody;
 
   assert.equal(response.status, 200);
   assert.equal(body.resolvedBy, null);
@@ -197,7 +216,7 @@ test("combo test route accepts reasoning-only completions as healthy smoke-test
     );
 
   const response = await route.POST(makeRequest());
-  const body = (await response.json()) as any;
+  const body = (await response.json()) as ComboTestBody;
 
   assert.equal(response.status, 200);
   assert.equal(body.resolvedBy, "openrouter/openai/gpt-5.4");
@@ -222,7 +241,7 @@ test("combo test route surfaces provider errors instead of downgrading them to r
     );
 
   const response = await route.POST(makeRequest());
-  const body = (await response.json()) as any;
+  const body = (await response.json()) as ComboTestBody;
 
   assert.equal(response.status, 200);
   assert.equal(body.resolvedBy, null);
@@ -255,7 +274,7 @@ test("combo test route probes combo steps sequentially while preserving combo or
   };
 
   const response = await route.POST(makeRequest());
-  const body = (await response.json()) as any;
+  const body = (await response.json()) as ComboTestBody;
 
   assert.equal(response.status, 200);
   assert.equal(maxInFlight, 1);
@@ -320,7 +339,7 @@ test("combo test route preserves structured step metadata for repeated model/acc
   };
 
   const response = await route.POST(makeRequest());
-  const body = (await response.json()) as any;
+  const body = (await response.json()) as ComboTestBody;
 
   assert.equal(response.status, 200);
   assert.equal(fetchCalls.length, 2);
@@ -343,7 +362,7 @@ test("combo test route rejects empty combos and ignores forwarded origins for in
   await createTestCombo([]);
 
   const emptyResponse = await route.POST(makeRequest());
-  const emptyBody = (await emptyResponse.json()) as any;
+  const emptyBody = (await emptyResponse.json()) as ErrorStringBody;
   assert.equal(emptyResponse.status, 400);
   assert.equal(emptyBody.error, "Combo has no models");
 
@@ -403,7 +422,7 @@ test("combo test route handles upstream timeouts and non-JSON error bodies", asy
   };
 
   const response = await route.POST(makeRequest());
-  const body = (await response.json()) as any;
+  const body = (await response.json()) as ComboTestBody;
 
   assert.equal(response.status, 200);
   assert.equal(body.resolvedBy, null);
@@ -450,7 +469,7 @@ test("combo test route stops probing once the total budget is spent", async () =
 
   try {
     const response = await route.POST(makeRequest());
-    const body = (await response.json()) as any;
+    const body = (await response.json()) as ComboTestBody;
 
     assert.equal(response.status, 200);
     assert.deepEqual(probed, ["provider/first"]);