pjandro/OmniRoute
1
0
Fork 0
mirror of https://github.com/diegosouzapw/OmniRoute.git synced 2026-08-17 04:32:31 +03:00
Code Issues Packages Projects Releases Wiki Activity

refactor(db): extract tri-state override helper to keep the complexity ratchet at baseline

Browse Source 
The #1904 supportsVision override added a second copy of the "absent keeps /
null clears / else coerce" block already used by preserveOpenAIDeveloperRole,
pushing updateCustomModel to 84 lines and check:complexity to 2057 > 2056.

The file-size failure was masking this one: the gate exits on its first red,
so complexity never ran until providerPageHelpers was back under its cap.

Fold both blocks into applyTriStateBooleanOverride(). Behavior is unchanged —
updateCustomModel is back under max-lines-per-function and the global count
returns to the 2056 baseline (cognitive-complexity stays at 890).
This commit is contained in:
Diego Rodrigues de Sa e Souza
2026-07-14 22:09:22 -03:00
parent b259db245c
commit 92a9de8fa0
1 changed files with 22 additions and 17 deletions
Download Patch File Download Diff File Expand all files Collapse all files

39
src/lib/db/models.ts
View File

@@ -592,6 +592,25 @@ export async function pruneStaleSyncedAvailableModelsForProvider(
return Number(result.changes || 0);
}
/**
* Apply a tri-state boolean override from `updates` onto `next`:
* field absent → keep whatever `next` already carries; explicit `null` → clear
* the override (callers fall back to their heuristic); anything else → persist
* the coerced boolean.
*/
function applyTriStateBooleanOverride(
next: JsonRecord,
updates: Record<string, unknown>,
field: string
): void {
if (!Object.prototype.hasOwnProperty.call(updates, field)) return;
if (updates[field] === null) {
delete next[field];
return;
}
next[field] = Boolean(updates[field]);
}
export async function updateCustomModel(
providerId: string,
modelId: string,
@@ -641,24 +660,10 @@ export async function updateCustomModel(
: {}),
...(updates.isHidden !== undefined ? { isHidden: Boolean(updates.isHidden) } : {}),
};
if (Object.prototype.hasOwnProperty.call(updates, "preserveOpenAIDeveloperRole")) {
if (updates.preserveOpenAIDeveloperRole === null) {
delete next.preserveOpenAIDeveloperRole;
} else {
next.preserveOpenAIDeveloperRole = Boolean(updates.preserveOpenAIDeveloperRole);
}
}
applyTriStateBooleanOverride(next, updates, "preserveOpenAIDeveloperRole");
// #1904: manual vision-capability override — `null` clears back to the
// id-based heuristic in getCustomVisionCapabilityFields(); true/false persists
// an explicit override so self-hosted backends that don't self-report an
// image modality can still be flagged vision-capable (or downgraded).
if (Object.prototype.hasOwnProperty.call(updates, "supportsVision")) {
if (updates.supportsVision === null) {
delete next.supportsVision;
} else {
next.supportsVision = Boolean(updates.supportsVision);
}
}
// id-based heuristic in getCustomVisionCapabilityFields().
applyTriStateBooleanOverride(next, updates, "supportsVision");
if (updates.compatByProtocol !== undefined) {
if (mergedCompat && compatByProtocolHasEntries(mergedCompat)) {
next.compatByProtocol = mergedCompat;