pjandro/OmniRoute
1
0
Fork 0
mirror of https://github.com/diegosouzapw/OmniRoute.git synced 2026-08-11 09:42:15 +03:00
Code Issues Packages Projects Releases Wiki Activity

chore(tests): drop explanatory comments on ALL_TARGETS_SKIPPED assertions

Browse Source 
Kept the assertion value fix (ALL_ACCOUNTS_INACTIVE -> ALL_TARGETS_SKIPPED); the comments were unnecessary. Reverts the file-size baseline bump these comments caused (combo-routing-engine.test.ts back to its original 3457).
This commit is contained in:
Will Gordon
2026-08-08 09:59:34 -04:00
committed by diegosouzapw
parent fa5d96388b
commit ab5939ec9f
3 changed files with 1 additions and 12 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
config/quality/file-size-baseline.json
View File

@@ -185,7 +185,7 @@
"tests/unit/cc-compatible-provider.test.ts": 1217,
"tests/unit/chatcore-translation-paths.test.ts": 2876,
"tests/unit/chatgpt-web.test.ts": 3148,
"tests/unit/combo-routing-engine.test.ts": 3464,
"tests/unit/combo-routing-engine.test.ts": 3457,
"tests/unit/db-migration-runner.test.ts": 1499,
"tests/unit/deepseek-web.test.ts": 1092,
"tests/unit/executor-codex.test.ts": 1339,

7
tests/unit/combo-routing-engine.test.ts
View File

@@ -2318,10 +2318,6 @@ test("handleComboChat returns a 503 when every model is unavailable before execu
const payload = (await result.json()) as any;
assert.equal(result.status, 503);
// isModelAvailable always false means every target is skipped by the
// pre-dispatch filter with zero dispatch attempts — the more precise
// ALL_TARGETS_SKIPPED classification, not ALL_ACCOUNTS_INACTIVE (which
// implies targets were attempted and their accounts found inactive).
assert.equal(payload.error.code, "ALL_TARGETS_SKIPPED");
});
@@ -2851,9 +2847,6 @@ test("handleComboChat round-robin resolves nested combos and returns inactive wh
const payload = (await result.json()) as any;
assert.equal(result.status, 503);
// isModelAvailable always false means every nested target is skipped by the
// pre-dispatch filter with zero dispatch attempts — ALL_TARGETS_SKIPPED,
// not ALL_ACCOUNTS_INACTIVE (see the analogous priority-strategy test above).
assert.equal(payload.error.code, "ALL_TARGETS_SKIPPED");
});

4
tests/unit/t23-t24-fallback-resilience.test.ts
View File

@@ -148,10 +148,6 @@ test("T24: all inactive accounts return 503 service_unavailable (not 406)", asyn
assert.equal(result.status, 503);
const body = (await result.json()) as any;
// isModelAvailable always false means every target is skipped by the
// pre-dispatch filter with zero dispatch attempts — the more precise
// ALL_TARGETS_SKIPPED classification, not ALL_ACCOUNTS_INACTIVE (which
// implies targets were attempted and their accounts found inactive).
assert.equal(body.error?.code, "ALL_TARGETS_SKIPPED");
});