pjandro/OmniRoute
1
0
Fork 0
mirror of https://github.com/diegosouzapw/OmniRoute.git synced 2026-08-05 14:52:09 +03:00
Code Issues Packages Projects Releases Wiki Activity

address review: exclude arrays from reasoning check + hoist regex constants

Browse Source 
Per gemini-code-assist review on #2162:
- Add `!Array.isArray(b.reasoning)` guard so spread of array-typed
  reasoning doesn't pollute the body with numeric-keyed entries
- Hoist /devstral/i and /(claude|haiku|oswe)/i to module-level
  MISTRAL_NO_REASONING_EFFORT_PATTERN and
  GITHUB_NO_REASONING_EFFORT_PATTERN constants to avoid per-call
  RegExp construction
This commit is contained in:
OmniRoute Ops
2026-05-11 16:24:05 +00:00
parent 21ca713af4
commit c83792a8cd
1 changed files with 5 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
open-sse/executors/base.ts
View File

@@ -190,6 +190,8 @@ export function mergeAbortSignals(primary: AbortSignal, secondary: AbortSignal):
* Models that genuinely support xhigh (registry flag supportsXHighEffort)
* pass through unchanged.
*/
const MISTRAL_NO_REASONING_EFFORT_PATTERN = /devstral/i;
const GITHUB_NO_REASONING_EFFORT_PATTERN = /(claude|haiku|oswe)/i;
export function sanitizeReasoningEffortForProvider(
body: unknown,
provider: string,
@@ -199,7 +201,7 @@ export function sanitizeReasoningEffortForProvider(
if (!body || typeof body !== "object" || Array.isArray(body)) return body;
const b = body as Record<string, unknown>;
const reasoning =
b.reasoning && typeof b.reasoning === "object"
b.reasoning && typeof b.reasoning === "object" && !Array.isArray(b.reasoning)
? (b.reasoning as Record<string, unknown>)
: null;
const effort = b.reasoning_effort ?? reasoning?.effort;
@@ -220,8 +222,8 @@ export function sanitizeReasoningEffortForProvider(
}
const rejecting =
(provider === "mistral" && /devstral/i.test(modelStr)) ||
(provider === "github" && /(claude|haiku|oswe)/i.test(modelStr));
(provider === "mistral" && MISTRAL_NO_REASONING_EFFORT_PATTERN.test(modelStr)) ||
(provider === "github" && GITHUB_NO_REASONING_EFFORT_PATTERN.test(modelStr));
if (rejecting) {
log?.info?.(
"REASONING_SANITIZE",