pjandro/OmniRoute
1
0
Fork 0
mirror of https://github.com/diegosouzapw/OmniRoute.git synced 2026-07-31 04:12:10 +03:00
Code Issues Packages Projects Releases Wiki Activity

fix(cli-tools): preserve TOML integer/boolean types in Codex config round-trip

Browse Source 
The parseToml function was stripping all value quotes uniformly, turning
every value into a JS string. When toToml re-serialized, unquoted
integers like 2 were wrapped in quotes becoming "2" — a TOML string.

This broke Codex CLI which expects u32 for tui.model_availability_nux:
  Error loading config.toml: invalid type: string "2", expected u32

Now parseToml detects booleans (true/false), integers, and floats,
preserving their native JS types. formatTomlValue already handles
number/boolean types correctly, so round-tripping no longer corrupts
third-party config sections.
This commit is contained in:
diegosouzapw
2026-04-25 22:47:20 -03:00
parent 1e9e6d4349
commit df76aaef96
1 changed files with 21 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

29
src/app/api/cli-tools/codex-settings/route.ts
View File

@@ -40,7 +40,7 @@ const parseToml = (content: string) => {
const kvMatch = trimmed.match(/^([^=]+)\s*=\s*(.+)$/);
if (kvMatch) {
let key = kvMatch[1].trim();
let value = kvMatch[2].trim();
const rawValue = kvMatch[2].trim();
// Strip quotes from key (TOML quoted keys like "gpt-5.3-codex")
if (
(key.startsWith('"') && key.endsWith('"')) ||
@@ -48,17 +48,30 @@ const parseToml = (content: string) => {
) {
key = key.slice(1, -1);
}
// Remove quotes from string values only (not arrays, booleans, numbers)
if (
(value.startsWith('"') && value.endsWith('"')) ||
(value.startsWith("'") && value.endsWith("'"))
// Parse value preserving TOML types (integers, floats, booleans)
let parsedValue: string | number | boolean = rawValue;
if (rawValue === "true") {
parsedValue = true;
} else if (rawValue === "false") {
parsedValue = false;
} else if (
(rawValue.startsWith('"') && rawValue.endsWith('"')) ||
(rawValue.startsWith("'") && rawValue.endsWith("'"))
) {
value = value.slice(1, -1);
// Quoted string — strip quotes, keep as string
parsedValue = rawValue.slice(1, -1);
} else if (/^-?\d+$/.test(rawValue)) {
// Integer literal (unquoted)
parsedValue = parseInt(rawValue, 10);
} else if (/^-?\d+\.\d+$/.test(rawValue)) {
// Float literal (unquoted)
parsedValue = parseFloat(rawValue);
}
// Arrays and other complex values stay as raw strings
if (currentSection === "_root") {
result._root[key] = value;
result._root[key] = parsedValue;
} else {
result._sections[currentSection][key] = value;
result._sections[currentSection][key] = parsedValue;
}
}
});