pjandro/OmniRoute
1
0
Fork 0
mirror of https://github.com/diegosouzapw/OmniRoute.git synced 2026-08-19 21:52:21 +03:00
Code Issues Packages Projects Releases Wiki Activity

Potential fix for code scanning alert no. 54: Insecure randomness

Browse Source 
Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
This commit is contained in:
Diego Rodrigues de Sa e Souza
2026-03-05 08:41:44 -03:00
committed by GitHub
parent 751ff77b7c
commit e78ede45b6
1 changed files with 5 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
open-sse/services/accountSelector.ts
View File

@@ -6,6 +6,7 @@
*/
import { getAccountHealth } from "./accountFallback.ts";
import crypto from "crypto";
/**
* P2C selection: pick 2 random candidates, return the healthier one.
@@ -19,9 +20,9 @@ export function selectAccountP2C(accounts, model = null) {
if (!accounts || accounts.length === 0) return null;
if (accounts.length === 1) return accounts[0];
// Pick 2 random distinct indices
const i = Math.floor(Math.random() * accounts.length);
let j = Math.floor(Math.random() * (accounts.length - 1));
// Pick 2 random distinct indices (cryptographically secure)
const i = crypto.randomInt(accounts.length);
let j = crypto.randomInt(accounts.length - 1);
if (j >= i) j++; // Ensure distinct
const a = accounts[i];
@@ -59,7 +60,7 @@ export function selectAccount(
case "random":
return {
account: accounts[Math.floor(Math.random() * accounts.length)],
account: accounts[crypto.randomInt(accounts.length)],
state,
};