pjandro/OmniRoute
1
0
Fork 0
mirror of https://github.com/diegosouzapw/OmniRoute.git synced 2026-07-31 04:12:10 +03:00
Code Issues Packages Projects Releases Wiki Activity

fix(compression): allow enginesExplicit through PUT validation schema (#4532)

Browse Source 
Adds enginesExplicit to the strict compression PUT schema so the panel can save without a 400. Kept only this commit; the Hub-render commit was superseded by Phase 2 (#4521) which rewrote CompressionHub.tsx. Does not reopen the Phase 1 gate (enginesExplicit is recomputed from stored engines, the persisted row is ignored). Tested.

Integrated into release/v3.8.33.
This commit is contained in:
Ronald Estacion
2026-06-21 11:44:22 -07:00
committed by GitHub
parent 4d3a9fd3df
commit eb47b92f22
2 changed files with 20 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
src/shared/validation/compressionConfigSchemas.ts
View File

@@ -195,6 +195,7 @@ export const compressionSettingsUpdateSchema = z
ultra: ultraConfigSchema.optional(),
contextEditing: contextEditingConfigSchema.optional(),
engines: z.record(z.string(), engineToggleSchema).optional(),
enginesExplicit: z.boolean().optional(),
activeComboId: z.string().nullable().optional(),
})
.strict();

28
tests/unit/api/compression/compression-api.test.ts
View File

@@ -158,11 +158,7 @@ describe("settings/compression route — engines + activeComboId", () => {
assert.equal(getRes.status, 200);
const body = await getRes.json();
assert.equal(
body.engines?.rtk?.enabled,
true,
"engines.rtk.enabled should be true after PUT"
);
assert.equal(body.engines?.rtk?.enabled, true, "engines.rtk.enabled should be true after PUT");
assert.equal(
body.engines?.rtk?.level,
"standard",
@@ -199,15 +195,29 @@ describe("settings/compression route — engines + activeComboId", () => {
it("PUT with invalid engines shape is rejected by schema validation (400)", async () => {
// engines values must have an `enabled` boolean — passing a string should fail the schema.
const putRes = await route.PUT(
makeRequest("PUT", { engines: { rtk: { enabled: "yes" } } })
);
const putRes = await route.PUT(makeRequest("PUT", { engines: { rtk: { enabled: "yes" } } }));
assert.equal(putRes.status, 400);
const body = await putRes.json();
// Validation failures use { error: { message, details } } via validateBody helper.
assert.ok(body.error !== null && typeof body.error === "object", "error should be an object");
const errorMessage: string =
typeof body.error === "string" ? body.error : (body.error?.message ?? JSON.stringify(body.error));
typeof body.error === "string"
? body.error
: (body.error?.message ?? JSON.stringify(body.error));
assert.ok(!errorMessage.includes("at /"), "error must not contain a stack trace");
});
it("PUT accepts enginesExplicit (round-tripped from GET response)", async () => {
// Regression: the GET handler injects `enginesExplicit` (compression.ts:632) so the
// hub/panel can round-trip the full settings object. The previous .strict() PUT schema
// rejected it with 400 ("Unrecognized key: enginesExplicit"), causing every toggle on
// the Compression Hub / Panel to revert. Allow it through.
const putRes = await route.PUT(makeRequest("PUT", { enabled: true, enginesExplicit: true }));
assert.equal(putRes.status, 200);
core.resetDbInstance();
const putRes2 = await route.PUT(makeRequest("PUT", { enabled: false, enginesExplicit: false }));
assert.equal(putRes2.status, 200);
});
});