fix(tests): clear the two base-reds on release/v3.8.50 (#9488)

* fix(tests): clear the two base-reds on release/v3.8.50 Both sat on the release itself and turned every open PR red as soon as it merged the release, independently of the PR's own content. - tests/snapshots/provider/translate-path.json: #9064 (b0501642dd) added the code-execution-2025-08-25 and skills-2025-10-02 beta flags to the Anthropic header but did not regenerate the golden. provider-translate-path-golden failed on the bare release tip — 2 pass / 1 fail with zero PRs boarded. Regenerated; the diff is 24 lines, all the same header in 6 variants. - tests/unit/v1-models-auth-leak-9320.test.ts:83: shipped a (k: any) in a file new enough that eslint-suppressions.json does not cover it. With @typescript-eslint/no-explicit-any as error under tests/, that one cast failed 'No new ESLint warnings' for every PR. The callback parameter infers correctly, so the cast was redundant. Verified on the fix branch: eslint exit 0, typecheck:core exit 0, and both test files green (5/5). * fix(tests): drop a third unsuppressed any (gemini-web validation test) A full-repo lint on this branch surfaced one more file in the same class: tests/unit/issue-9407-gemini-web-validation-false-positive.test.ts:50 casts (executor as any).testConnection. The file entered the release at f1ea77fd04 (23:28), newer than the frozen eslint-suppressions.json, so the cast is not covered — and it alone kept 'No new ESLint warnings' red on this very PR. testConnection is a declared public method on GeminiWebExecutor (open-sse/executors/gemini-web.ts:359), so the cast was redundant rather than load-bearing; removed outright. eslint exit 0, typecheck:core exit 0, 15/15 across the three touched tests.
2026-08-19 21:52:21 +03:00 · 2026-08-05 11:36:19 -03:00
parent 6b0e11e378
commit ef3f554665
4 changed files with 9 additions and 8 deletions
--- a/changelog.d/maintenance/base-reds-v3850-golden-and-any.md
+++ b/changelog.d/maintenance/base-reds-v3850-golden-and-any.md
@@ -0,0 +1 @@
+- **chore(tests):** cleared two base-reds sitting on `release/v3.8.50` itself, both of which turned every open PR red the moment it merged the release. `tests/snapshots/provider/translate-path.json` was stale: #9064 added the `code-execution-2025-08-25` and `skills-2025-10-02` beta flags to the Anthropic header without regenerating the golden, so `provider-translate-path-golden` failed on the bare release tip (2 pass / 1 fail with zero PRs boarded). And `tests/unit/v1-models-auth-leak-9320.test.ts:83` shipped a `(k: any)` in a file new enough that `config/quality/eslint-suppressions.json` does not cover it — with `@typescript-eslint/no-explicit-any` set to `error` under `tests/`, that single cast failed the `No new ESLint warnings` gate repo-wide. Same class in `tests/unit/issue-9407-gemini-web-validation-false-positive.test.ts:50` (`(executor as any).testConnection`), which entered at `f1ea77fd04` — `testConnection` is a declared public method on `GeminiWebExecutor`, so that cast was redundant too. Regenerating the snapshot and dropping both casts restores the gates.
--- a/tests/snapshots/provider/translate-path.json
+++ b/tests/snapshots/provider/translate-path.json
@@ -326,20 +326,20 @@
    "headers": {
      "apiKey": {
        "Accept": "text/event-stream",
-        "Anthropic-Beta": "claude-code-20250219,interleaved-thinking-2025-05-14,context-management-2025-06-27,prompt-caching-scope-2026-01-05,advanced-tool-use-2025-11-20,effort-2025-11-24,structured-outputs-2025-12-15,fast-mode-2026-02-01,redact-thinking-2026-02-12,token-efficient-tools-2026-03-28,advisor-tool-2026-03-01,extended-cache-ttl-2025-04-11,cache-diagnosis-2026-04-07",
+        "Anthropic-Beta": "claude-code-20250219,interleaved-thinking-2025-05-14,context-management-2025-06-27,prompt-caching-scope-2026-01-05,advanced-tool-use-2025-11-20,effort-2025-11-24,structured-outputs-2025-12-15,fast-mode-2026-02-01,redact-thinking-2026-02-12,token-efficient-tools-2026-03-28,advisor-tool-2026-03-01,extended-cache-ttl-2025-04-11,cache-diagnosis-2026-04-07,code-execution-2025-08-25,skills-2025-10-02",
        "Anthropic-Version": "2023-06-01",
        "Content-Type": "application/json",
        "x-api-key": "<CRED>"
      },
      "nonStream": {
-        "Anthropic-Beta": "claude-code-20250219,interleaved-thinking-2025-05-14,context-management-2025-06-27,prompt-caching-scope-2026-01-05,advanced-tool-use-2025-11-20,effort-2025-11-24,structured-outputs-2025-12-15,fast-mode-2026-02-01,redact-thinking-2026-02-12,token-efficient-tools-2026-03-28,advisor-tool-2026-03-01,extended-cache-ttl-2025-04-11,cache-diagnosis-2026-04-07",
+        "Anthropic-Beta": "claude-code-20250219,interleaved-thinking-2025-05-14,context-management-2025-06-27,prompt-caching-scope-2026-01-05,advanced-tool-use-2025-11-20,effort-2025-11-24,structured-outputs-2025-12-15,fast-mode-2026-02-01,redact-thinking-2026-02-12,token-efficient-tools-2026-03-28,advisor-tool-2026-03-01,extended-cache-ttl-2025-04-11,cache-diagnosis-2026-04-07,code-execution-2025-08-25,skills-2025-10-02",
        "Anthropic-Version": "2023-06-01",
        "Content-Type": "application/json",
        "x-api-key": "<CRED>"
      },
      "oauth": {
        "Accept": "text/event-stream",
-        "Anthropic-Beta": "claude-code-20250219,interleaved-thinking-2025-05-14,context-management-2025-06-27,prompt-caching-scope-2026-01-05,advanced-tool-use-2025-11-20,effort-2025-11-24,structured-outputs-2025-12-15,fast-mode-2026-02-01,redact-thinking-2026-02-12,token-efficient-tools-2026-03-28,advisor-tool-2026-03-01,extended-cache-ttl-2025-04-11,cache-diagnosis-2026-04-07",
+        "Anthropic-Beta": "claude-code-20250219,interleaved-thinking-2025-05-14,context-management-2025-06-27,prompt-caching-scope-2026-01-05,advanced-tool-use-2025-11-20,effort-2025-11-24,structured-outputs-2025-12-15,fast-mode-2026-02-01,redact-thinking-2026-02-12,token-efficient-tools-2026-03-28,advisor-tool-2026-03-01,extended-cache-ttl-2025-04-11,cache-diagnosis-2026-04-07,code-execution-2025-08-25,skills-2025-10-02",
        "Anthropic-Version": "2023-06-01",
        "Content-Type": "application/json",
        "x-api-key": "<CRED>"
@@ -870,7 +870,7 @@
    "headers": {
      "apiKey": {
        "Accept": "text/event-stream",
-        "Anthropic-Beta": "claude-code-20250219,oauth-2025-04-20,interleaved-thinking-2025-05-14,fine-grained-tool-streaming-2025-05-14,context-management-2025-06-27,prompt-caching-scope-2026-01-05,advanced-tool-use-2025-11-20,effort-2025-11-24,structured-outputs-2025-12-15,fast-mode-2026-02-01,redact-thinking-2026-02-12,token-efficient-tools-2026-03-28,advisor-tool-2026-03-01,extended-cache-ttl-2025-04-11,cache-diagnosis-2026-04-07",
+        "Anthropic-Beta": "claude-code-20250219,oauth-2025-04-20,interleaved-thinking-2025-05-14,fine-grained-tool-streaming-2025-05-14,context-management-2025-06-27,prompt-caching-scope-2026-01-05,advanced-tool-use-2025-11-20,effort-2025-11-24,structured-outputs-2025-12-15,fast-mode-2026-02-01,redact-thinking-2026-02-12,token-efficient-tools-2026-03-28,advisor-tool-2026-03-01,extended-cache-ttl-2025-04-11,cache-diagnosis-2026-04-07,code-execution-2025-08-25,skills-2025-10-02",
        "Anthropic-Dangerous-Direct-Browser-Access": "true",
        "Anthropic-Version": "2023-06-01",
        "Content-Type": "application/json",
@@ -888,7 +888,7 @@
        "x-api-key": "<CRED>"
      },
      "nonStream": {
-        "Anthropic-Beta": "claude-code-20250219,oauth-2025-04-20,interleaved-thinking-2025-05-14,fine-grained-tool-streaming-2025-05-14,context-management-2025-06-27,prompt-caching-scope-2026-01-05,advanced-tool-use-2025-11-20,effort-2025-11-24,structured-outputs-2025-12-15,fast-mode-2026-02-01,redact-thinking-2026-02-12,token-efficient-tools-2026-03-28,advisor-tool-2026-03-01,extended-cache-ttl-2025-04-11,cache-diagnosis-2026-04-07",
+        "Anthropic-Beta": "claude-code-20250219,oauth-2025-04-20,interleaved-thinking-2025-05-14,fine-grained-tool-streaming-2025-05-14,context-management-2025-06-27,prompt-caching-scope-2026-01-05,advanced-tool-use-2025-11-20,effort-2025-11-24,structured-outputs-2025-12-15,fast-mode-2026-02-01,redact-thinking-2026-02-12,token-efficient-tools-2026-03-28,advisor-tool-2026-03-01,extended-cache-ttl-2025-04-11,cache-diagnosis-2026-04-07,code-execution-2025-08-25,skills-2025-10-02",
        "Anthropic-Dangerous-Direct-Browser-Access": "true",
        "Anthropic-Version": "2023-06-01",
        "Content-Type": "application/json",
@@ -907,7 +907,7 @@
      },
      "oauth": {
        "Accept": "text/event-stream",
-        "Anthropic-Beta": "claude-code-20250219,oauth-2025-04-20,interleaved-thinking-2025-05-14,fine-grained-tool-streaming-2025-05-14,context-management-2025-06-27,prompt-caching-scope-2026-01-05,advanced-tool-use-2025-11-20,effort-2025-11-24,structured-outputs-2025-12-15,fast-mode-2026-02-01,redact-thinking-2026-02-12,token-efficient-tools-2026-03-28,advisor-tool-2026-03-01,extended-cache-ttl-2025-04-11,cache-diagnosis-2026-04-07",
+        "Anthropic-Beta": "claude-code-20250219,oauth-2025-04-20,interleaved-thinking-2025-05-14,fine-grained-tool-streaming-2025-05-14,context-management-2025-06-27,prompt-caching-scope-2026-01-05,advanced-tool-use-2025-11-20,effort-2025-11-24,structured-outputs-2025-12-15,fast-mode-2026-02-01,redact-thinking-2026-02-12,token-efficient-tools-2026-03-28,advisor-tool-2026-03-01,extended-cache-ttl-2025-04-11,cache-diagnosis-2026-04-07,code-execution-2025-08-25,skills-2025-10-02",
        "Anthropic-Dangerous-Direct-Browser-Access": "true",
        "Anthropic-Version": "2023-06-01",
        "Content-Type": "application/json",
--- a/tests/unit/issue-9407-gemini-web-validation-false-positive.test.ts
+++ b/tests/unit/issue-9407-gemini-web-validation-false-positive.test.ts
@@ -47,7 +47,7 @@ describe("GeminiWebExecutor — testConnection", () => {
      "@omniroute/open-sse/executors/gemini-web.ts"
    );
    const executor = new GeminiWebExecutor();
-    assert.equal(typeof (executor as any).testConnection, "function");
+    assert.equal(typeof executor.testConnection, "function");
  });

  it("returns false for empty credentials", async () => {
--- a/tests/unit/v1-models-auth-leak-9320.test.ts
+++ b/tests/unit/v1-models-auth-leak-9320.test.ts
@@ -80,7 +80,7 @@ test("#9320: authenticated request (valid API key) returns 200 with models", asy
  // Create a valid API key
  await apiKeysDb.createApiKey("test-key-9320", "test-machine-9320");
  const keys = await apiKeysDb.getApiKeys();
-  const apiKey = Array.isArray(keys) ? keys.find((k: any) => k.name === "test-key-9320") : null;
+  const apiKey = Array.isArray(keys) ? keys.find((k) => k.name === "test-key-9320") : null;
  assert.ok(apiKey, "API key must have been created");

  const res = await v1ModelsCatalog.getUnifiedModelsResponse(
				`@@ -0,0 +1 @@`
				- chore(tests): cleared two base-reds sitting on `release/v3.8.50` itself, both of which turned every open PR red the moment it merged the release. `tests/snapshots/provider/translate-path.json` was stale: #9064 added the `code-execution-2025-08-25` and `skills-2025-10-02` beta flags to the Anthropic header without regenerating the golden, so `provider-translate-path-golden` failed on the bare release tip (2 pass / 1 fail with zero PRs boarded). And `tests/unit/v1-models-auth-leak-9320.test.ts:83` shipped a `(k: any)` in a file new enough that `config/quality/eslint-suppressions.json` does not cover it — with `@typescript-eslint/no-explicit-any` set to `error` under `tests/`, that single cast failed the `No new ESLint warnings` gate repo-wide. Same class in `tests/unit/issue-9407-gemini-web-validation-false-positive.test.ts:50` (`(executor as any).testConnection`), which entered at `f1ea77fd04` — `testConnection` is a declared public method on `GeminiWebExecutor`, so that cast was redundant too. Regenerating the snapshot and dropping both casts restores the gates.