- Add `snapshotSession(sessionId)` to inspectorSessions.ts per master-plan §3.8:
returns parsed InterceptedRequest[] in seq order, or null for non-existent sessions.
Silently skips rows that fail InterceptedRequestSchema validation (defensive).
- Restore canonical no-arg form of `MitmHandlerBase.hookBufferUpdate(intercepted)`
per master-plan §3.5: when opts is omitted, derive completion fields from
the intercepted object itself (status/responseHeaders/responseBody/responseSize/
*LatencyMs) rather than no-op'ing. Extended opts form preserved for legacy callers.
- Update Zod record() calls in InterceptedRequestSchema to current (key,value) signature.
- Add 3 unit tests for snapshotSession (happy path / non-existent / silent skip).
- Add 2 unit tests for hookBufferUpdate (no-arg form + extended opts form).
Cover the new CJS routing primitives and the bypass-JSON manager write
path so the C1/C2 contracts cannot regress silently.
- `mitm-server-connect.test.ts` (27 tests): exercises the
`_internal/bypass.cjs` shim used by `server.cjs`:
- DEFAULT_BYPASS_PATTERNS shape (≥4 regexes, all RegExp)
- Default bank / gov / okta / auth0 → bypass
- Bypass beats target match (precedence)
- Known target hostname → target
- Unknown hostname → passthrough
- User glob pattern → bypass
- Empty / undefined hostname → passthrough
- Set-vs-Array shape for targetHosts
- Case-insensitive hostname matching
- bypassGlobMatch wildcard semantics + ReDoS-safe linear walk
- parseBypassJson with valid / empty / malformed / wrong-shape inputs
- Spec assertions on server.cjs source — header injection (C2),
sanitizeErrorMessage wrapping (Hard Rule #12), and CONNECT handler
registration (C1). These three guard against future regressions
that would silently re-introduce the bugs the C1/C2 fixes closed.
- `mitm-manager-bypass-json.test.ts` (5 tests): exercises
`writeBypassJson()`:
- Creates the `mitm/` dir + valid JSON file shape
- Empty array roundtrips as empty patterns
- Falls back to `getUserBypassPatterns()` when no arg passed
- Default patterns from the DB are NOT written to the file
- Overwrites prior content
The CJS proxy in `src/mitm/server.cjs` cannot import the TS
`getUserBypassPatterns` directly. Mirror the `targets.json` pattern: on
`startMitm()` the manager now also writes `<DATA_DIR>/mitm/bypass.json`
with the user-defined glob patterns from `agent_bridge_bypass`. The CJS
proxy reads the file at boot via the `_internal/bypass.cjs` shim's
`parseBypassJson` helper.
Defaults (banks / gov / okta / auth0) live hardcoded in the CJS shim —
they are not persisted to the JSON file. This matches the privacy
contract: defaults always apply, even when the DB or the JSON file is
missing or unreadable.
Plan reference: 11-agent-bridge.plan.md §4.6 + master-plan-group-A.md §3.5.
Hard Rule #13: file I/O only — no shell interpolation.
`MitmHandlerBase.fetchRouter` already injects the AgentBridge correlation
headers, but the CJS proxy in `src/mitm/server.cjs` had never been
updated to match. As a result the running Antigravity flow was hitting
the OmniRoute router with no source/agent identification, breaking the
contract documented in master-plan-group-A.md §3.5 and §12 acceptance #17.
This commit adds:
- `x-omniroute-source: agent-bridge` — distinguishes AgentBridge traffic
from other inbound clients.
- `x-omniroute-agent: <id>` — IDE agent id resolved from the Host header
via the existing `TARGET_HOST_AGENT` map (populated by `targets.json`
+ the antigravity baseline). Defensive fallback to `"unknown"` for
hosts that were never registered, so router-side filters never get
an empty value.
Antigravity non-regression preserved: `daily-cloudcode-pa.googleapis.com`
continues to resolve to `agentId="antigravity"` via the baseline seed in
`TARGET_HOST_AGENT.set(h, "antigravity")` at the top of the file.
Bring `src/mitm/server.cjs` into compliance with the AgentBridge MITM
contract (master plan §3.5 / §12 acceptance #16). Prior to this commit
the bypass/passthrough logic existed in TS (`src/mitm/passthrough.ts`,
`src/mitm/targets/index.ts::routeConnection`, `src/lib/db/agentBridgeBypass.ts`)
but was completely disconnected from the running CJS proxy.
Changes:
- Add `server.on("connect", ...)` so HTTPS proxy clients can still tunnel
to non-AgentBridge hosts without losing internet. Per host the handler
decides:
- bypass (default regex or user glob) → raw TCP pipe, NO TLS decrypt,
NO content logging (privacy: bypass = "never see content")
- target (in TARGET_HOSTS) → write 200 Connection
Established and emit `connection` so the existing
`https.createServer` decrypts and routes via the normal flow
- passthrough (anything else) → raw TCP pipe
- Introduce `src/mitm/_internal/bypass.cjs` shim that mirrors
`DEFAULT_BYPASS_PATTERNS` and `routeConnection` from the TS source.
Defaults stay hardcoded (banks, gov, okta, auth0); user patterns load
from `<DATA_DIR>/mitm/bypass.json` (written by manager — separate commit).
- Add a CJS port of `sanitizeErrorMessage` and wire it into the intercept
error path so HTTP/SSE error bodies never expose raw `err.message`.
Closes a pre-existing Hard Rule #12 violation in the file.
Defaults match `src/mitm/passthrough.ts::DEFAULT_BYPASS_PATTERNS` and
`shouldBypass` precedence is identical to `routeConnection`. Antigravity
non-regression preserved — known hosts still trigger TLS termination via
the existing request handler.
AgentCard.handleRiskAccept was calling markRiskAccepted() before opening the
RiskNoticeModal, which itself writes the same key via dontShowAgainKey on accept.
Remove the redundant markRiskAccepted call and delete the now-unused helper so
RiskNoticeModal (D16) is the sole canonical persistence owner. Add a spy-based
test asserting the key is written exactly once per accept.
11 assertions covering: dynamic import with ssr:false, absence of static
recharts import in StatsTab, absence of the discarded _rechartsPreload
pattern, and presence of recharts exports in StatsCharts.
Move all recharts rendering into StatsCharts.tsx and replace the orphaned
_rechartsPreload no-op with a proper next/dynamic() call (ssr: false), achieving
real bundle split so recharts is not included in the initial page chunk.
Convert CaptureModesToolbar, TopBarControls, CustomHostsManager,
HttpProxySnippetCard and SessionRecorderBar to consume useTranslations
instead of hardcoded English strings. Add 7 missing trafficInspector
keys (customHostsTitle, loading, copied, copy, httpProxyTitle,
notRecording, anyStatus) to both en.json and pt-BR.json.
hookBufferStart was calling recordRequestStart without sourceModel,
causing the field to be null even when extractSourceModel returned
a value from the body. Now forwards the extracted model so the
Traffic Inspector buffer entry is populated correctly.
- RiskNoticeBanner: use lazy useState initializer for localStorage read
instead of useEffect + setState
- ModelSelectorModal: move fetch logic to useCallback, call from useEffect
to avoid setState directly in effect body
Add ~90 i18n keys under agentBridge.* namespace (server card, agent list,
agent card, setup wizard, model mapping, bypass list, upstream CA, empty
state, risk banner, sidebar title/subtitle) in en.json and pt-BR.json.
Other 39 locales get EN fallback automatically (D17).
