mirror of
https://github.com/diegosouzapw/OmniRoute.git
synced 2026-08-15 11:43:10 +03:00
Compare commits
2 Commits
fix/10286-
...
fix/10085-
| Author | SHA1 | Date | |
|---|---|---|---|
|
|
d3e561eb91 | ||
|
|
61e39bfe54 |
@@ -0,0 +1 @@
|
||||
- fix(sse): bridge generic openai-compatible/anthropic-compatible provider type ids to their concrete uuid node id in credential lookup (#10085)
|
||||
@@ -1 +0,0 @@
|
||||
- fix(sse): mark gemini-3.5-flash as thinking-capable so reasoning_effort is no longer rejected with a spurious 400 (#10286)
|
||||
@@ -226,16 +226,8 @@ export const MODEL_SPECS: Record<string, ModelSpec> = {
|
||||
},
|
||||
|
||||
// ── Gemini 3.5 Flash ─────────────────────────────────────────────
|
||||
// #10286: the base Google AI Studio model DOES support reasoning (it has
|
||||
// an effort-tier alias gemini-3.5-flash-high) — override the shared spec's
|
||||
// supportsThinking:false here only. Do NOT flip GEMINI_35_FLASH_MODEL_SPEC
|
||||
// itself: it is also spread into the Antigravity flash-tier aliases
|
||||
// (gemini-3.5-flash-low/-extra-low, gemini-3-flash-agent, gemini-3.6-flash-*)
|
||||
// which reject client-supplied thinking params because the model id itself
|
||||
// selects the reasoning tier upstream.
|
||||
"gemini-3.5-flash": {
|
||||
...GEMINI_35_FLASH_MODEL_SPEC,
|
||||
supportsThinking: true,
|
||||
aliases: ["gemini-3.5-flash-high"],
|
||||
},
|
||||
|
||||
|
||||
@@ -1,4 +1,5 @@
|
||||
import { randomUUID, createHash } from "crypto";
|
||||
import { nodeTypeFromId } from "@/lib/db/providerNodeSelect";
|
||||
import { extractGoogApiKeyHeader } from "./googApiKeyAuth.ts";
|
||||
import {
|
||||
getCachedRawProviderConnections,
|
||||
@@ -967,14 +968,33 @@ async function getProviderSearchPool(provider: string): Promise<string[]> {
|
||||
const nodeRecord = asRecord(node);
|
||||
const nodePrefix = typeof nodeRecord.prefix === "string" ? nodeRecord.prefix.trim() : "";
|
||||
const nodeId = typeof nodeRecord.id === "string" ? nodeRecord.id.trim() : "";
|
||||
if (!nodePrefix || !nodeId) continue;
|
||||
if (!nodeId) continue;
|
||||
if (
|
||||
nodePrefix === provider ||
|
||||
nodePrefix === canonicalProvider ||
|
||||
nodePrefix === canonicalAlias
|
||||
nodePrefix &&
|
||||
(nodePrefix === provider || nodePrefix === canonicalProvider || nodePrefix === canonicalAlias)
|
||||
) {
|
||||
searchPool.add(nodeId);
|
||||
}
|
||||
|
||||
// #10085: bridge the concrete uuid node id (what the chat path resolves,
|
||||
// "<generic-type>-<uuid>") to the GENERIC derived type id (what
|
||||
// resolveProviderNodeForConnection also accepts for connection creation,
|
||||
// #4421) -- and back. A connection created via the bare generic type
|
||||
// (e.g. "openai-compatible-chat") must still be found when the chat path
|
||||
// looks up the concrete node id, and vice versa.
|
||||
const derivedType = nodeTypeFromId(nodeId);
|
||||
if (derivedType && derivedType !== nodeId) {
|
||||
if (nodeId === provider || nodeId === canonicalProvider || nodeId === canonicalAlias) {
|
||||
searchPool.add(derivedType);
|
||||
}
|
||||
if (
|
||||
derivedType === provider ||
|
||||
derivedType === canonicalProvider ||
|
||||
derivedType === canonicalAlias
|
||||
) {
|
||||
searchPool.add(nodeId);
|
||||
}
|
||||
}
|
||||
}
|
||||
} catch {
|
||||
// Best-effort alias expansion only.
|
||||
|
||||
@@ -53,6 +53,7 @@
|
||||
"tests/unit/8396-cooldown-429-cap.test.ts",
|
||||
"tests/unit/8488-capability-filter-fail-closed.test.ts",
|
||||
"tests/unit/8779-agy-prefix-credential-lookup.test.ts",
|
||||
"tests/unit/10085-compatible-generic-vs-uuid-credential.test.ts",
|
||||
"tests/unit/account-fallback-anthropic-quota.test.ts",
|
||||
"tests/unit/account-fallback-cf1010-no-retry-8775.test.ts",
|
||||
"tests/unit/account-fallback-lockout-eviction.test.ts",
|
||||
|
||||
152
tests/unit/10085-compatible-generic-vs-uuid-credential.test.ts
Normal file
152
tests/unit/10085-compatible-generic-vs-uuid-credential.test.ts
Normal file
@@ -0,0 +1,152 @@
|
||||
/**
|
||||
* #10085 -- a custom openai-compatible provider connection persisted under the
|
||||
* GENERIC derived type id ("openai-compatible-chat") must still be reachable
|
||||
* when the chat path looks up the concrete uuid node id
|
||||
* ("openai-compatible-chat-<uuid>"), and vice versa.
|
||||
*
|
||||
* `resolveProviderNodeForConnection` (src/lib/db/providers/nodes.ts, #4421)
|
||||
* already accepts the bare generic type id when a connection is created via
|
||||
* `/api/providers`. But `getProviderSearchPool` (src/sse/services/auth.ts)
|
||||
* only bridged the search pool via a node's `prefix`, never via the generic
|
||||
* type id <-> concrete node id relationship, so a connection created under
|
||||
* the generic type id went permanently unreachable from the chat path --
|
||||
* "No active credentials for provider: openai-compatible-chat-<uuid>", the
|
||||
* exact error reported in #10085.
|
||||
*/
|
||||
import test from "node:test";
|
||||
import assert from "node:assert/strict";
|
||||
import fs from "node:fs";
|
||||
import os from "node:os";
|
||||
import path from "node:path";
|
||||
|
||||
const TEST_DATA_DIR = fs.mkdtempSync(path.join(os.tmpdir(), "omniroute-10085-compat-"));
|
||||
process.env.DATA_DIR = TEST_DATA_DIR;
|
||||
|
||||
const core = await import("../../src/lib/db/core.ts");
|
||||
const nodesDb = await import("../../src/lib/db/providers/nodes.ts");
|
||||
const providersDb = await import("../../src/lib/db/providers.ts");
|
||||
const auth = await import("../../src/sse/services/auth.ts");
|
||||
|
||||
const NODE_PREFIX = "my-compat-10085";
|
||||
const NODE_ID = `openai-compatible-chat-458d982b-0000-4000-8000-000000000000`;
|
||||
|
||||
async function resetStorage() {
|
||||
core.resetDbInstance();
|
||||
fs.rmSync(TEST_DATA_DIR, { recursive: true, force: true });
|
||||
fs.mkdirSync(TEST_DATA_DIR, { recursive: true });
|
||||
}
|
||||
|
||||
test.after(() => {
|
||||
core.resetDbInstance();
|
||||
fs.rmSync(TEST_DATA_DIR, { recursive: true, force: true });
|
||||
});
|
||||
|
||||
async function seedNode() {
|
||||
await nodesDb.createProviderNode({
|
||||
id: NODE_ID,
|
||||
type: "openai-compatible",
|
||||
name: "My Compat",
|
||||
prefix: NODE_PREFIX,
|
||||
apiType: "chat",
|
||||
baseUrl: "https://example.test/v1",
|
||||
});
|
||||
}
|
||||
|
||||
test("a connection stored under the GENERIC type id is reachable when chat resolves the uuid node id (#10085)", async () => {
|
||||
await resetStorage();
|
||||
await seedNode();
|
||||
await providersDb.createProviderConnection({
|
||||
provider: "openai-compatible-chat", // generic type id, NOT the uuid node id
|
||||
authType: "apikey",
|
||||
apiKey: "sk-test-10085",
|
||||
name: "test-compat",
|
||||
isActive: true,
|
||||
testStatus: "active",
|
||||
priority: 1,
|
||||
providerSpecificData: { prefix: NODE_PREFIX, baseUrl: "https://example.test/v1" },
|
||||
});
|
||||
|
||||
const creds = await auth.getProviderCredentials(NODE_ID);
|
||||
|
||||
assert.ok(
|
||||
creds,
|
||||
`chat looked up "${NODE_ID}" but the connection is parked under the generic ` +
|
||||
`"openai-compatible-chat" provider id -- getProviderSearchPool never bridges the ` +
|
||||
`generic type id to the concrete node id. This matches #10085 exactly.`
|
||||
);
|
||||
});
|
||||
|
||||
test("the bridge works in the other direction too: a uuid-stored connection is reachable via the generic type id", async () => {
|
||||
await resetStorage();
|
||||
await seedNode();
|
||||
await providersDb.createProviderConnection({
|
||||
provider: NODE_ID, // concrete uuid node id
|
||||
authType: "apikey",
|
||||
apiKey: "sk-test-10085-b",
|
||||
name: "test-compat-b",
|
||||
isActive: true,
|
||||
testStatus: "active",
|
||||
priority: 1,
|
||||
providerSpecificData: { prefix: NODE_PREFIX, baseUrl: "https://example.test/v1" },
|
||||
});
|
||||
|
||||
const creds = await auth.getProviderCredentials("openai-compatible-chat");
|
||||
|
||||
assert.ok(
|
||||
creds,
|
||||
`a connection stored under the uuid node id "${NODE_ID}" must also be reachable via ` +
|
||||
`a lookup using the bare generic type id "openai-compatible-chat"`
|
||||
);
|
||||
});
|
||||
|
||||
test("control: a connection stored under the uuid node id is found by a uuid node id lookup", async () => {
|
||||
await resetStorage();
|
||||
await seedNode();
|
||||
await providersDb.createProviderConnection({
|
||||
provider: NODE_ID,
|
||||
authType: "apikey",
|
||||
apiKey: "sk-test-10085-c",
|
||||
name: "test-compat-c",
|
||||
isActive: true,
|
||||
testStatus: "active",
|
||||
priority: 1,
|
||||
providerSpecificData: { prefix: NODE_PREFIX, baseUrl: "https://example.test/v1" },
|
||||
});
|
||||
|
||||
assert.ok(await auth.getProviderCredentials(NODE_ID));
|
||||
});
|
||||
|
||||
test("control: a connection stored under the uuid node id is found via prefix lookup", async () => {
|
||||
await resetStorage();
|
||||
await seedNode();
|
||||
await providersDb.createProviderConnection({
|
||||
provider: NODE_ID,
|
||||
authType: "apikey",
|
||||
apiKey: "sk-test-10085-d",
|
||||
name: "test-compat-d",
|
||||
isActive: true,
|
||||
testStatus: "active",
|
||||
priority: 1,
|
||||
providerSpecificData: { prefix: NODE_PREFIX, baseUrl: "https://example.test/v1" },
|
||||
});
|
||||
|
||||
assert.ok(await auth.getProviderCredentials(NODE_PREFIX));
|
||||
});
|
||||
|
||||
test("the bridge does not make unrelated generic types findable", async () => {
|
||||
await resetStorage();
|
||||
await seedNode();
|
||||
await providersDb.createProviderConnection({
|
||||
provider: "openai-compatible-chat",
|
||||
authType: "apikey",
|
||||
apiKey: "sk-test-10085-e",
|
||||
name: "test-compat-e",
|
||||
isActive: true,
|
||||
testStatus: "active",
|
||||
priority: 1,
|
||||
providerSpecificData: { prefix: NODE_PREFIX, baseUrl: "https://example.test/v1" },
|
||||
});
|
||||
|
||||
// A different generic type (responses, not chat) must stay unrelated.
|
||||
assert.equal(await auth.getProviderCredentials("openai-compatible-responses"), null);
|
||||
});
|
||||
@@ -1,76 +0,0 @@
|
||||
// Regression test for #10286: gemini-3.5-flash was incorrectly marked
|
||||
// supportsThinking:false, causing a spurious pre-provider HTTP 400 for any
|
||||
// request with reasoning_effort set, even though the base Google AI Studio
|
||||
// model supports reasoning (it has an effort-tier alias gemini-3.5-flash-high).
|
||||
import test from "node:test";
|
||||
import assert from "node:assert/strict";
|
||||
import fs from "node:fs";
|
||||
import os from "node:os";
|
||||
import path from "node:path";
|
||||
|
||||
const TEST_DATA_DIR = fs.mkdtempSync(path.join(os.tmpdir(), "omniroute-repro-10286-"));
|
||||
process.env.DATA_DIR = TEST_DATA_DIR;
|
||||
process.env.API_KEY_SECRET = process.env.API_KEY_SECRET || "test-repro-10286-secret";
|
||||
|
||||
const caps = await import("../../src/lib/modelCapabilities.ts");
|
||||
const core = await import("../../src/lib/db/core.ts");
|
||||
const rulesDb = await import("../../src/lib/db/reasoningRoutingRules.ts");
|
||||
const policy = await import("../../src/lib/reasoningRouting/policy.ts");
|
||||
|
||||
async function resetStorage() {
|
||||
core.resetDbInstance();
|
||||
fs.rmSync(TEST_DATA_DIR, { recursive: true, force: true });
|
||||
fs.mkdirSync(TEST_DATA_DIR, { recursive: true });
|
||||
rulesDb.invalidateReasoningRoutingRuleCache();
|
||||
}
|
||||
|
||||
function ruleInput(patch: Record<string, unknown> = {}) {
|
||||
return {
|
||||
name: "Enable thinking on gemini-3.5-flash",
|
||||
description: "",
|
||||
scope: "global",
|
||||
apiKeyId: null,
|
||||
comboId: null,
|
||||
connectionId: null,
|
||||
modelPattern: "gemini-3.5-flash",
|
||||
sourceEffort: "any",
|
||||
requestTags: [],
|
||||
tagMatchMode: "any",
|
||||
effortMode: "inherit",
|
||||
targetEffort: null,
|
||||
targetKind: "keep",
|
||||
targetModel: null,
|
||||
targetComboId: null,
|
||||
budgetAction: "preserve",
|
||||
budgetTokens: null,
|
||||
priority: 0,
|
||||
enabled: true,
|
||||
...patch,
|
||||
};
|
||||
}
|
||||
|
||||
test.beforeEach(resetStorage);
|
||||
test.after(async () => {
|
||||
await resetStorage();
|
||||
fs.rmSync(TEST_DATA_DIR, { recursive: true, force: true });
|
||||
});
|
||||
|
||||
test("gemini-3.5-flash (AI Studio provider) resolves as thinking-capable", () => {
|
||||
const resolved = caps.getResolvedModelCapabilities({
|
||||
provider: "gemini",
|
||||
model: "gemini-3.5-flash",
|
||||
});
|
||||
assert.equal(resolved.supportsThinking, true);
|
||||
});
|
||||
|
||||
test("reasoning_effort 'high' on gemini-3.5-flash is NOT rejected by routing policy", async () => {
|
||||
await rulesDb.createReasoningRoutingRule(ruleInput());
|
||||
const decision = await policy.resolveReasoningRoutingRule({
|
||||
sourceModel: "gemini/gemini-3.5-flash",
|
||||
sourceModelAliases: ["gemini-3.5-flash"],
|
||||
sourceEffort: "high",
|
||||
hasReasoningSignal: true,
|
||||
});
|
||||
assert.ok(decision, "a matching rule must produce a decision");
|
||||
assert.equal(decision.capability, "supported");
|
||||
});
|
||||
Reference in New Issue
Block a user