Andrew B. eadcbea1c9 fix(combo): strip boolean reasoning field for opencode-go providers (#7891) ...

* fix(combo): strip boolean reasoning field for opencode-go providers

opencode-go backed providers (ollama-cloud, opencode-go, opencode,
opencode-zen) use a Go ChatCompletionRequest struct where the reasoning
field is typed as openai.Reasoning (a structured type). When a client
sends reasoning: true or reasoning: false — valid per the OpenAI API —
the Go JSON decoder rejects it with:

  400: json: cannot unmarshal bool into Go struct field
  ChatCompletionRequest.reasoning of type openai.Reasoning

This strips the boolean reasoning field before forwarding to these
providers, allowing the upstream to apply its own default reasoning
behavior. Object/string forms are left untouched.

Observed in production: 3 consecutive 400 errors from ollama-cloud/glm-5.2
in a 30-second window, each with the unmarshal error.

* fix(opencode): add null/primitive guard in stripBooleanReasoning

Adds defensive check for null, undefined, and non-object inputs
as suggested in review. Added unit test coverage for these edge cases.

2026-07-20 22:26:13 -03:00

3.9 KiB

Raw Permalink Blame History

View Raw