Files
OmniRoute/tests/unit/provider-models-route-codex.test.ts
Tito Fauzan Putra 0809c73430 fix(providers): correct Codex GPT-5.6 context window (#8838)
* fix(providers): correct Codex GPT-5.6 context window (#7702)

* docs(changelog): add fragment for #8838

Co-authored-by: diegosouzapw <8016841+diegosouzapw@users.noreply.github.com>

* test(providers): align the remaining GPT-5.6 context-window assertions

Three suites assert the pinned GPT_5_6_CODEX_CAPABILITIES contract through the
VS Code and provider-models routes, and still expected 372000. They only surface
in a full run, so the focused loop on this PR stayed green while `npm run test:unit`
failed with five `272000 !== 372000`.

The two conservative-merge cases in provider-models-route-codex keep testing what
they tested: live 999999 still exceeds the pinned value (pinned wins) and live
100000 is still below it (live wins). Only the pinned number and the comments
naming it move.

Co-authored-by: diegosouzapw <8016841+diegosouzapw@users.noreply.github.com>

---------

Co-authored-by: diegosouzapw <8016841+diegosouzapw@users.noreply.github.com>
2026-07-28 10:24:36 -03:00

430 lines
15 KiB
TypeScript

import test from "node:test";
import assert from "node:assert/strict";
import fs from "node:fs";
import os from "node:os";
import path from "node:path";
const TEST_DATA_DIR = fs.mkdtempSync(
path.join(os.tmpdir(), "omniroute-provider-model-routes-codex-")
);
process.env.DATA_DIR = TEST_DATA_DIR;
const core = await import("../../src/lib/db/core.ts");
const providersDb = await import("../../src/lib/db/providers.ts");
const modelsDb = await import("../../src/lib/db/models.ts");
const providerModelsRoute = await import("../../src/app/api/providers/[id]/models/route.ts");
const codexDiscovery = await import("../../src/app/api/providers/[id]/models/discovery/codex.ts");
type RouteModel = {
id: string;
name?: string;
apiFormat?: string;
supportedEndpoints?: string[];
inputTokenLimit?: number;
outputTokenLimit?: number;
[key: string]: unknown;
};
type RouteBody = {
provider?: string;
models?: RouteModel[];
source?: string;
warning?: string;
intentional?: boolean;
discoveredCandidateCount?: number;
};
type ProviderOverrides = {
authType?: string;
apiKey?: string | null;
accessToken?: string | null;
providerSpecificData?: Record<string, unknown>;
};
const originalFetch = globalThis.fetch;
async function resetStorage() {
globalThis.fetch = originalFetch;
codexDiscovery.clearCodexGithubCatalogCacheForTests();
core.resetDbInstance();
fs.rmSync(TEST_DATA_DIR, { recursive: true, force: true });
fs.mkdirSync(TEST_DATA_DIR, { recursive: true });
}
async function seedCodexConnection(overrides: ProviderOverrides = {}) {
return providersDb.createProviderConnection({
provider: "codex",
authType: overrides.authType || "oauth",
name: `codex-${Math.random().toString(16).slice(2, 8)}`,
apiKey: overrides.apiKey,
accessToken: overrides.accessToken,
isActive: true,
testStatus: "active",
providerSpecificData: overrides.providerSpecificData || {},
});
}
async function callRoute(connectionId: string, search = "") {
return providerModelsRoute.GET(
new Request(`http://localhost/api/providers/${connectionId}/models${search}`),
{ params: { id: connectionId } }
);
}
test.beforeEach(async () => {
await resetStorage();
});
test.after(async () => {
globalThis.fetch = originalFetch;
codexDiscovery.clearCodexGithubCatalogCacheForTests();
core.resetDbInstance();
fs.rmSync(TEST_DATA_DIR, { recursive: true, force: true });
});
test("provider models route merges live Codex models with the local catalog then filters denylist", async () => {
const connection = await seedCodexConnection({
accessToken: "codex-access-token",
providerSpecificData: { chatgptAccountId: "account-123" },
});
await modelsDb.replaceSyncedAvailableModelsForConnection("codex", connection.id, [
{ id: "stale-codex-model", name: "Stale Codex Model", source: "imported" },
]);
const seenRequests: Array<Record<string, string | null>> = [];
globalThis.fetch = async (url, init) => {
const requestUrl = String(url);
const headers = new Headers(init?.headers as HeadersInit | undefined);
seenRequests.push({
url: requestUrl,
authorization: headers.get("authorization"),
workspaceId: headers.get("chatgpt-account-id"),
originator: headers.get("originator"),
userAgent: headers.get("user-agent"),
});
if (requestUrl.includes("raw.githubusercontent.com/openai/codex")) {
return Response.json({
models: [
{
slug: "gpt-5.6-sol",
display_name: "GPT 5.6 Sol GitHub",
visibility: "list",
supported_in_api: true,
minimal_client_version: "0.144.0",
context_window: 372000,
input_modalities: ["text", "image"],
supported_reasoning_levels: [{ effort: "low" }, { effort: "high" }],
},
{
slug: "gpt-5.4",
display_name: "Retired GPT 5.4 GitHub",
visibility: "list",
supported_in_api: true,
},
],
});
}
return Response.json({
models: [
{ slug: "codex-auto-review", visibility: "hide", supported_in_api: true },
{
slug: "gpt-5.6-sol",
display_name: "GPT 5.6 Sol Live",
visibility: "list",
supported_in_api: true,
max_input_tokens: 999999,
max_output_tokens: 999999,
},
{
slug: "gpt-5.4",
display_name: "Retired GPT 5.4 Live",
visibility: "list",
supported_in_api: true,
},
{ id: "", name: "missing-id" },
],
});
};
const response = await callRoute(connection.id, "?refresh=true");
const body = (await response.json()) as RouteBody;
const modelIds = new Set(body.models?.map((model) => model.id));
const liveModel = body.models?.find((model) => model.id === "gpt-5.6-sol");
const syncedModels = await modelsDb.getSyncedAvailableModelsForConnection("codex", connection.id);
const syncedIds = new Set(syncedModels.map((model) => model.id));
assert.equal(response.status, 200);
assert.equal(body.provider, "codex");
assert.equal(body.source, "api");
assert.equal(body.discoveredCandidateCount, undefined);
assert.deepEqual(seenRequests, [
{
url: "https://chatgpt.com/backend-api/codex/models?client_version=0.144.1",
authorization: "Bearer codex-access-token",
workspaceId: "account-123",
originator: "codex_cli_rs",
userAgent: "codex-cli/0.144.1 (Windows 10.0.26200; x64)",
},
{
url: "https://raw.githubusercontent.com/openai/codex/refs/heads/main/codex-rs/models-manager/models.json",
authorization: null,
workspaceId: null,
originator: null,
userAgent: null,
},
]);
assert.ok(modelIds.has("gpt-5.6-sol"));
assert.ok(modelIds.has("gpt-5.6-sol-ultra"));
assert.ok(modelIds.has("gpt-5.6-sol-max"));
// Live payload wins on overlapping fields; local catalog supplies local-only
// variants. EXCEPTION: capacity limits (inputTokenLimit/outputTokenLimit)
// merge conservatively — the smaller of live vs. pinned wins, never the
// larger, so a stale/inflated live number can never make OmniRoute promise
// more context than the account can actually serve (#7012). Here the pinned
// GPT-5.6 Codex contract (272000/128000, see GPT_5_6_CODEX_CAPABILITIES) is
// smaller than the live payload's 999999/999999, so the pinned value wins.
assert.equal(liveModel?.name, "GPT 5.6 Sol Live");
assert.equal(liveModel?.inputTokenLimit, 272000);
assert.equal(liveModel?.outputTokenLimit, 128000);
assert.equal(liveModel?.apiFormat, "responses");
assert.deepEqual(liveModel?.supportedEndpoints, ["responses"]);
assert.equal(liveModel?.supportsThinking, true);
assert.equal(liveModel?.supportsVision, true);
assert.ok(modelIds.has("gpt-5.5-low"));
assert.equal(
[...modelIds].some((id) => String(id).startsWith("gpt-5.4")),
false
);
assert.ok(syncedIds.has("gpt-5.6-sol"));
assert.ok(syncedIds.has("gpt-5.5-low"));
assert.equal(
[...syncedIds].some((id) => String(id).startsWith("gpt-5.4")),
false
);
// Stale cache-only ids are replaced when a fresh discovery response is persisted.
assert.equal(modelIds.has("stale-codex-model"), false);
assert.equal(syncedIds.has("stale-codex-model"), false);
});
test("provider models route: live token limit wins when it is SMALLER than the pinned local catalog value", async () => {
const connection = await seedCodexConnection({
accessToken: "codex-access-token",
providerSpecificData: { chatgptAccountId: "account-123" },
});
globalThis.fetch = async (url) => {
const requestUrl = String(url);
if (requestUrl.includes("raw.githubusercontent.com/openai/codex")) {
return Response.json({ models: [] });
}
// Live reports a SMALLER budget than the pinned GPT-5.6 Codex contract
// (272000/128000, GPT_5_6_CODEX_CAPABILITIES) — e.g. a temporary
// account-level cap. The conservative merge must take the smaller live
// value here, not the larger pinned one (#7012).
return Response.json({
models: [
{
slug: "gpt-5.6-sol",
display_name: "GPT 5.6 Sol Live",
visibility: "list",
supported_in_api: true,
max_input_tokens: 100000,
max_output_tokens: 50000,
},
],
});
};
const response = await callRoute(connection.id, "?refresh=true");
const body = (await response.json()) as RouteBody;
const liveModel = body.models?.find((model) => model.id === "gpt-5.6-sol");
assert.equal(response.status, 200);
assert.equal(liveModel?.inputTokenLimit, 100000);
assert.equal(liveModel?.outputTokenLimit, 50000);
});
test("provider models route uses the GitHub Codex catalog when live discovery fails", async () => {
const connection = await seedCodexConnection({ accessToken: "codex-access-token" });
const seenUrls: string[] = [];
globalThis.fetch = async (url) => {
const requestUrl = String(url);
seenUrls.push(requestUrl);
if (requestUrl.includes("raw.githubusercontent.com/openai/codex")) {
return Response.json({
models: [
{
slug: "gpt-5.6-sol",
display_name: "GPT-5.6-Sol",
visibility: "list",
supported_in_api: true,
minimal_client_version: "0.144.0",
context_window: 372000,
},
{
slug: "gpt-5.4",
display_name: "Retired GPT-5.4",
visibility: "list",
supported_in_api: true,
},
],
});
}
return new Response("upstream unavailable", { status: 503 });
};
const response = await callRoute(connection.id, "?refresh=true");
const body = (await response.json()) as RouteBody;
const modelIds = new Set((body.models || []).map((model) => model.id));
assert.equal(response.status, 200);
assert.equal(body.provider, "codex");
assert.equal(body.source, "api");
assert.equal(body.intentional, undefined);
assert.equal(body.warning, "Codex live catalog unavailable — using GitHub model catalog");
assert.equal(body.discoveredCandidateCount, undefined);
assert.ok(seenUrls.some((url) => url.includes("backend-api/codex/models")));
assert.ok(seenUrls.some((url) => url.includes("raw.githubusercontent.com/openai/codex")));
assert.ok(modelIds.has("gpt-5.6-sol"));
assert.ok(modelIds.has("gpt-5.5-low"));
assert.equal(
[...modelIds].some((id) => String(id).startsWith("gpt-5.4")),
false
);
});
test("provider models route returns cached Codex models when refresh discovery fails", async () => {
const connection = await seedCodexConnection({ accessToken: "codex-access-token" });
await modelsDb.replaceSyncedAvailableModelsForConnection("codex", connection.id, [
{
id: "gpt-5.4",
name: "Retired Cached GPT 5.4",
source: "imported",
apiFormat: "responses",
supportedEndpoints: ["responses"],
},
{
id: "gpt-5.6-sol",
name: "Cached GPT 5.6 Sol",
source: "imported",
apiFormat: "responses",
supportedEndpoints: ["responses"],
},
]);
globalThis.fetch = async () => new Response("upstream unavailable", { status: 503 });
const response = await callRoute(connection.id, "?refresh=true");
const body = (await response.json()) as RouteBody;
assert.equal(response.status, 200);
assert.equal(body.provider, "codex");
assert.equal(body.source, "cache");
assert.equal(body.warning, "Codex live catalog unavailable — using cached catalog");
assert.equal(body.discoveredCandidateCount, undefined);
const modelIds = new Set((body.models || []).map((model) => model.id));
assert.ok(modelIds.has("gpt-5.6-sol"));
assert.ok(modelIds.has("gpt-5.6-sol-ultra"));
assert.equal(
[...modelIds].some((id) => String(id).startsWith("gpt-5.4")),
false
);
const syncedModels = await modelsDb.getSyncedAvailableModelsForConnection("codex", connection.id);
const syncedIds = new Set(syncedModels.map((model) => model.id));
assert.ok(syncedIds.has("gpt-5.6-sol-ultra"));
assert.equal(syncedIds.has("gpt-5.4"), false);
});
test("provider models route auto-includes remote-only Codex models after merge", async () => {
const connection = await seedCodexConnection({ accessToken: "codex-access-token" });
globalThis.fetch = async (url) => {
const requestUrl = String(url);
if (requestUrl.includes("raw.githubusercontent.com/openai/codex")) {
return Response.json({ models: [] });
}
return Response.json({
models: [
{
slug: "future-codex-experimental",
display_name: "Future Codex Experimental",
visibility: "list",
supported_in_api: true,
},
{
slug: "gpt-5.6-sol",
display_name: "GPT 5.6 Sol Live",
visibility: "list",
supported_in_api: true,
},
{
slug: "gpt-5.4",
display_name: "Retired GPT 5.4 Live",
visibility: "list",
supported_in_api: true,
},
],
});
};
const response = await callRoute(connection.id, "?refresh=true");
const body = (await response.json()) as RouteBody;
const modelIds = new Set((body.models || []).map((model) => model.id));
const syncedModels = await modelsDb.getSyncedAvailableModelsForConnection("codex", connection.id);
const syncedIds = new Set(syncedModels.map((model) => model.id));
assert.equal(response.status, 200);
assert.equal(body.source, "api");
assert.ok(modelIds.has("future-codex-experimental"));
assert.ok(modelIds.has("gpt-5.6-sol"));
assert.equal(modelIds.has("gpt-5.4"), false);
assert.ok(syncedIds.has("future-codex-experimental"));
assert.equal(syncedIds.has("gpt-5.4"), false);
});
test("provider models route falls back to local Codex catalog when live and GitHub fail", async () => {
const connection = await seedCodexConnection({ accessToken: "codex-access-token" });
globalThis.fetch = async () => new Response("upstream unavailable", { status: 503 });
const response = await callRoute(connection.id, "?refresh=true");
const body = (await response.json()) as RouteBody;
assert.equal(response.status, 200);
assert.equal(body.provider, "codex");
assert.equal(body.source, "local_catalog");
assert.equal(body.intentional, true);
assert.equal(body.warning, "Codex live and GitHub catalogs unavailable — using local catalog");
assert.ok(body.models?.some((model) => model.id === "gpt-5.6-sol"));
assert.ok(body.models?.some((model) => model.id === "gpt-5.5"));
assert.equal(
body.models?.some((model) => model.id.startsWith("gpt-5.4")),
false
);
});
test("provider models route returns curated GPT-5.6 variants when auto-fetch is disabled", async () => {
const connection = await seedCodexConnection({
apiKey: null,
accessToken: "codex-access",
providerSpecificData: { autoFetchModels: false },
});
const response = await callRoute(connection.id);
const body = (await response.json()) as RouteBody;
const modelIds = new Set((body.models || []).map((model) => model.id));
assert.equal(response.status, 200);
assert.equal(body.provider, "codex");
assert.equal(body.source, "local_catalog");
assert.ok(modelIds.has("gpt-5.6-sol-ultra"));
assert.ok(modelIds.has("gpt-5.6-sol-max"));
assert.ok(modelIds.has("gpt-5.6-terra-ultra"));
assert.ok(modelIds.has("gpt-5.6-luna-max"));
assert.equal(
[...modelIds].some((id) => String(id).startsWith("gpt-5.4")),
false
);
});