mirror of
https://github.com/diegosouzapw/OmniRoute.git
synced 2026-09-14 19:02:17 +03:00
* test(infra): retry recursive temp-dir removal on main (main twin of #11968)
`main` has been red since b342c1a361 on the vitest and integration gates:
✖ tests/unit/autoCombo/provider-family-combos.test.ts > auto/<family>
✖ chat pipeline applies Codex OAuth fingerprint and priority tier inside combos
Both call resetStorage() from beforeEach, which does an fs.rmSync(TEST_DATA_DIR,
{recursive: true, force: true}) with no retry, and intermittently loses the race
with a not-yet-released SQLite handle (ENOTEMPTY).
release/v3.8.51 fixed this in #11968 with a mechanical codemod adding
maxRetries/retryDelay to every recursive rm/rmSync/rmdirSync under tests/, but
that PR landed only on the release branch. Because main only receives work at
the release squash, it stayed broken for the whole cycle — and repo-wide gates
then turn every open PR into main red on checks unrelated to their diff.
This is the --base main twin: re-runs the same codemod that already shipped on
the release branch (scripts/ad-hoc/codemod-rm-maxretries.mjs), so the two
branches converge on identical test-teardown semantics. Test-only; no product
logic is touched.
The remaining three failures reported on #12133 (unit full suite exceeding its
4800s ceiling, package-artifact exceeding 1200s, and the boot-smoke that is
skipped as a consequence) are runner-contention timeouts, not code defects —
validate-release-green.mjs runs those heavy gates concurrently on one shared
hosted runner. There is no fix to port for those.
* chore(scripts): carry the rm-maxretries codemod onto main alongside its output
The codemod that generated the previous commit lives in the repo on
release/v3.8.51 (added by #11968) but was never on main. Bringing it over keeps
the tool next to the change it produced, so the transformation stays
reproducible and auditable from either branch.
182 lines
7.3 KiB
TypeScript
182 lines
7.3 KiB
TypeScript
/**
|
|
* Per-provider opt-out for the synthetic anonymous (no-auth) credential
|
|
* fallback (`noAuthFallbackDisabledProviders`).
|
|
*
|
|
* API-key gateway providers whose static definition declares
|
|
* `anonymousFallback: true` (opencode-go, opencode-zen, pollinations, …) get a
|
|
* synthetic "noauth" connection whenever all real configured connections are
|
|
* terminal (expired/banned/credits_exhausted) or all unavailable. Upstream
|
|
* endpoints now reject anonymous requests with 401 Missing API key, so operators
|
|
* need a per-provider toggle to disable that fallback while keeping the provider
|
|
* enabled and real keyed connections working.
|
|
*
|
|
* The gate applies ONLY to `anonymousFallback: true` API-key providers. True
|
|
* no-auth providers (NOAUTH_PROVIDERS / WEB_COOKIE_PROVIDERS entries with
|
|
* `noAuth: true`, e.g. opencode, mimocode) are NOT affected — for them the
|
|
* synthetic credential is the only credential path and `blockedProviders` is
|
|
* the disable mechanism.
|
|
*/
|
|
import test from "node:test";
|
|
import assert from "node:assert/strict";
|
|
import fs from "node:fs";
|
|
import os from "node:os";
|
|
import path from "node:path";
|
|
|
|
const TEST_DATA_DIR = fs.mkdtempSync(path.join(os.tmpdir(), "omniroute-anon-fallback-toggle-"));
|
|
process.env.DATA_DIR = TEST_DATA_DIR;
|
|
|
|
const core = await import("../../src/lib/db/core.ts");
|
|
const { getProviderCredentials } = await import("../../src/sse/services/auth.ts");
|
|
const { createProviderConnection, updateProviderConnection, deleteProviderConnectionsByProvider } =
|
|
await import("../../src/lib/db/providers.ts");
|
|
const { updateSettings } = await import("../../src/lib/db/settings.ts");
|
|
|
|
test.after(() => {
|
|
core.resetDbInstance();
|
|
fs.rmSync(TEST_DATA_DIR, { recursive: true, force: true, maxRetries: 5, retryDelay: 100 });
|
|
});
|
|
|
|
/** Set the opt-out list; pass null to remove the key entirely (absent setting). */
|
|
async function setNoAuthFallbackDisabledProviders(providers: string[] | null): Promise<void> {
|
|
if (providers === null) {
|
|
const db = core.getDbInstance();
|
|
db.prepare(
|
|
"DELETE FROM key_value WHERE namespace = 'settings' AND key = 'noAuthFallbackDisabledProviders'"
|
|
).run();
|
|
return;
|
|
}
|
|
await updateSettings({ noAuthFallbackDisabledProviders: providers });
|
|
}
|
|
|
|
function assertSyntheticNoAuth(creds: unknown, providerId: string): void {
|
|
assert.ok(creds, `${providerId} must resolve to synthetic no-auth credentials`);
|
|
assert.equal(
|
|
(creds as { connectionId?: string }).connectionId,
|
|
"noauth",
|
|
`${providerId} should return the synthetic "noauth" connection`
|
|
);
|
|
assert.equal((creds as { apiKey?: unknown }).apiKey, null, "anonymous access carries no api key");
|
|
}
|
|
|
|
test("a. backward compat default: no setting → terminal opencode-go falls back to noauth", async () => {
|
|
await setNoAuthFallbackDisabledProviders(null);
|
|
await deleteProviderConnectionsByProvider("opencode-go");
|
|
await createProviderConnection({
|
|
provider: "opencode-go",
|
|
authType: "apikey",
|
|
name: "expired-key-default",
|
|
apiKey: "sk-expired-default",
|
|
isActive: false,
|
|
testStatus: "expired",
|
|
});
|
|
|
|
const creds = await getProviderCredentials("opencode-go");
|
|
assertSyntheticNoAuth(creds, "opencode-go");
|
|
});
|
|
|
|
test("b. disabled + all terminal → allExpired result, never noauth", async () => {
|
|
await setNoAuthFallbackDisabledProviders(["opencode-go"]);
|
|
await deleteProviderConnectionsByProvider("opencode-go");
|
|
await createProviderConnection({
|
|
provider: "opencode-go",
|
|
authType: "apikey",
|
|
name: "expired-key-disabled",
|
|
apiKey: "sk-expired-disabled",
|
|
isActive: false,
|
|
testStatus: "expired",
|
|
});
|
|
|
|
const result = (await getProviderCredentials("opencode-go")) as Record<string, unknown> | null;
|
|
assert.ok(result, "must return a structured result (allExpired), not null");
|
|
assert.equal(result.allExpired, true, "terminal connections should surface as allExpired");
|
|
assert.notEqual(
|
|
result.connectionId,
|
|
"noauth",
|
|
"disabled provider must never receive synthetic no-auth credentials"
|
|
);
|
|
});
|
|
|
|
test("c. disabled + zero connections → null, never noauth", async () => {
|
|
await setNoAuthFallbackDisabledProviders(["opencode-go", "opencode-zen"]);
|
|
await deleteProviderConnectionsByProvider("opencode-zen");
|
|
|
|
const result = await getProviderCredentials("opencode-zen");
|
|
assert.equal(result, null, "disabled provider with no connections must not fall back to noauth");
|
|
});
|
|
|
|
test("d. disabled + healthy real connection → real credentials still selected", async () => {
|
|
await setNoAuthFallbackDisabledProviders(["opencode-go"]);
|
|
await deleteProviderConnectionsByProvider("opencode-go");
|
|
const created = await createProviderConnection({
|
|
provider: "opencode-go",
|
|
authType: "apikey",
|
|
name: "healthy-key",
|
|
apiKey: "sk-opencode-go-live",
|
|
isActive: true,
|
|
testStatus: "active",
|
|
});
|
|
|
|
const result = (await getProviderCredentials("opencode-go")) as Record<string, unknown> | null;
|
|
assert.ok(result, "healthy keyed connection must still resolve to credentials");
|
|
assert.equal(result.connectionId, created.id, "must select the real DB connection");
|
|
assert.equal(result.apiKey, "sk-opencode-go-live", "real api key must be returned");
|
|
assert.notEqual(result.connectionId, "noauth");
|
|
});
|
|
|
|
test("e. recovery: rate-limited → allRateLimited; quota recovered → real connection again", async () => {
|
|
await setNoAuthFallbackDisabledProviders(["opencode-go"]);
|
|
await deleteProviderConnectionsByProvider("opencode-go");
|
|
const created = await createProviderConnection({
|
|
provider: "opencode-go",
|
|
authType: "apikey",
|
|
name: "recovering-key",
|
|
apiKey: "sk-opencode-go-recover",
|
|
isActive: true,
|
|
testStatus: "active",
|
|
rateLimitedUntil: new Date(Date.now() + 60 * 60 * 1000).toISOString(),
|
|
});
|
|
|
|
const exhausted = (await getProviderCredentials("opencode-go")) as Record<string, unknown> | null;
|
|
assert.ok(exhausted, "rate-limited connection must produce a structured result");
|
|
assert.equal(
|
|
exhausted.allRateLimited,
|
|
true,
|
|
"while rate limited the provider should surface allRateLimited, not noauth"
|
|
);
|
|
assert.notEqual(exhausted.connectionId, "noauth");
|
|
|
|
await updateProviderConnection(created.id as string, { rateLimitedUntil: null });
|
|
|
|
const recovered = (await getProviderCredentials("opencode-go")) as Record<string, unknown> | null;
|
|
assert.ok(recovered, "recovered connection must resolve to credentials again");
|
|
assert.equal(
|
|
recovered.connectionId,
|
|
created.id,
|
|
"once quota recovers the real connection must be selected again"
|
|
);
|
|
assert.equal(recovered.apiKey, "sk-opencode-go-recover");
|
|
});
|
|
|
|
test("f. true no-auth provider unaffected: opencode still returns synthetic noauth", async () => {
|
|
await setNoAuthFallbackDisabledProviders(["opencode", "opencode-go", "opencode-zen"]);
|
|
|
|
const creds = await getProviderCredentials("opencode");
|
|
assertSyntheticNoAuth(creds, "opencode");
|
|
});
|
|
|
|
test("g. re-enable: removing provider from the list restores the fallback", async () => {
|
|
await setNoAuthFallbackDisabledProviders(["opencode-zen"]);
|
|
await deleteProviderConnectionsByProvider("opencode-go");
|
|
await createProviderConnection({
|
|
provider: "opencode-go",
|
|
authType: "apikey",
|
|
name: "expired-key-reenabled",
|
|
apiKey: "sk-expired-reenabled",
|
|
isActive: false,
|
|
testStatus: "expired",
|
|
});
|
|
|
|
const creds = await getProviderCredentials("opencode-go");
|
|
assertSyntheticNoAuth(creds, "opencode-go");
|
|
});
|