mirror of
https://github.com/diegosouzapw/OmniRoute.git
synced 2026-09-14 19:02:17 +03:00
* test(infra): retry recursive temp-dir removal on main (main twin of #11968)
`main` has been red since b342c1a361 on the vitest and integration gates:
✖ tests/unit/autoCombo/provider-family-combos.test.ts > auto/<family>
✖ chat pipeline applies Codex OAuth fingerprint and priority tier inside combos
Both call resetStorage() from beforeEach, which does an fs.rmSync(TEST_DATA_DIR,
{recursive: true, force: true}) with no retry, and intermittently loses the race
with a not-yet-released SQLite handle (ENOTEMPTY).
release/v3.8.51 fixed this in #11968 with a mechanical codemod adding
maxRetries/retryDelay to every recursive rm/rmSync/rmdirSync under tests/, but
that PR landed only on the release branch. Because main only receives work at
the release squash, it stayed broken for the whole cycle — and repo-wide gates
then turn every open PR into main red on checks unrelated to their diff.
This is the --base main twin: re-runs the same codemod that already shipped on
the release branch (scripts/ad-hoc/codemod-rm-maxretries.mjs), so the two
branches converge on identical test-teardown semantics. Test-only; no product
logic is touched.
The remaining three failures reported on #12133 (unit full suite exceeding its
4800s ceiling, package-artifact exceeding 1200s, and the boot-smoke that is
skipped as a consequence) are runner-contention timeouts, not code defects —
validate-release-green.mjs runs those heavy gates concurrently on one shared
hosted runner. There is no fix to port for those.
* chore(scripts): carry the rm-maxretries codemod onto main alongside its output
The codemod that generated the previous commit lives in the repo on
release/v3.8.51 (added by #11968) but was never on main. Bringing it over keeps
the tool next to the change it produced, so the transformation stays
reproducible and auditable from either branch.
168 lines
5.8 KiB
TypeScript
168 lines
5.8 KiB
TypeScript
// ENVIRONMENT NOTE (sandbox better-sqlite3 / glibc limitation, not a code defect):
|
|
// This test constructs or exercises a real better-sqlite3-backed SQLite database.
|
|
// better-sqlite3 is a native addon; production and CI load it normally, but some
|
|
// sandboxes/dev boxes ship a system glibc older than the prebuilt binary requires
|
|
// ("GLIBC_2.29 not found"), so the native module fails to dlopen and any test that
|
|
// reaches better-sqlite3 directly (or asserts stdout that the load-failure warning
|
|
// would pollute) fails HERE while passing in CI. This is a known environment
|
|
// limitation, not a defect in the code under test: the OmniRoute runtime itself
|
|
// cascades to node:sqlite/sql.js when better-sqlite3 is unavailable. See
|
|
// tests/unit/_helpers/betterSqlite3Availability.ts for a guard helper.
|
|
import test from "node:test";
|
|
import assert from "node:assert/strict";
|
|
import fs from "node:fs";
|
|
import os from "node:os";
|
|
import path from "node:path";
|
|
import Database from "better-sqlite3";
|
|
|
|
import { bootstrapEnv } from "../../scripts/build/bootstrap-env.mjs";
|
|
|
|
function withTempEnv(fn) {
|
|
const originalCwd = process.cwd();
|
|
const originalEnv = { ...process.env };
|
|
const tempRoot = fs.mkdtempSync(path.join(os.tmpdir(), "omniroute-bootstrap-test-"));
|
|
const tempCwd = path.join(tempRoot, "cwd");
|
|
const tempHome = path.join(tempRoot, "home");
|
|
|
|
fs.mkdirSync(tempCwd, { recursive: true });
|
|
fs.mkdirSync(tempHome, { recursive: true });
|
|
|
|
delete process.env.DATA_DIR;
|
|
delete process.env.XDG_CONFIG_HOME;
|
|
delete process.env.APPDATA;
|
|
delete process.env.JWT_SECRET;
|
|
delete process.env.STORAGE_ENCRYPTION_KEY;
|
|
delete process.env.STORAGE_ENCRYPTION_KEY_VERSION;
|
|
delete process.env.API_KEY_SECRET;
|
|
delete process.env.INITIAL_PASSWORD;
|
|
process.env.HOME = tempHome;
|
|
process.chdir(tempCwd);
|
|
|
|
try {
|
|
fn({ tempRoot, tempCwd, tempHome, dataDir: path.join(tempHome, ".omniroute") });
|
|
} finally {
|
|
process.chdir(originalCwd);
|
|
for (const key of Object.keys(process.env)) {
|
|
if (!(key in originalEnv)) delete process.env[key];
|
|
}
|
|
for (const [key, value] of Object.entries(originalEnv)) {
|
|
process.env[key] = value;
|
|
}
|
|
fs.rmSync(tempRoot, { recursive: true, force: true, maxRetries: 5, retryDelay: 100 });
|
|
}
|
|
}
|
|
|
|
test("bootstrapEnv prefers ~/.omniroute/.env over server.env", () => {
|
|
withTempEnv(({ dataDir }) => {
|
|
process.env.DATA_DIR = dataDir;
|
|
fs.mkdirSync(dataDir, { recursive: true });
|
|
fs.writeFileSync(
|
|
path.join(dataDir, ".env"),
|
|
"STORAGE_ENCRYPTION_KEY=from-dot-env\nJWT_SECRET=jwt-from-dot-env\n",
|
|
"utf8"
|
|
);
|
|
fs.writeFileSync(
|
|
path.join(dataDir, "server.env"),
|
|
"STORAGE_ENCRYPTION_KEY=from-server-env\nJWT_SECRET=jwt-from-server-env\n",
|
|
"utf8"
|
|
);
|
|
|
|
const env = bootstrapEnv({ quiet: true });
|
|
|
|
assert.equal(env.STORAGE_ENCRYPTION_KEY, "from-dot-env");
|
|
assert.equal(env.JWT_SECRET, "jwt-from-dot-env");
|
|
});
|
|
});
|
|
|
|
test("bootstrapEnv strips matching quotes from env values", () => {
|
|
withTempEnv(({ dataDir }) => {
|
|
process.env.DATA_DIR = dataDir;
|
|
fs.mkdirSync(dataDir, { recursive: true });
|
|
fs.writeFileSync(
|
|
path.join(dataDir, "server.env"),
|
|
'JWT_SECRET="jwt-from-server-env"\nCLAUDE_USER_AGENT="claude-cli/2.1.219 (external, cli)"\n',
|
|
"utf8"
|
|
);
|
|
|
|
const env = bootstrapEnv({ quiet: true });
|
|
|
|
assert.equal(env.JWT_SECRET, "jwt-from-server-env");
|
|
assert.equal(env.CLAUDE_USER_AGENT, "claude-cli/2.1.219 (external, cli)");
|
|
});
|
|
});
|
|
|
|
test("bootstrapEnv refuses to generate a new key over encrypted data", () => {
|
|
withTempEnv(({ dataDir }) => {
|
|
process.env.DATA_DIR = dataDir;
|
|
fs.mkdirSync(dataDir, { recursive: true });
|
|
const db = new Database(path.join(dataDir, "storage.sqlite"));
|
|
try {
|
|
db.exec(`
|
|
CREATE TABLE provider_connections (
|
|
id TEXT PRIMARY KEY,
|
|
access_token TEXT,
|
|
refresh_token TEXT,
|
|
api_key TEXT,
|
|
id_token TEXT
|
|
);
|
|
`);
|
|
db.prepare("INSERT INTO provider_connections (id, access_token) VALUES (?, ?)").run(
|
|
"conn-1",
|
|
"enc:v1:deadbeef:feedface:cafebabe"
|
|
);
|
|
} finally {
|
|
db.close();
|
|
}
|
|
|
|
assert.throws(
|
|
() => bootstrapEnv({ quiet: true }),
|
|
/Refusing to auto-generate STORAGE_ENCRYPTION_KEY/
|
|
);
|
|
});
|
|
});
|
|
|
|
test("bootstrapEnv fails closed when existing database cannot be inspected", () => {
|
|
withTempEnv(({ dataDir }) => {
|
|
process.env.DATA_DIR = dataDir;
|
|
fs.mkdirSync(path.join(dataDir, "storage.sqlite"), { recursive: true });
|
|
|
|
assert.throws(() => bootstrapEnv({ quiet: true }), /Unable to inspect existing database/);
|
|
});
|
|
});
|
|
|
|
test("bootstrapEnv ignores blank process.env values that would override persisted secrets (#6824)", () => {
|
|
withTempEnv(({ dataDir }) => {
|
|
process.env.DATA_DIR = dataDir;
|
|
fs.mkdirSync(dataDir, { recursive: true });
|
|
|
|
// Persisted secrets in server.env
|
|
fs.writeFileSync(
|
|
path.join(dataDir, "server.env"),
|
|
"STORAGE_ENCRYPTION_KEY=persisted-key\nJWT_SECRET=persisted-jwt\n",
|
|
"utf8"
|
|
);
|
|
|
|
// Simulate Docker `-e STORAGE_ENCRYPTION_KEY=` — sets an empty string
|
|
process.env.STORAGE_ENCRYPTION_KEY = "";
|
|
process.env.JWT_SECRET = "";
|
|
|
|
const env = bootstrapEnv({ quiet: true });
|
|
|
|
// Empty process.env values must NOT override persisted secrets
|
|
assert.equal(env.STORAGE_ENCRYPTION_KEY, "persisted-key");
|
|
assert.equal(env.JWT_SECRET, "persisted-jwt");
|
|
});
|
|
});
|
|
|
|
test("bootstrapEnv ignores blank dataDirOverride values", () => {
|
|
withTempEnv(({ dataDir }) => {
|
|
process.env.DATA_DIR = dataDir;
|
|
fs.mkdirSync(dataDir, { recursive: true });
|
|
fs.writeFileSync(path.join(dataDir, ".env"), "JWT_SECRET=jwt-from-dot-env\n", "utf8");
|
|
|
|
const env = bootstrapEnv({ dataDirOverride: " ", quiet: true });
|
|
|
|
assert.equal(env.JWT_SECRET, "jwt-from-dot-env");
|
|
});
|
|
});
|