Files
OmniRoute/tests/unit/chatcore-compression-analytics-write.test.ts
Diego Rodrigues de Sa e Souza 93265eede3 test(infra): retry recursive temp-dir removal on main (main twin of #11968) (#12246)
* test(infra): retry recursive temp-dir removal on main (main twin of #11968)

`main` has been red since b342c1a361 on the vitest and integration gates:

  ✖ tests/unit/autoCombo/provider-family-combos.test.ts > auto/<family>
  ✖ chat pipeline applies Codex OAuth fingerprint and priority tier inside combos

Both call resetStorage() from beforeEach, which does an fs.rmSync(TEST_DATA_DIR,
{recursive: true, force: true}) with no retry, and intermittently loses the race
with a not-yet-released SQLite handle (ENOTEMPTY).

release/v3.8.51 fixed this in #11968 with a mechanical codemod adding
maxRetries/retryDelay to every recursive rm/rmSync/rmdirSync under tests/, but
that PR landed only on the release branch. Because main only receives work at
the release squash, it stayed broken for the whole cycle — and repo-wide gates
then turn every open PR into main red on checks unrelated to their diff.

This is the --base main twin: re-runs the same codemod that already shipped on
the release branch (scripts/ad-hoc/codemod-rm-maxretries.mjs), so the two
branches converge on identical test-teardown semantics. Test-only; no product
logic is touched.

The remaining three failures reported on #12133 (unit full suite exceeding its
4800s ceiling, package-artifact exceeding 1200s, and the boot-smoke that is
skipped as a consequence) are runner-contention timeouts, not code defects —
validate-release-green.mjs runs those heavy gates concurrently on one shared
hosted runner. There is no fix to port for those.

* chore(scripts): carry the rm-maxretries codemod onto main alongside its output

The codemod that generated the previous commit lives in the repo on
release/v3.8.51 (added by #11968) but was never on main. Bringing it over keeps
the tool next to the change it produced, so the transformation stays
reproducible and auditable from either branch.
2026-09-01 01:48:00 -03:00

142 lines
4.6 KiB
TypeScript

// Characterization of writeCompressionAnalytics — the full compression analytics write extracted
// from handleChatCore's request-setup compression path (chatCore god-file decomposition, #3501).
// Returns the write promise; uses a real temp DB. Locks: the analytics row mapping (tokens, engine,
// validation_fallback, output_mode), the per-engine breakdown insert, and fail-open.
import { test, before, after } from "node:test";
import assert from "node:assert/strict";
import fs from "node:fs";
import os from "node:os";
import path from "node:path";
const testDataDir = fs.mkdtempSync(path.join(os.tmpdir(), "omni-comp-analytics-test-"));
process.env.DATA_DIR = testDataDir;
const coreDb = await import("../../src/lib/db/core.ts");
const { writeCompressionAnalytics } =
await import("../../open-sse/handlers/chatCore/compressionAnalyticsWrite.ts");
type Stats = Parameters<typeof writeCompressionAnalytics>[0]["stats"];
function makeStats(overrides: Record<string, unknown> = {}): Stats {
return {
originalTokens: 200,
compressedTokens: 80,
fallbackApplied: false,
engine: "rtk",
compressionComboId: null,
durationMs: 12,
rtkRawOutputPointers: [],
engineBreakdown: [],
...overrides,
} as unknown as Stats;
}
function analyticsRow(requestId: string): Record<string, unknown> | undefined {
try {
return coreDb
.getDbInstance()
.prepare(
"SELECT mode, engine, original_tokens AS orig, compressed_tokens AS comp, tokens_saved AS saved, estimated_usd_saved AS usd, validation_fallback AS vf FROM compression_analytics WHERE request_id = ?"
)
.get(requestId) as Record<string, unknown> | undefined;
} catch {
return undefined;
}
}
function breakdownCount(requestId: string): number {
try {
const row = coreDb
.getDbInstance()
.prepare("SELECT COUNT(*) AS n FROM compression_engine_breakdown WHERE request_id = ?")
.get(requestId) as { n: number } | undefined;
return row?.n ?? 0;
} catch {
return 0;
}
}
async function waitFor(pred: () => boolean, timeoutMs = 3000) {
const deadline = Date.now() + timeoutMs;
while (Date.now() < deadline && !pred()) {
await new Promise((r) => setTimeout(r, 25));
}
}
function baseOpts(requestId: string, statsOverrides = {}) {
return {
stats: makeStats(statsOverrides),
provider: "openai",
effectiveModel: "gpt-x",
effectiveServiceTier: "standard",
comboName: null,
mode: "rtk",
compressionComboId: null,
skillRequestId: requestId,
cavemanOutputModeApplied: false,
cavemanOutputModeIntensity: null,
} as Parameters<typeof writeCompressionAnalytics>[0];
}
before(async () => {
await coreDb.ensureDbInitialized();
});
after(() => {
coreDb.resetDbInstance();
try {
fs.rmSync(testDataDir, { recursive: true, force: true, maxRetries: 5, retryDelay: 100 });
} catch {
// best-effort cleanup
}
});
test("writes the analytics row with mapped tokens/engine and resolves", async () => {
await writeCompressionAnalytics(baseOpts("ca-req-1"));
const row = analyticsRow("ca-req-1");
assert.ok(row, "expected a compression_analytics row");
assert.equal(row!.engine, "rtk");
assert.equal(row!.orig, 200);
assert.equal(row!.comp, 80);
assert.equal(row!.saved, 120);
assert.equal(row!.vf, 0);
});
test("validation_fallback is 1 when the stats flagged a fallback", async () => {
await writeCompressionAnalytics(baseOpts("ca-req-2", { fallbackApplied: true }));
const row = analyticsRow("ca-req-2");
assert.equal(row!.vf, 1);
});
test("inserts a per-engine breakdown when present", async () => {
await writeCompressionAnalytics(
baseOpts("ca-req-3", {
engineBreakdown: [
{ engine: "rtk", originalTokens: 200, compressedTokens: 120, durationMs: 5 },
{ engine: "caveman", originalTokens: 120, compressedTokens: 80, durationMs: 4 },
],
})
);
await waitFor(() => breakdownCount("ca-req-3") >= 2);
assert.equal(breakdownCount("ca-req-3"), 2);
});
test("inserts the analytics row when calculateCost throws", async () => {
await writeCompressionAnalytics(baseOpts("ca-req-cost-error"), {
calculateCost: async () => {
throw new Error("forced cost-estimate failure");
},
});
const row = analyticsRow("ca-req-cost-error");
assert.ok(row, "expected a compression_analytics row despite the cost-estimate failure");
assert.equal(row!.saved, 120);
assert.equal(row!.usd, null);
});
test("never rejects even on a bad write (fail-open)", async () => {
coreDb.resetDbInstance();
await assert.doesNotReject(writeCompressionAnalytics(baseOpts("ca-req-4")));
await coreDb.ensureDbInitialized();
});