Files
OmniRoute/tests/unit/cli-providers-command.test.ts
Diego Rodrigues de Sa e Souza 93265eede3 test(infra): retry recursive temp-dir removal on main (main twin of #11968) (#12246)
* test(infra): retry recursive temp-dir removal on main (main twin of #11968)

`main` has been red since b342c1a361 on the vitest and integration gates:

  ✖ tests/unit/autoCombo/provider-family-combos.test.ts > auto/<family>
  ✖ chat pipeline applies Codex OAuth fingerprint and priority tier inside combos

Both call resetStorage() from beforeEach, which does an fs.rmSync(TEST_DATA_DIR,
{recursive: true, force: true}) with no retry, and intermittently loses the race
with a not-yet-released SQLite handle (ENOTEMPTY).

release/v3.8.51 fixed this in #11968 with a mechanical codemod adding
maxRetries/retryDelay to every recursive rm/rmSync/rmdirSync under tests/, but
that PR landed only on the release branch. Because main only receives work at
the release squash, it stayed broken for the whole cycle — and repo-wide gates
then turn every open PR into main red on checks unrelated to their diff.

This is the --base main twin: re-runs the same codemod that already shipped on
the release branch (scripts/ad-hoc/codemod-rm-maxretries.mjs), so the two
branches converge on identical test-teardown semantics. Test-only; no product
logic is touched.

The remaining three failures reported on #12133 (unit full suite exceeding its
4800s ceiling, package-artifact exceeding 1200s, and the boot-smoke that is
skipped as a consequence) are runner-contention timeouts, not code defects —
validate-release-green.mjs runs those heavy gates concurrently on one shared
hosted runner. There is no fix to port for those.

* chore(scripts): carry the rm-maxretries codemod onto main alongside its output

The codemod that generated the previous commit lives in the repo on
release/v3.8.51 (added by #11968) but was never on main. Bringing it over keeps
the tool next to the change it produced, so the transformation stays
reproducible and auditable from either branch.
2026-09-01 01:48:00 -03:00

158 lines
5.5 KiB
TypeScript

// ENVIRONMENT NOTE (sandbox better-sqlite3 / glibc limitation, not a code defect):
// This test constructs or exercises a real better-sqlite3-backed SQLite database.
// better-sqlite3 is a native addon; production and CI load it normally, but some
// sandboxes/dev boxes ship a system glibc older than the prebuilt binary requires
// ("GLIBC_2.29 not found"), so the native module fails to dlopen and any test that
// reaches better-sqlite3 directly (or asserts stdout that the load-failure warning
// would pollute) fails HERE while passing in CI. This is a known environment
// limitation, not a defect in the code under test: the OmniRoute runtime itself
// cascades to node:sqlite/sql.js when better-sqlite3 is unavailable. See
// tests/unit/_helpers/betterSqlite3Availability.ts for a guard helper.
import test from "node:test";
import assert from "node:assert/strict";
import fs from "node:fs";
import os from "node:os";
import path from "node:path";
import Database from "better-sqlite3";
const ORIGINAL_DATA_DIR = process.env.DATA_DIR;
const ORIGINAL_STORAGE_ENCRYPTION_KEY = process.env.STORAGE_ENCRYPTION_KEY;
const ORIGINAL_FETCH = globalThis.fetch;
function createTempDataDir() {
return fs.mkdtempSync(path.join(os.tmpdir(), "omniroute-cli-providers-"));
}
async function withProvidersEnv(fn: (dataDir: string) => Promise<void>) {
const dataDir = createTempDataDir();
process.env.DATA_DIR = dataDir;
delete process.env.STORAGE_ENCRYPTION_KEY;
globalThis.fetch = ORIGINAL_FETCH;
try {
await fn(dataDir);
} finally {
fs.rmSync(dataDir, { recursive: true, force: true, maxRetries: 5, retryDelay: 100 });
globalThis.fetch = ORIGINAL_FETCH;
if (ORIGINAL_DATA_DIR === undefined) delete process.env.DATA_DIR;
else process.env.DATA_DIR = ORIGINAL_DATA_DIR;
if (ORIGINAL_STORAGE_ENCRYPTION_KEY === undefined) delete process.env.STORAGE_ENCRYPTION_KEY;
else process.env.STORAGE_ENCRYPTION_KEY = ORIGINAL_STORAGE_ENCRYPTION_KEY;
}
}
async function createProvider(dataDir: string) {
const { ensureProviderSchema, upsertApiKeyProviderConnection } =
await import("../../bin/cli/provider-store.mjs");
const db = new Database(path.join(dataDir, "storage.sqlite"));
ensureProviderSchema(db);
const connection = upsertApiKeyProviderConnection(db, {
provider: "openai",
name: "OpenAI CLI",
apiKey: "sk-test",
});
db.close();
return connection;
}
test("providers list succeeds with configured providers", async () => {
await withProvidersEnv(async (dataDir) => {
await createProvider(dataDir);
const { runListCommand } = await import("../../bin/cli/commands/providers.mjs");
const exitCode = await runListCommand({ json: true });
assert.equal(exitCode, 0);
});
});
test("providers available lists supported provider catalog", async () => {
await withProvidersEnv(async () => {
const { runAvailableCommand } = await import("../../bin/cli/commands/providers.mjs");
const logs: string[] = [];
const originalLog = console.log;
console.log = (...args: unknown[]) => {
logs.push(args.join(" "));
};
try {
const exitCode = await runAvailableCommand({ json: true, search: "openai" });
assert.equal(exitCode, 0);
} finally {
console.log = originalLog;
}
const result = JSON.parse(logs.join("\n")) as {
providers: Array<{ id: string; category: string }>;
};
assert.ok(result.providers.some((provider) => provider.id === "openai"));
assert.ok(result.providers.some((provider) => provider.category === "api-key"));
});
});
test("providers test updates provider status from upstream result", async () => {
await withProvidersEnv(async (dataDir) => {
await createProvider(dataDir);
globalThis.fetch = (async () =>
new Response(JSON.stringify({ data: [] }), {
status: 200,
headers: { "Content-Type": "application/json" },
})) as typeof fetch;
const { runTestCommand } = await import("../../bin/cli/commands/providers.mjs");
const exitCode = await runTestCommand("OpenAI CLI", {});
assert.equal(exitCode, 0);
const db = new Database(path.join(dataDir, "storage.sqlite"));
const row = db.prepare("SELECT test_status, last_error FROM provider_connections").get() as {
test_status: string;
last_error: string | null;
};
db.close();
assert.equal(row.test_status, "active");
assert.equal(row.last_error, null);
});
});
test("providers validate fails encrypted API keys without storage key", async () => {
await withProvidersEnv(async (dataDir) => {
const db = new Database(path.join(dataDir, "storage.sqlite"));
db.prepare(
`CREATE TABLE provider_connections (
id TEXT PRIMARY KEY,
provider TEXT NOT NULL,
auth_type TEXT,
name TEXT,
api_key TEXT,
is_active INTEGER,
priority INTEGER,
created_at TEXT,
updated_at TEXT
)`
).run();
db.prepare(
`INSERT INTO provider_connections
(id, provider, auth_type, name, api_key, is_active, priority, created_at, updated_at)
VALUES (?, ?, ?, ?, ?, 1, 1, ?, ?)`
).run(
"conn-1",
"openai",
"apikey",
"Encrypted OpenAI",
"enc:v1:00112233445566778899aabbccddeeff:00:00112233445566778899aabbccddeeff",
new Date().toISOString(),
new Date().toISOString()
);
db.close();
const { runValidateCommand } = await import("../../bin/cli/commands/providers.mjs");
const exitCode = await runValidateCommand({ json: true });
assert.equal(exitCode, 1);
});
});