mirror of
https://github.com/diegosouzapw/OmniRoute.git
synced 2026-09-14 19:02:17 +03:00
93265eede3
* test(infra): retry recursive temp-dir removal on main (main twin of #11968)
`main` has been red since b342c1a361 on the vitest and integration gates:
✖ tests/unit/autoCombo/provider-family-combos.test.ts > auto/<family>
✖ chat pipeline applies Codex OAuth fingerprint and priority tier inside combos
Both call resetStorage() from beforeEach, which does an fs.rmSync(TEST_DATA_DIR,
{recursive: true, force: true}) with no retry, and intermittently loses the race
with a not-yet-released SQLite handle (ENOTEMPTY).
release/v3.8.51 fixed this in #11968 with a mechanical codemod adding
maxRetries/retryDelay to every recursive rm/rmSync/rmdirSync under tests/, but
that PR landed only on the release branch. Because main only receives work at
the release squash, it stayed broken for the whole cycle — and repo-wide gates
then turn every open PR into main red on checks unrelated to their diff.
This is the --base main twin: re-runs the same codemod that already shipped on
the release branch (scripts/ad-hoc/codemod-rm-maxretries.mjs), so the two
branches converge on identical test-teardown semantics. Test-only; no product
logic is touched.
The remaining three failures reported on #12133 (unit full suite exceeding its
4800s ceiling, package-artifact exceeding 1200s, and the boot-smoke that is
skipped as a consequence) are runner-contention timeouts, not code defects —
validate-release-green.mjs runs those heavy gates concurrently on one shared
hosted runner. There is no fix to port for those.
* chore(scripts): carry the rm-maxretries codemod onto main alongside its output
The codemod that generated the previous commit lives in the repo on
release/v3.8.51 (added by #11968) but was never on main. Bringing it over keeps
the tool next to the change it produced, so the transformation stays
reproducible and auditable from either branch.
66 lines
2.4 KiB
TypeScript
66 lines
2.4 KiB
TypeScript
import { test } from "node:test";
|
|
import assert from "node:assert/strict";
|
|
import { register } from "node:module";
|
|
import Module from "node:module";
|
|
import fs from "node:fs";
|
|
import os from "node:os";
|
|
import path from "node:path";
|
|
|
|
// #8826: better-sqlite3 v12 loads its native addon lazily -- import("better-sqlite3")
|
|
// SUCCEEDS and only new Database() throws "Could not locate the bindings file" when
|
|
// there is no .node binding for the runtime ABI (e.g. CachyOS + Node v26 via AUR).
|
|
// openSqliteDatabase() only fell back when the *import* failed; the construction-time
|
|
// failure was translated into "Run: omniroute runtime repair" guidance and aborted.
|
|
|
|
const FIXTURE_DIR = new URL("fixtures/", import.meta.url).pathname;
|
|
const hookPath = path.join(FIXTURE_DIR, "8826-mock-better-sqlite3.mjs");
|
|
|
|
// Register the ESM hook to return a module whose Database constructor throws
|
|
register(hookPath, import.meta.url);
|
|
|
|
// Patch Module._load so CJS createRequire("better-sqlite3") in driverFactory.ts
|
|
// also gets a constructor that throws the bindings error.
|
|
const originalLoad = Module._load;
|
|
Module._load = function patchedLoad(request, parent, isMain) {
|
|
if (request === "better-sqlite3") {
|
|
function FakeBetterSqlite() {
|
|
throw new Error(
|
|
"Could not locate the bindings file. Tried:\n" +
|
|
" -> /fake/path/better_sqlite3.node"
|
|
);
|
|
}
|
|
return FakeBetterSqlite;
|
|
}
|
|
// @ts-expect-error Module._load is a CJS internal
|
|
return originalLoad.call(this, request, parent, isMain);
|
|
};
|
|
|
|
const { openOmniRouteDb } = await import("../../bin/cli/sqlite.mjs");
|
|
|
|
test("#8826: openOmniRouteDb() falls back to node:sqlite when better-sqlite3 native binding is missing (construction-time failure)", async (t) => {
|
|
const tmpDir = fs.mkdtempSync(path.join(os.tmpdir(), "omniroute-8826-"));
|
|
t.after(() => {
|
|
try { fs.rmSync(tmpDir, { recursive: true, force: true, maxRetries: 5, retryDelay: 100 }); } catch {}
|
|
Module._load = originalLoad;
|
|
});
|
|
|
|
const origDataDir = process.env.DATA_DIR;
|
|
process.env.DATA_DIR = tmpDir;
|
|
t.after(() => {
|
|
if (origDataDir) {
|
|
process.env.DATA_DIR = origDataDir;
|
|
} else {
|
|
delete process.env.DATA_DIR;
|
|
}
|
|
});
|
|
|
|
const result = await openOmniRouteDb();
|
|
|
|
assert.ok(result.db, "openOmniRouteDb() should return a working db adapter");
|
|
assert.equal(
|
|
result.db.driver,
|
|
"node:sqlite",
|
|
"should fall back to node:sqlite when better-sqlite3 constructor throws (#8826)"
|
|
);
|
|
});
|