Files
OmniRoute/tests/unit/combo-builder-model-source-5477.test.ts
Diego Rodrigues de Sa e Souza 93265eede3 test(infra): retry recursive temp-dir removal on main (main twin of #11968) (#12246)
* test(infra): retry recursive temp-dir removal on main (main twin of #11968)

`main` has been red since b342c1a361 on the vitest and integration gates:

  ✖ tests/unit/autoCombo/provider-family-combos.test.ts > auto/<family>
  ✖ chat pipeline applies Codex OAuth fingerprint and priority tier inside combos

Both call resetStorage() from beforeEach, which does an fs.rmSync(TEST_DATA_DIR,
{recursive: true, force: true}) with no retry, and intermittently loses the race
with a not-yet-released SQLite handle (ENOTEMPTY).

release/v3.8.51 fixed this in #11968 with a mechanical codemod adding
maxRetries/retryDelay to every recursive rm/rmSync/rmdirSync under tests/, but
that PR landed only on the release branch. Because main only receives work at
the release squash, it stayed broken for the whole cycle — and repo-wide gates
then turn every open PR into main red on checks unrelated to their diff.

This is the --base main twin: re-runs the same codemod that already shipped on
the release branch (scripts/ad-hoc/codemod-rm-maxretries.mjs), so the two
branches converge on identical test-teardown semantics. Test-only; no product
logic is touched.

The remaining three failures reported on #12133 (unit full suite exceeding its
4800s ceiling, package-artifact exceeding 1200s, and the boot-smoke that is
skipped as a consequence) are runner-contention timeouts, not code defects —
validate-release-green.mjs runs those heavy gates concurrently on one shared
hosted runner. There is no fix to port for those.

* chore(scripts): carry the rm-maxretries codemod onto main alongside its output

The codemod that generated the previous commit lives in the repo on
release/v3.8.51 (added by #11968) but was never on main. Bringing it over keeps
the tool next to the change it produced, so the transformation stays
reproducible and auditable from either branch.
2026-09-01 01:48:00 -03:00

46 lines
2.2 KiB
TypeScript

/**
* #5477 — the combo builder's per-model option construction was extracted into a
* shared `buildModelOptions` helper (one source of truth for the synced /
* built-in / custom / fallback branches). This test drives the real builder and
* locks the custom-model **source classification** branch: a custom model whose
* stored `source` is one of api-sync/auto-sync/imported must surface as
* `imported`, everything else as `custom`. A silent divergence in that mapping is
* exactly what the extraction could introduce.
*/
import test from "node:test";
import assert from "node:assert/strict";
import fs from "node:fs";
import os from "node:os";
import path from "node:path";
const TEST_DATA_DIR = fs.mkdtempSync(path.join(os.tmpdir(), "omniroute-combo-source-"));
process.env.DATA_DIR = TEST_DATA_DIR;
const core = await import("../../src/lib/db/core.ts");
const modelsDb = await import("../../src/lib/db/models.ts");
const { getComboBuilderOptions } = await import("../../src/lib/combos/builderOptions.ts");
test.after(() => {
core.resetDbInstance();
fs.rmSync(TEST_DATA_DIR, { recursive: true, force: true, maxRetries: 5, retryDelay: 100 });
});
test("#5477 buildModelOptions classifies custom-model source (manual -> custom, api-sync -> imported)", async () => {
// Attach to a no-auth provider ("opencode") — it surfaces in the builder
// without a configured connection, so the custom-model branch is exercised.
await modelsDb.addCustomModel("opencode", "zzz-manual-5477", "Manual 5477", "manual");
await modelsDb.addCustomModel("opencode", "zzz-apisync-5477", "ApiSync 5477", "api-sync");
const payload = await getComboBuilderOptions();
const allModels = payload.providers.flatMap((p) => p.models);
const manual = allModels.find((m) => m.id === "zzz-manual-5477");
const apiSync = allModels.find((m) => m.id === "zzz-apisync-5477");
assert.ok(manual, "manual custom model must appear in the combo builder output");
assert.ok(apiSync, "api-sync custom model must appear in the combo builder output");
assert.equal(manual.source, "custom", "source=manual must classify as 'custom'");
assert.equal(apiSync.source, "imported", "source=api-sync must classify as 'imported'");
});